From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJIre-0004mM-1v for qemu-devel@nongnu.org; Wed, 13 Jan 2016 05:41:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJIrZ-0002Al-Tk for qemu-devel@nongnu.org; Wed, 13 Jan 2016 05:41:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJIrZ-0002AF-Nm for qemu-devel@nongnu.org; Wed, 13 Jan 2016 05:41:13 -0500 From: Amit Shah Date: Wed, 13 Jan 2016 16:10:44 +0530 Message-Id: <6ba996bb458f4620e62984f2561c270a636bb500.1452681449.git.amit.shah@redhat.com> In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PULL 3/6] Postcopy: Send events/change state on incoming side List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Amit Shah , Peter Maydell , "Dr. David Alan Gilbert" , Juan Quintela From: "Dr. David Alan Gilbert" I missed the calls to send migration events on the destination side as we enter postcopy. Take care when adding them not to do it after state has been freed. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: zhanghailiang Reviewed-by: Juan Quintela Reviewed-by: Amit Shah Message-Id: <1450266458-3178-4-git-send-email-dgilbert@redhat.com> Signed-off-by: Amit Shah --- migration/savevm.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index 0ad1b93..c469bad 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1399,6 +1399,8 @@ static void *postcopy_ram_listen_thread(void *opaque) MigrationIncomingState *mis = migration_incoming_get_current(); int load_res; + migrate_set_state(&mis->state, MIGRATION_STATUS_ACTIVE, + MIGRATION_STATUS_POSTCOPY_ACTIVE); qemu_sem_post(&mis->listen_thread_sem); trace_postcopy_ram_listen_thread_start(); @@ -1415,6 +1417,8 @@ static void *postcopy_ram_listen_thread(void *opaque) if (load_res < 0) { error_report("%s: loadvm failed: %d", __func__, load_res); qemu_file_set_error(f, load_res); + migrate_set_state(&mis->state, MIGRATION_STATUS_POSTCOPY_ACTIVE, + MIGRATION_STATUS_FAILED); } else { /* * This looks good, but it's possible that the device loading in the @@ -1424,13 +1428,6 @@ static void *postcopy_ram_listen_thread(void *opaque) qemu_event_wait(&mis->main_thread_load_event); } postcopy_ram_incoming_cleanup(mis); - /* - * If everything has worked fine, then the main thread has waited - * for us to start, and we're the last use of the mis. - * (If something broke then qemu will have to exit anyway since it's - * got a bad migration state). - */ - migration_incoming_state_destroy(); if (load_res < 0) { /* @@ -1442,6 +1439,17 @@ static void *postcopy_ram_listen_thread(void *opaque) exit(EXIT_FAILURE); } + migrate_set_state(&mis->state, MIGRATION_STATUS_POSTCOPY_ACTIVE, + MIGRATION_STATUS_COMPLETED); + /* + * If everything has worked fine, then the main thread has waited + * for us to start, and we're the last use of the mis. + * (If something broke then qemu will have to exit anyway since it's + * got a bad migration state). + */ + migration_incoming_state_destroy(); + + return NULL; } -- 2.5.0