From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B64C3B187 for ; Thu, 13 Feb 2020 00:25:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA272222C2 for ; Thu, 13 Feb 2020 00:25:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729324AbgBMAZe (ORCPT ); Wed, 12 Feb 2020 19:25:34 -0500 Received: from mga05.intel.com ([192.55.52.43]:9911 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727032AbgBMAZd (ORCPT ); Wed, 12 Feb 2020 19:25:33 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 16:25:33 -0800 X-IronPort-AV: E=Sophos;i="5.70,434,1574150400"; d="scan'208";a="380936140" Received: from ahduyck-desk1.jf.intel.com ([10.7.198.76]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 16:25:31 -0800 Message-ID: <6bb20b3d4e3362337e1a4c8a4be13f6acda5b0ec.camel@linux.intel.com> Subject: Re: [PATCH v4 7/8] pid: export pidfd_get_pid From: Alexander Duyck To: Minchan Kim , Andrew Morton Cc: LKML , linux-mm , linux-api@vger.kernel.org, oleksandr@redhat.com, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , Christian Brauner Date: Wed, 12 Feb 2020 16:25:31 -0800 In-Reply-To: <20200212233946.246210-8-minchan@kernel.org> References: <20200212233946.246210-1-minchan@kernel.org> <20200212233946.246210-8-minchan@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-02-12 at 15:39 -0800, Minchan Kim wrote: > process_madvise syscall needs pidfd_get_pid function to translate > pidfd to pid so this patch exports the function. > > Cc: Christian Brauner > Signed-off-by: Minchan Kim I think you might have misunderstood my earlier comments. This should be patch 2 in your set. What is patch 8 should be folded into you existing patch 2 and become patch 3 with the rest of your patches shifted by 1 since you are reordering them. Otherwise the code itself appears to not have changed anything so it looks fine to me. Reviewed-by: Alexander Duyck > --- > include/linux/pid.h | 1 + > kernel/exit.c | 17 ----------------- > kernel/pid.c | 17 +++++++++++++++++ > 3 files changed, 18 insertions(+), 17 deletions(-) > > diff --git a/include/linux/pid.h b/include/linux/pid.h > index 998ae7d24450..023d9c3a8edc 100644 > --- a/include/linux/pid.h > +++ b/include/linux/pid.h > @@ -75,6 +75,7 @@ extern const struct file_operations pidfd_fops; > struct file; > > extern struct pid *pidfd_pid(const struct file *file); > +extern struct pid *pidfd_get_pid(unsigned int fd); > > static inline struct pid *get_pid(struct pid *pid) > { > diff --git a/kernel/exit.c b/kernel/exit.c > index 0b81b26a872a..43375f9d8bbc 100644 > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -1470,23 +1470,6 @@ static long do_wait(struct wait_opts *wo) > return retval; > } > > -static struct pid *pidfd_get_pid(unsigned int fd) > -{ > - struct fd f; > - struct pid *pid; > - > - f = fdget(fd); > - if (!f.file) > - return ERR_PTR(-EBADF); > - > - pid = pidfd_pid(f.file); > - if (!IS_ERR(pid)) > - get_pid(pid); > - > - fdput(f); > - return pid; > -} > - > static long kernel_waitid(int which, pid_t upid, struct waitid_info *infop, > int options, struct rusage *ru) > { > diff --git a/kernel/pid.c b/kernel/pid.c > index 0f4ecb57214c..360ba480a2a9 100644 > --- a/kernel/pid.c > +++ b/kernel/pid.c > @@ -496,6 +496,23 @@ struct pid *find_ge_pid(int nr, struct pid_namespace *ns) > return idr_get_next(&ns->idr, &nr); > } > > +struct pid *pidfd_get_pid(unsigned int fd) > +{ > + struct fd f; > + struct pid *pid; > + > + f = fdget(fd); > + if (!f.file) > + return ERR_PTR(-EBADF); > + > + pid = pidfd_pid(f.file); > + if (!IS_ERR(pid)) > + get_pid(pid); > + > + fdput(f); > + return pid; > +} > + > /** > * pidfd_create() - Create a new pid file descriptor. > * From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [PATCH v4 7/8] pid: export pidfd_get_pid Date: Wed, 12 Feb 2020 16:25:31 -0800 Message-ID: <6bb20b3d4e3362337e1a4c8a4be13f6acda5b0ec.camel@linux.intel.com> References: <20200212233946.246210-1-minchan@kernel.org> <20200212233946.246210-8-minchan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200212233946.246210-8-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Minchan Kim , Andrew Morton Cc: LKML , linux-mm , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, oleksandr-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , Christian Brauner List-Id: linux-api@vger.kernel.org On Wed, 2020-02-12 at 15:39 -0800, Minchan Kim wrote: > process_madvise syscall needs pidfd_get_pid function to translate > pidfd to pid so this patch exports the function. > > Cc: Christian Brauner > Signed-off-by: Minchan Kim I think you might have misunderstood my earlier comments. This should be patch 2 in your set. What is patch 8 should be folded into you existing patch 2 and become patch 3 with the rest of your patches shifted by 1 since you are reordering them. Otherwise the code itself appears to not have changed anything so it looks fine to me. Reviewed-by: Alexander Duyck > --- > include/linux/pid.h | 1 + > kernel/exit.c | 17 ----------------- > kernel/pid.c | 17 +++++++++++++++++ > 3 files changed, 18 insertions(+), 17 deletions(-) > > diff --git a/include/linux/pid.h b/include/linux/pid.h > index 998ae7d24450..023d9c3a8edc 100644 > --- a/include/linux/pid.h > +++ b/include/linux/pid.h > @@ -75,6 +75,7 @@ extern const struct file_operations pidfd_fops; > struct file; > > extern struct pid *pidfd_pid(const struct file *file); > +extern struct pid *pidfd_get_pid(unsigned int fd); > > static inline struct pid *get_pid(struct pid *pid) > { > diff --git a/kernel/exit.c b/kernel/exit.c > index 0b81b26a872a..43375f9d8bbc 100644 > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -1470,23 +1470,6 @@ static long do_wait(struct wait_opts *wo) > return retval; > } > > -static struct pid *pidfd_get_pid(unsigned int fd) > -{ > - struct fd f; > - struct pid *pid; > - > - f = fdget(fd); > - if (!f.file) > - return ERR_PTR(-EBADF); > - > - pid = pidfd_pid(f.file); > - if (!IS_ERR(pid)) > - get_pid(pid); > - > - fdput(f); > - return pid; > -} > - > static long kernel_waitid(int which, pid_t upid, struct waitid_info *infop, > int options, struct rusage *ru) > { > diff --git a/kernel/pid.c b/kernel/pid.c > index 0f4ecb57214c..360ba480a2a9 100644 > --- a/kernel/pid.c > +++ b/kernel/pid.c > @@ -496,6 +496,23 @@ struct pid *find_ge_pid(int nr, struct pid_namespace *ns) > return idr_get_next(&ns->idr, &nr); > } > > +struct pid *pidfd_get_pid(unsigned int fd) > +{ > + struct fd f; > + struct pid *pid; > + > + f = fdget(fd); > + if (!f.file) > + return ERR_PTR(-EBADF); > + > + pid = pidfd_pid(f.file); > + if (!IS_ERR(pid)) > + get_pid(pid); > + > + fdput(f); > + return pid; > +} > + > /** > * pidfd_create() - Create a new pid file descriptor. > * From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A909CC352A4 for ; Thu, 13 Feb 2020 00:25:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69852206B6 for ; Thu, 13 Feb 2020 00:25:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69852206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 10BFF6B04E3; Wed, 12 Feb 2020 19:25:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BB9C6B04E5; Wed, 12 Feb 2020 19:25:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F13146B04E6; Wed, 12 Feb 2020 19:25:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id D79506B04E3 for ; Wed, 12 Feb 2020 19:25:33 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 98175181AEF07 for ; Thu, 13 Feb 2020 00:25:33 +0000 (UTC) X-FDA: 76483210146.26.bread17_4d8b9e836d95f X-HE-Tag: bread17_4d8b9e836d95f X-Filterd-Recvd-Size: 4467 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Feb 2020 00:25:32 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 16:25:31 -0800 X-IronPort-AV: E=Sophos;i="5.70,434,1574150400"; d="scan'208";a="380936140" Received: from ahduyck-desk1.jf.intel.com ([10.7.198.76]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 16:25:31 -0800 Message-ID: <6bb20b3d4e3362337e1a4c8a4be13f6acda5b0ec.camel@linux.intel.com> Subject: Re: [PATCH v4 7/8] pid: export pidfd_get_pid From: Alexander Duyck To: Minchan Kim , Andrew Morton Cc: LKML , linux-mm , linux-api@vger.kernel.org, oleksandr@redhat.com, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , Christian Brauner Date: Wed, 12 Feb 2020 16:25:31 -0800 In-Reply-To: <20200212233946.246210-8-minchan@kernel.org> References: <20200212233946.246210-1-minchan@kernel.org> <20200212233946.246210-8-minchan@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2020-02-12 at 15:39 -0800, Minchan Kim wrote: > process_madvise syscall needs pidfd_get_pid function to translate > pidfd to pid so this patch exports the function. > > Cc: Christian Brauner > Signed-off-by: Minchan Kim I think you might have misunderstood my earlier comments. This should be patch 2 in your set. What is patch 8 should be folded into you existing patch 2 and become patch 3 with the rest of your patches shifted by 1 since you are reordering them. Otherwise the code itself appears to not have changed anything so it looks fine to me. Reviewed-by: Alexander Duyck > --- > include/linux/pid.h | 1 + > kernel/exit.c | 17 ----------------- > kernel/pid.c | 17 +++++++++++++++++ > 3 files changed, 18 insertions(+), 17 deletions(-) > > diff --git a/include/linux/pid.h b/include/linux/pid.h > index 998ae7d24450..023d9c3a8edc 100644 > --- a/include/linux/pid.h > +++ b/include/linux/pid.h > @@ -75,6 +75,7 @@ extern const struct file_operations pidfd_fops; > struct file; > > extern struct pid *pidfd_pid(const struct file *file); > +extern struct pid *pidfd_get_pid(unsigned int fd); > > static inline struct pid *get_pid(struct pid *pid) > { > diff --git a/kernel/exit.c b/kernel/exit.c > index 0b81b26a872a..43375f9d8bbc 100644 > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -1470,23 +1470,6 @@ static long do_wait(struct wait_opts *wo) > return retval; > } > > -static struct pid *pidfd_get_pid(unsigned int fd) > -{ > - struct fd f; > - struct pid *pid; > - > - f = fdget(fd); > - if (!f.file) > - return ERR_PTR(-EBADF); > - > - pid = pidfd_pid(f.file); > - if (!IS_ERR(pid)) > - get_pid(pid); > - > - fdput(f); > - return pid; > -} > - > static long kernel_waitid(int which, pid_t upid, struct waitid_info *infop, > int options, struct rusage *ru) > { > diff --git a/kernel/pid.c b/kernel/pid.c > index 0f4ecb57214c..360ba480a2a9 100644 > --- a/kernel/pid.c > +++ b/kernel/pid.c > @@ -496,6 +496,23 @@ struct pid *find_ge_pid(int nr, struct pid_namespace *ns) > return idr_get_next(&ns->idr, &nr); > } > > +struct pid *pidfd_get_pid(unsigned int fd) > +{ > + struct fd f; > + struct pid *pid; > + > + f = fdget(fd); > + if (!f.file) > + return ERR_PTR(-EBADF); > + > + pid = pidfd_pid(f.file); > + if (!IS_ERR(pid)) > + get_pid(pid); > + > + fdput(f); > + return pid; > +} > + > /** > * pidfd_create() - Create a new pid file descriptor. > *