All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guillaume Tucker <guillaume.tucker@collabora.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Mark Brown <broonie@kernel.org>, Michael Walle <michael@walle.cc>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 0/4] ASoC: simple-card / audio-graph re-cleanup
Date: Mon, 10 May 2021 13:27:17 +0100	[thread overview]
Message-ID: <6bd59423-6467-3103-a596-3a85204158a6@collabora.com> (raw)
In-Reply-To: <87cztzcq56.wl-kuninori.morimoto.gx@renesas.com>

On 10/05/2021 02:51, Kuninori Morimoto wrote:
> 
> Hi Mark, Guillaume
> 
> KernelCI had reported that my previous cleanup patches for simple-card / audio-graph
> broke kontron-sl28-var3-ads2 sound card probing.

Could you please add this trailer, or maybe the maintainers can
add it when applying the patches?

  Reported-by: "kernelci.org bot" <bot@kernelci.org>

Thanks,
Guillaume

> It reported that it is using same name for dailink->name.
> 
> At first I thought that the issue was fsl,vf610-sai doesn't have .name on driver.
> But real issue was that cpu->dai_name removed on simple_parse_node(),
> and dailink->name was based on it.
> We need to set/get dailink->name first, and call simple_parse_node().
> This patches are do it.
> audio-graph has same issue. [4/4] patch is for it.
> 
> I hope these patches has no issues on kontron-sl28-var3-ads2.
> 
> Link: https://lore.kernel.org/r/87h7k0i437.wl-kuninori.morimoto.gx@renesas.com
> Link: https://lore.kernel.org/r/20210423175318.13990-1-broonie@kernel.org
> Link: https://lore.kernel.org/r/3ca62063-41b4-c25b-a7bc-8a8160e7b684@collabora.com
> 
> Kuninori Morimoto (4):
>   ASoC: simple-card: add simple_parse_node()
>   ASoC: simple-card: add simple_link_init()
>   ASoC: audio-graph: tidyup graph_dai_link_of_dpcm()
>   ASoC: audio-graph: tidyup dai_name seting timing
> 
>  sound/soc/generic/audio-graph-card.c |  48 +++----
>  sound/soc/generic/simple-card.c      | 187 ++++++++++++++-------------
>  2 files changed, 122 insertions(+), 113 deletions(-)
> 


  parent reply	other threads:[~2021-05-10 12:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10  1:51 [PATCH 0/4] ASoC: simple-card / audio-graph re-cleanup Kuninori Morimoto
2021-05-10  1:52 ` [PATCH 1/4] ASoC: simple-card: add simple_parse_node() Kuninori Morimoto
2021-05-10  1:52 ` [PATCH 2/4] ASoC: simple-card: add simple_link_init() Kuninori Morimoto
2021-05-10  1:52 ` [PATCH 3/4] ASoC: audio-graph: tidyup graph_dai_link_of_dpcm() Kuninori Morimoto
2021-05-10  1:52 ` [PATCH 4/4] ASoC: audio-graph: tidyup dai_name seting timing Kuninori Morimoto
2021-05-10 11:46 ` [PATCH 0/4] ASoC: simple-card / audio-graph re-cleanup Michael Walle
2021-05-10 12:27 ` Guillaume Tucker [this message]
2021-05-11 14:49   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bd59423-6467-3103-a596-3a85204158a6@collabora.com \
    --to=guillaume.tucker@collabora.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=michael@walle.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.