All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: <aniljoy@cadence.com>, <adouglas@cadence.com>, <nsekhar@ti.com>,
	<jsarha@ti.com>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 0/3] phy: cadence: j721e-wiz: Add Type-C plug flip support
Date: Mon, 6 Jan 2020 12:04:39 +0530	[thread overview]
Message-ID: <6be83e71-4205-bc86-f788-46c955bf9fe5@ti.com> (raw)
In-Reply-To: <d9f3af03-b9a6-d5b9-dce6-e573ceef7348@ti.com>

Roger,

On 09/12/19 3:19 PM, Roger Quadros wrote:
> Hi Kishon,
> 
> On 28/10/2019 12:21, Roger Quadros wrote:
>> Hi,
>>
>> On J721e platform, the 2 lanes of SERDES PHY are used to achieve
>> USB Type-C plug flip support without any additional MUX component
>> by using a lane swap feature.
>>
>> However, the driver needs to know the Type-C plug orientation before
>> it can decide whether to swap the lanes or not. This is achieved via a
>> GPIO named DIR.
>>
>> Another constraint is that the lane swap must happen only when the PHY
>> is in inactive state. This is achieved by sampling the GPIO and
>> programming the lane swap before bringing the PHY out of reset.
>>
>> This series adds support to read the GPIO and accordingly program
>> the Lane swap for Type-C plug flip support.
>>
>> Series must be applied on top of
>> https://lkml.org/lkml/2019/10/23/589
> 
> I just tested this on top of Sierra PHY patches v3
> https://lkml.org/lkml/2019/11/28/186
> on v5.5-rc1
> 
> USB3 works fine on J7ES.
> 
> Please queue this along with the Sierra PHY patches for -next. Thanks.

This series doesn't apply cleanly. Can you resend the series please
based on phy -next?

Thanks
Kishon
> 
> cheers,
> -roger
> 
>>
>> cheers,
>> -roger
>>
>> Changelog:
>> v4
>> - fixes in dt-binding document
>>    - fix typo
>>    - change to typec-dir-debounce-ms and add min/max/default values
>>    - drop reference to uint32 type
>> - fixes in driver
>>    - change to updated typec-dir-debounce-ms property
>>    - add limit checks and use default value if not specified
>>
>> v3
>> - Rebase on v2 of PHY series and update DT binding to yaml
>>
>> v2
>> - revise commit log of patch 1
>> - use regmap_field in patch 3
>>
>> Roger Quadros (3):
>>    phy: cadence: Sierra: add phy_reset hook
>>    dt-bindings: phy: ti,phy-j721e-wiz: Add Type-C dir GPIO
>>    phy: ti: j721e-wiz: Manage typec-gpio-dir
>>
>>   .../bindings/phy/ti,phy-j721e-wiz.yaml        | 17 ++++++
>>   drivers/phy/cadence/phy-cadence-sierra.c      | 10 +++
>>   drivers/phy/ti/phy-j721e-wiz.c                | 61 +++++++++++++++++++
>>   3 files changed, 88 insertions(+)
>>
> 

      reply	other threads:[~2020-01-06  6:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 10:21 [PATCH v4 0/3] phy: cadence: j721e-wiz: Add Type-C plug flip support Roger Quadros
2019-10-28 10:21 ` [PATCH v4 1/3] phy: cadence: Sierra: add phy_reset hook Roger Quadros
2019-10-28 10:21 ` [PATCH v4 2/3] dt-bindings: phy: ti,phy-j721e-wiz: Add Type-C dir GPIO Roger Quadros
2019-11-05  1:28   ` Rob Herring
2019-10-28 10:21 ` [PATCH v4 3/3] phy: ti: j721e-wiz: Manage typec-gpio-dir Roger Quadros
2019-12-09  9:49 ` [PATCH v4 0/3] phy: cadence: j721e-wiz: Add Type-C plug flip support Roger Quadros
2020-01-06  6:34   ` Kishon Vijay Abraham I [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6be83e71-4205-bc86-f788-46c955bf9fe5@ti.com \
    --to=kishon@ti.com \
    --cc=adouglas@cadence.com \
    --cc=aniljoy@cadence.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jsarha@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.