From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/2] stm32mp: replace printf by log macro in setup_boot_mode
Date: Thu, 8 Apr 2021 15:57:10 +0200 [thread overview]
Message-ID: <6bf125e7-a8bf-fb3b-0756-b55884c9439b@foss.st.com> (raw)
In-Reply-To: <20210406092731.2.I5436203a1417ef602cffce8d3e56f84c5f92c539@changeid>
Hi Patrick
On 4/6/21 9:27 AM, Patrick Delaunay wrote:
> Replace the remaining printf in setup_boot_mode() by log macro
> to handle filtering for log features.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>
> arch/arm/mach-stm32mp/cpu.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-stm32mp/cpu.c b/arch/arm/mach-stm32mp/cpu.c
> index 2f05c5e91b..621a6b7c89 100644
> --- a/arch/arm/mach-stm32mp/cpu.c
> +++ b/arch/arm/mach-stm32mp/cpu.c
> @@ -502,8 +502,8 @@ static void setup_boot_mode(void)
> if (IS_ENABLED(CONFIG_CMD_STM32PROG_SERIAL))
> gd->flags &= ~(GD_FLG_SILENT |
> GD_FLG_DISABLE_CONSOLE);
> - printf("uart%d = %s not found in device tree!\n",
> - instance + 1, cmd);
> + log_err("uart%d = %s not found in device tree!\n",
> + instance + 1, cmd);
> break;
> }
> sprintf(cmd, "%d", dev_seq(dev));
> @@ -514,7 +514,7 @@ static void setup_boot_mode(void)
> if (IS_ENABLED(CONFIG_CMD_STM32PROG_SERIAL) && gd->cur_serial_dev != dev) {
> gd->flags &= ~(GD_FLG_SILENT |
> GD_FLG_DISABLE_CONSOLE);
> - printf("serial boot with console enabled!\n");
> + log_info("serial boot with console enabled!\n");
> }
> break;
> case BOOT_SERIAL_USB:
> @@ -546,7 +546,7 @@ static void setup_boot_mode(void)
>
> switch (forced_mode) {
> case BOOT_FASTBOOT:
> - printf("Enter fastboot!\n");
> + log_info("Enter fastboot!\n");
> env_set("preboot", "env set preboot; fastboot 0");
> break;
> case BOOT_STM32PROG:
> @@ -556,7 +556,7 @@ static void setup_boot_mode(void)
> case BOOT_UMS_MMC0:
> case BOOT_UMS_MMC1:
> case BOOT_UMS_MMC2:
> - printf("Enter UMS!\n");
> + log_info("Enter UMS!\n");
> instance = forced_mode - BOOT_UMS_MMC0;
> sprintf(cmd, "env set preboot; ums 0 mmc %d", instance);
> env_set("preboot", cmd);
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
next prev parent reply other threads:[~2021-04-08 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 7:27 [PATCH 1/2] stm32mp: update uart number in trace of serial device not found Patrick Delaunay
2021-04-06 7:27 ` [PATCH 2/2] stm32mp: replace printf by log macro in setup_boot_mode Patrick Delaunay
2021-04-08 13:57 ` Patrice CHOTARD [this message]
2021-04-09 10:03 ` Patrice CHOTARD
2021-04-08 13:56 ` [PATCH 1/2] stm32mp: update uart number in trace of serial device not found Patrice CHOTARD
2021-04-09 10:03 ` Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf125e7-a8bf-fb3b-0756-b55884c9439b@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.