From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: luca.ceresoli@bootlin.com, Markus Volk <f_l_k@t-online.de>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [oe-core][PATCH] connman: add PACKAGECONFIG to support iwd
Date: Wed, 24 Aug 2022 14:09:52 +0200 [thread overview]
Message-ID: <6bf395b5-864f-4d2d-8fe9-fb05cbe3940e@theobroma-systems.com> (raw)
In-Reply-To: <20220824115108.6eee852c@booty>
Hi all,
On 8/24/22 11:51, Luca Ceresoli via lists.openembedded.org wrote:
> Hello Markus,
>
> On Wed, 24 Aug 2022 10:56:54 +0200
> "Markus Volk" <f_l_k@t-online.de> wrote:
>
>> Hello Luca,
>>
>> Am Mi, 24. Aug 2022 um 10:54:40 +0200 schrieb Luca Ceresoli
>> <luca.ceresoli@bootlin.com>:
>>> I would think iwd should be an rdepends, not an rrecommends. Any reson
>>> for that? Or is it just an unintended extra ','?
>>
>> Only reason for this was the fact, that iwd is not in oe-core so it
>> felt wrong somehow to set it RDEPEND
>
> I see, that's fine, but I wonder whether this should be clarified in a
> comment. I'll be taking the patch for testing as is anyway.
>
IIRC the policy is to have a default configuration working. It is fine
to have PACKAGECONFIG options with dependencies on recipes/packages not
in the same layer.
Here, if someone builds with NO_RECOMMENDATIONS to have a minimal setup
but have iwd as WIRELESS_DAEMON, connman won't work because the package
won't be added to the image, it'll be a bit harder to debug than a build
failing because iwd recipe could not be found (especially since I also
didn't notice the additional comma).
Cheers,
Quentin
next prev parent reply other threads:[~2022-08-24 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 16:38 [oe-core][PATCH] connman: add PACKAGECONFIG to support iwd Markus Volk
2022-08-24 8:54 ` Luca Ceresoli
2022-08-24 8:56 ` Markus Volk
2022-08-24 9:51 ` Luca Ceresoli
2022-08-24 12:09 ` Quentin Schulz [this message]
2022-08-24 12:52 ` Markus Volk
2022-08-25 12:13 ` Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf395b5-864f-4d2d-8fe9-fb05cbe3940e@theobroma-systems.com \
--to=quentin.schulz@theobroma-systems.com \
--cc=f_l_k@t-online.de \
--cc=luca.ceresoli@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.