From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v7 10/11] arm: vsmc: remove 64 bit mode check in PSCI handler Date: Fri, 6 Oct 2017 15:00:32 +0100 Message-ID: <6bf87d3b-4357-f8dc-ddc5-51e324d70eb3@arm.com> References: <1507150827-7858-1-git-send-email-volodymyr_babchuk@epam.com> <1507150827-7858-11-git-send-email-volodymyr_babchuk@epam.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1507150827-7858-11-git-send-email-volodymyr_babchuk@epam.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Volodymyr Babchuk , xen-devel@lists.xen.org, Stefano Stabellini Cc: "Edgar E . Iglesias" List-Id: xen-devel@lists.xenproject.org SGkgVm9sb2R5bXlyLAoKT24gMDQvMTAvMTcgMjI6MDAsIFZvbG9keW15ciBCYWJjaHVrIHdyb3Rl Ogo+IFBTQ0kgaGFuZGxpbmcgY29kZSBoYWQgaGVscGVyIHJvdXRpbmUgdGhhdCBjaGVja2VkIGNh bGxpbmcgY29udmVudGlvbi4KPiBJdCBkb2VzIG5vdCBuZWVkZWQgYW55bW9yZSwgYmVjYXVzZToK PiAKPiAgIC0gR2VuZXJpYyBoYW5kbGVyIGNoZWNrcyB0aGF0IDY0IGJpdCBjYWxscyBjYW4gYmUg bWFkZSBvbmx5IGJ5Cj4gICAgIDY0IGJpdCBndWVzdHMuCj4gCj4gICAtIFNNQ0NDIHJlcXVpcmVz IHRoYXQgNjQtYml0IGhhbmRsZXIgc2hvdWxkIHN1cHBvcnQgYm90aCAzMiBhbmQgNjQgYml0Cj4g ICAgIGNhbGxzIGV2ZW4gaWYgdGhleSBvcmlnaW5hdGUgZnJvbSA2NCBiaXQgY2FsbGVyLgo+IAo+ IFRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGF0IGV4dHJhIGNoZWNrLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IFZvbG9keW15ciBCYWJjaHVrIDx2b2xvZHlteXJfYmFiY2h1a0BlcGFtLmNvbT4KPiBSZXZpZXdl ZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgoKU29ycnkg SSBqdXN0IG5vdGljZWQgdGhpcy4gVGhpcyBpcyBvZGQgdG8ga2VlcCBhIHJldmlld2VkLWJ5IGZy b20gClN0ZWZhbm8gaW4gYSBwYXRjaCB0aGF0IGNoYW5nZWQgcXVpdGUgYSBiaXQgc2luY2UgaGUg Z2F2ZSBpdCAocGF0Y2ggIzIpLgoKVXN1YWxseSByZXZpZXdlZC1ieSBtZWFucyB0aGUgcGVyc29u IGhhcyByZXZpZXdlZCB0aGUgY29kZSBhbmQgaGFwcHkgCndpdGggaXQuIFRlY2huaWNhbGx5LCBo ZSBkaWRuJ3QgcmV2aWV3IHRoZSBuZXcgY2hhbmdlcyBhbmQgaWYgbm90IApkcm9wcGVkLCB5b3Ug c2hvdWxkIGhhdmUgYXQgbGVhc3QgYXNrZWQgd2hldGhlciBoZSBpcyBoYXBweSB3aXRoIGl0LgoK U3RlZmFubyBhcmUgeW91IGhhcHB5IGlmIFZvbG9keW15ciBrZWVwaW5nIHlvdXIgdGFnPwoKPiAt LS0KPiAgIHhlbi9hcmNoL2FybS92c21jLmMgfCA2MiArKysrKysrKysrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDI2IGluc2Vy dGlvbnMoKyksIDM2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v dnNtYy5jIGIveGVuL2FyY2gvYXJtL3ZzbWMuYwo+IGluZGV4IDc3ZmM5MTUuLmZmODQ0NDIgMTAw NjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJtL3ZzbWMuYwo+ICsrKyBiL3hlbi9hcmNoL2FybS92c21j LmMKPiBAQCAtMTM1LDEyICsxMzUsNiBAQCBzdGF0aWMgYm9vbCBoYW5kbGVfZXhpc3RpbmdfYXBp cyhzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncykKPiAgICAgICB9Cj4gICB9Cj4gICAKPiAtLyog aGVscGVyIGZ1bmN0aW9uIGZvciBjaGVja2luZyBhcm0gbW9kZSAzMi82NCBiaXQgKi8KPiAtc3Rh dGljIGlubGluZSBpbnQgcHNjaV9tb2RlX2NoZWNrKHN0cnVjdCBkb21haW4gKmQsIHVpbnQzMl90 IGZpZCkKPiAtewo+IC0gICAgcmV0dXJuIGlzXzY0Yml0X2RvbWFpbihkKSB8fCAhc21jY2NfaXNf Y29udl82NChmaWQpOwo+IC19Cj4gLQo+ICAgLyogUFNDSSAwLjIgaW50ZXJmYWNlIGFuZCBvdGhl ciBTdGFuZGFyZCBTZWN1cmUgQ2FsbHMgKi8KPiAgIHN0YXRpYyBib29sIGhhbmRsZV9zc3NjKHN0 cnVjdCBjcHVfdXNlcl9yZWdzICpyZWdzKQo+ICAgewo+IEBAIC0xNjUsOCArMTU5LDcgQEAgc3Rh dGljIGJvb2wgaGFuZGxlX3Nzc2Moc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpCj4gICAKPiAg ICAgICBjYXNlIFBTQ0lfMF8yX0ZOX01JR1JBVEVfSU5GT19VUF9DUFU6Cj4gICAgICAgICAgIHBl cmZjX2luY3IodnBzY2lfbWlncmF0ZV9pbmZvX3VwX2NwdSk7Cj4gLSAgICAgICAgaWYgKCBwc2Np X21vZGVfY2hlY2soY3VycmVudC0+ZG9tYWluLCBmaWQpICkKPiAtICAgICAgICAgICAgUFNDSV9T RVRfUkVTVUxUKHJlZ3MsIGRvX3BzY2lfMF8yX21pZ3JhdGVfaW5mb191cF9jcHUoKSk7Cj4gKyAg ICAgICAgUFNDSV9TRVRfUkVTVUxUKHJlZ3MsIGRvX3BzY2lfMF8yX21pZ3JhdGVfaW5mb191cF9j cHUoKSk7Cj4gICAgICAgICAgIHJldHVybiB0cnVlOwo+ICAgCj4gICAgICAgY2FzZSBQU0NJXzBf Ml9GTl9TWVNURU1fT0ZGOgo+IEBAIC0xODIsNDggKzE3NSw0NSBAQCBzdGF0aWMgYm9vbCBoYW5k bGVfc3NzYyhzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncykKPiAgICAgICAgICAgcmV0dXJuIHRy dWU7Cj4gICAKPiAgICAgICBjYXNlIFBTQ0lfMF8yX0ZOX0NQVV9PTjoKPiAtICAgICAgICBwZXJm Y19pbmNyKHZwc2NpX2NwdV9vbik7Cj4gLSAgICAgICAgaWYgKCBwc2NpX21vZGVfY2hlY2soY3Vy cmVudC0+ZG9tYWluLCBmaWQpICkKPiAtICAgICAgICB7Cj4gLSAgICAgICAgICAgIHJlZ2lzdGVy X3QgdmNwdWlkID0gUFNDSV9BUkcocmVncywgMSk7Cj4gLSAgICAgICAgICAgIHJlZ2lzdGVyX3Qg ZXBvaW50ID0gUFNDSV9BUkcocmVncywgMik7Cj4gLSAgICAgICAgICAgIHJlZ2lzdGVyX3QgY2lk ID0gUFNDSV9BUkcocmVncywgMyk7Cj4gKyAgICB7Cj4gKyAgICAgICAgcmVnaXN0ZXJfdCB2Y3B1 aWQgPSBQU0NJX0FSRyhyZWdzLCAxKTsKPiArICAgICAgICByZWdpc3Rlcl90IGVwb2ludCA9IFBT Q0lfQVJHKHJlZ3MsIDIpOwo+ICsgICAgICAgIHJlZ2lzdGVyX3QgY2lkID0gUFNDSV9BUkcocmVn cywgMyk7Cj4gICAKPiAtICAgICAgICAgICAgUFNDSV9TRVRfUkVTVUxUKHJlZ3MsIGRvX3BzY2lf MF8yX2NwdV9vbih2Y3B1aWQsIGVwb2ludCwgY2lkKSk7Cj4gLSAgICAgICAgfQo+ICsgICAgICAg IHBlcmZjX2luY3IodnBzY2lfY3B1X29uKTsKPiArICAgICAgICBQU0NJX1NFVF9SRVNVTFQocmVn cywgZG9fcHNjaV8wXzJfY3B1X29uKHZjcHVpZCwgZXBvaW50LCBjaWQpKTsKPiAgICAgICAgICAg cmV0dXJuIHRydWU7Cj4gKyAgICB9Cj4gICAKPiAgICAgICBjYXNlIFBTQ0lfMF8yX0ZOX0NQVV9T VVNQRU5EOgo+IC0gICAgICAgIHBlcmZjX2luY3IodnBzY2lfY3B1X3N1c3BlbmQpOwo+IC0gICAg ICAgIGlmICggcHNjaV9tb2RlX2NoZWNrKGN1cnJlbnQtPmRvbWFpbiwgZmlkKSApCj4gLSAgICAg ICAgewo+IC0gICAgICAgICAgICB1aW50MzJfdCBwc3RhdGUgPSBQU0NJX0FSRzMyKHJlZ3MsIDEp Owo+IC0gICAgICAgICAgICByZWdpc3Rlcl90IGVwb2ludCA9IFBTQ0lfQVJHKHJlZ3MsIDIpOwo+ IC0gICAgICAgICAgICByZWdpc3Rlcl90IGNpZCA9IFBTQ0lfQVJHKHJlZ3MsIDMpOwo+ICsgICAg ewo+ICsgICAgICAgIHVpbnQzMl90IHBzdGF0ZSA9IFBTQ0lfQVJHMzIocmVncywgMSk7Cj4gKyAg ICAgICAgcmVnaXN0ZXJfdCBlcG9pbnQgPSBQU0NJX0FSRyhyZWdzLCAyKTsKPiArICAgICAgICBy ZWdpc3Rlcl90IGNpZCA9IFBTQ0lfQVJHKHJlZ3MsIDMpOwo+ICAgCj4gLSAgICAgICAgICAgIFBT Q0lfU0VUX1JFU1VMVChyZWdzLCBkb19wc2NpXzBfMl9jcHVfc3VzcGVuZChwc3RhdGUsIGVwb2lu dCwgY2lkKSk7Cj4gLSAgICAgICAgfQo+ICsgICAgICAgIHBlcmZjX2luY3IodnBzY2lfY3B1X3N1 c3BlbmQpOwo+ICsgICAgICAgIFBTQ0lfU0VUX1JFU1VMVChyZWdzLCBkb19wc2NpXzBfMl9jcHVf c3VzcGVuZChwc3RhdGUsIGVwb2ludCwgY2lkKSk7Cj4gICAgICAgICAgIHJldHVybiB0cnVlOwo+ ICsgICAgfQo+ICAgCj4gICAgICAgY2FzZSBQU0NJXzBfMl9GTl9BRkZJTklUWV9JTkZPOgo+ICsg ICAgewo+ICsgICAgICAgIHJlZ2lzdGVyX3QgdGFmZiA9IFBTQ0lfQVJHKHJlZ3MsIDEpOwo+ICsg ICAgICAgIHVpbnQzMl90IGxhZmYgPSBQU0NJX0FSRzMyKHJlZ3MsIDIpOwo+ICsKPiAgICAgICAg ICAgcGVyZmNfaW5jcih2cHNjaV9jcHVfYWZmaW5pdHlfaW5mbyk7Cj4gLSAgICAgICAgaWYgKCBw c2NpX21vZGVfY2hlY2soY3VycmVudC0+ZG9tYWluLCBmaWQpICkKPiAtICAgICAgICB7Cj4gLSAg ICAgICAgICAgIHJlZ2lzdGVyX3QgdGFmZiA9IFBTQ0lfQVJHKHJlZ3MsIDEpOwo+IC0gICAgICAg ICAgICB1aW50MzJfdCBsYWZmID0gUFNDSV9BUkczMihyZWdzLCAyKTsKPiAtICAgICAgICAgICAg UFNDSV9TRVRfUkVTVUxUKHJlZ3MsIGRvX3BzY2lfMF8yX2FmZmluaXR5X2luZm8odGFmZiwgbGFm ZikpOwo+IC0gICAgICAgIH0KPiArICAgICAgICBQU0NJX1NFVF9SRVNVTFQocmVncywgZG9fcHNj aV8wXzJfYWZmaW5pdHlfaW5mbyh0YWZmLCBsYWZmKSk7Cj4gICAgICAgICAgIHJldHVybiB0cnVl Owo+ICsgICAgfQo+ICAgCj4gICAgICAgY2FzZSBQU0NJXzBfMl9GTl9NSUdSQVRFOgo+IC0gICAg ICAgIHBlcmZjX2luY3IodnBzY2lfY3B1X21pZ3JhdGUpOwo+IC0gICAgICAgIGlmICggcHNjaV9t b2RlX2NoZWNrKGN1cnJlbnQtPmRvbWFpbiwgZmlkKSApCj4gLSAgICAgICAgewo+IC0gICAgICAg ICAgICB1aW50MzJfdCB0Y3B1ID0gUFNDSV9BUkczMihyZWdzLCAxKTsKPiArICAgIHsKPiArICAg ICAgICB1aW50MzJfdCB0Y3B1ID0gUFNDSV9BUkczMihyZWdzLCAxKTsKPiAgIAo+IC0gICAgICAg ICAgICBQU0NJX1NFVF9SRVNVTFQocmVncywgZG9fcHNjaV8wXzJfbWlncmF0ZSh0Y3B1KSk7Cj4g LSAgICAgICAgfQo+ICsgICAgICAgIHBlcmZjX2luY3IodnBzY2lfY3B1X21pZ3JhdGUpOwo+ICsg ICAgICAgIFBTQ0lfU0VUX1JFU1VMVChyZWdzLCBkb19wc2NpXzBfMl9taWdyYXRlKHRjcHUpKTsK PiAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4gKyAgICB9Cj4gICAKPiAgICAgICBjYXNlIEFSTV9T TUNDQ19GVU5DX0NBTExfQ09VTlQ6Cj4gICAgICAgICAgIHJldHVybiBmaWxsX2Z1bmN0aW9uX2Nh bGxfY291bnQocmVncywgU1NTQ19TTUNDQ19GVU5DVElPTl9DT1VOVCk7Cj4gCgotLSAKSnVsaWVu IEdyYWxsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK