From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE92C77B6E for ; Fri, 14 Apr 2023 10:44:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230184AbjDNKo5 (ORCPT ); Fri, 14 Apr 2023 06:44:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbjDNKo4 (ORCPT ); Fri, 14 Apr 2023 06:44:56 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FCC61FD0 for ; Fri, 14 Apr 2023 03:44:55 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-50508810c8bso1678515a12.3 for ; Fri, 14 Apr 2023 03:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681469094; x=1684061094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=99/2Xzq1k3jGcxmT1pTlyb+0p5jdof1SmGadkZ956E8=; b=gjpb92BJlyi8AdRk2tXb6yIbRjNjmhPIjGoUt2NuU0q+EpYqyo3wONGmRD1PvavfsD 3EMTmNpcRpfwkCowxOmjE+xlw7lf9vxOMlVAldE5s1EDeZcUPR4udR2V5FXv/lVgTU/a OIKwB7dOGs+wSZw6Cv/dE8mXplb70MkLuDyhswOglpMEgRd9GkBuewhN+8oaW9urSnNk rKYjQlFyRam2rXBVRQZ6Hu1fxxH9VWK5AxxvWPXVeGNQ6evxRnM3DaWxY1slE9kzT2ir iyKN3Ql0FWU47U5IFa9tz4j3s9ROVKl37k+PnvumIYZONanbc84xGAnXCMu7sZw2fMv3 kpWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681469094; x=1684061094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=99/2Xzq1k3jGcxmT1pTlyb+0p5jdof1SmGadkZ956E8=; b=l5BqPevW5YfKdEzxxEInRuNoZyRmwIM83rmjGZCQD4w5uscaJfz4vZjPNvdltwy6Aj MvQhgg2sC89jCoiWzVmZn5eYwHcewbw1FoLV0cF6/IRycQgQUFH/gRd6ul7InYZt/F7F dkar/JXXj9/HeXudBIjlr30BHEPFkYl1ASRzVNAQOZvoM9qNGUXzKGI7c9hrTG2Lzg7L gND4Yw9mUj/YXCyBZ+MtyrXFvfNQgvIEJ9jq9/2MU3gEbYNiAwbsMI5hmMQXU+7I31fO h5GydgUwqT+DUUfdg3Zhk5wSG7viL/evZ8NFMiPW42WAW2+/i31sqgpIR7rwlDALxVSd y1xg== X-Gm-Message-State: AAQBX9c20alSS00Q4EIkcc9au8WOC6JCO9vsyi/ex7+7+j3LA3SnDY4N flyNPIKDk8AL98v68+UKtyfKYA== X-Google-Smtp-Source: AKy350YAZ4ObREDPTqX+3sDjKddkzxLRFtcc0tjO/9BvuuaM+s0ApmwT+Uw7xC7rJqvbc3fYPtVPzQ== X-Received: by 2002:aa7:c04f:0:b0:504:aae4:a034 with SMTP id k15-20020aa7c04f000000b00504aae4a034mr5907943edo.31.1681469094005; Fri, 14 Apr 2023 03:44:54 -0700 (PDT) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id o24-20020aa7c7d8000000b005067d089aafsm1003061eds.11.2023.04.14.03.44.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 03:44:53 -0700 (PDT) Message-ID: <6c01d2fc-3155-0dcd-f473-9cbd75dd69ec@linaro.org> Date: Fri, 14 Apr 2023 11:44:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 6/6] remoterproc: qcom: refactor to leverage exported minidump symbol Content-Language: en-US To: Mukesh Ojha , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, corbet@lwn.net, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org References: <1679491817-2498-1-git-send-email-quic_mojha@quicinc.com> <1679491817-2498-7-git-send-email-quic_mojha@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <1679491817-2498-7-git-send-email-quic_mojha@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 22/03/2023 13:30, Mukesh Ojha wrote: > qcom_minidump driver provides qcom_minidump_subsystem_desc() > exported API which other driver can use it query subsystem > descriptor. Refactor qcom_minidump() to use this symbol. > > Signed-off-by: Mukesh Ojha > --- > drivers/remoteproc/qcom_common.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c > index 88fc984..240e9f7 100644 > --- a/drivers/remoteproc/qcom_common.c > +++ b/drivers/remoteproc/qcom_common.c > @@ -94,19 +94,10 @@ void qcom_minidump(struct rproc *rproc, unsigned int minidump_id, > { > int ret; > struct minidump_subsystem *subsystem; > - struct minidump_global_toc *toc; > > - /* Get Global minidump ToC*/ > - toc = qcom_smem_get(QCOM_SMEM_HOST_ANY, SBL_MINIDUMP_SMEM_ID, NULL); > - > - /* check if global table pointer exists and init is set */ > - if (IS_ERR(toc) || !toc->status) { > - dev_err(&rproc->dev, "Minidump TOC not found in SMEM\n"); > + subsystem = qcom_minidump_subsystem_desc(minidump_id); > + if (IS_ERR(subsystem)) > return; Sorry If I am missing something but I got lost looking at the below code snippet in drivers/remoteproc/qcom_common.c -------------------->cut<----------------------------- subsystem = qcom_minidump_subsystem_desc(minidump_id); if (IS_ERR(subsystem)) return; /** * Collect minidump if SS ToC is valid and segment table * is initialized in memory and encryption status is set. */ if (subsystem->regions_baseptr == 0 || le32_to_cpu(subsystem->status) != 1 || le32_to_cpu(subsystem->enabled) != MINIDUMP_SS_ENABLED || le32_to_cpu(subsystem->encryption_status) != MINIDUMP_SS_ENCR_DONE) { dev_err(&rproc->dev, "Minidump not ready, skipping\n"); return; } -------------------->cut<----------------------------- where does "subsystem->regions_baseptr" for this ADSP minidump descriptor get set? --srini > - } > - > - /* Get subsystem table of contents using the minidump id */ > - subsystem = &toc->subsystems[minidump_id]; > > /** > * Collect minidump if SS ToC is valid and segment table From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30E99C77B6F for ; Fri, 14 Apr 2023 10:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Id9Mjb7OHpOQ1lStVmHMmXeUjrv6MMztBs0a8blHN84=; b=2D0LgHdv86xKxE 3r6BV23o5ntNXufg/CQMGkj7bjBpzLUyNk61sxCg9/Vuc+zlt2nFDpCMYqD4mn5X1Wrttv3VgKiAD dz/I4zUP8wOwr566jVgFMZbXxbI0wkDsFPVD6FqvegaPFvwduSSdNFfPfauCJBQsfmDlUgdoBrVXO YYaPq9weC0Jv7hys2ysV85kGYcWPREk9xMVb9/pk47x1FeqPXeenFYygexT3R6a/fcCghdoVPeL+f 3MwMTRgJtFfREGwDR/nTYBBgGKboCQ+Kx4EC6pae/OlVrPsARi+vE5LDHNa3TWVL6ozKb5m9ZdbWu fMoTxZ/Q3jOQBr+Yex1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnGvK-009DSJ-2O; Fri, 14 Apr 2023 10:44:58 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnGvH-009DRH-2d for linux-arm-kernel@lists.infradead.org; Fri, 14 Apr 2023 10:44:57 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-504fce3d7fbso1931174a12.2 for ; Fri, 14 Apr 2023 03:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681469094; x=1684061094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=99/2Xzq1k3jGcxmT1pTlyb+0p5jdof1SmGadkZ956E8=; b=gjpb92BJlyi8AdRk2tXb6yIbRjNjmhPIjGoUt2NuU0q+EpYqyo3wONGmRD1PvavfsD 3EMTmNpcRpfwkCowxOmjE+xlw7lf9vxOMlVAldE5s1EDeZcUPR4udR2V5FXv/lVgTU/a OIKwB7dOGs+wSZw6Cv/dE8mXplb70MkLuDyhswOglpMEgRd9GkBuewhN+8oaW9urSnNk rKYjQlFyRam2rXBVRQZ6Hu1fxxH9VWK5AxxvWPXVeGNQ6evxRnM3DaWxY1slE9kzT2ir iyKN3Ql0FWU47U5IFa9tz4j3s9ROVKl37k+PnvumIYZONanbc84xGAnXCMu7sZw2fMv3 kpWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681469094; x=1684061094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=99/2Xzq1k3jGcxmT1pTlyb+0p5jdof1SmGadkZ956E8=; b=jreT4B585rTc3+OHr+6rcdwkRTY3frzvGuamkTtSnrW4ClWcBXSylWYWsoqEaD07sf MOiBVpzB5VzrN3Qp1I++DV2CJNQOsHZ46sCYHtFiPhlwC8svAC/q7SPv3TLAn97cuUNz ttBfHWdyjdU++BFG/zckLIT9T7Jzgmg6B11z/KMz9tnBo5KR6AGvMv0nKwMS3gFRGkWF Efp6hK3Iw5SaBAEOeXqRE9d3IvH3uC+aspbyNq0pdDpIiCMojZuLsSTAnvKsEjCNiwJr 0treCEOwH6hneo6/foXfp9hDiQUZw+npIOpDioFZ8/e8jxymEOpHP5awBe/2gZkjZrdN j+fg== X-Gm-Message-State: AAQBX9eNyCdjZ2dQALE2Qe9kVY4x0bcH5O9b8HHIZsKjiZAEOlaVmOYK Rb1ass7WGqQITiw0EtlYcgtC7w== X-Google-Smtp-Source: AKy350YAZ4ObREDPTqX+3sDjKddkzxLRFtcc0tjO/9BvuuaM+s0ApmwT+Uw7xC7rJqvbc3fYPtVPzQ== X-Received: by 2002:aa7:c04f:0:b0:504:aae4:a034 with SMTP id k15-20020aa7c04f000000b00504aae4a034mr5907943edo.31.1681469094005; Fri, 14 Apr 2023 03:44:54 -0700 (PDT) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id o24-20020aa7c7d8000000b005067d089aafsm1003061eds.11.2023.04.14.03.44.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 03:44:53 -0700 (PDT) Message-ID: <6c01d2fc-3155-0dcd-f473-9cbd75dd69ec@linaro.org> Date: Fri, 14 Apr 2023 11:44:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 6/6] remoterproc: qcom: refactor to leverage exported minidump symbol Content-Language: en-US To: Mukesh Ojha , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, corbet@lwn.net, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org References: <1679491817-2498-1-git-send-email-quic_mojha@quicinc.com> <1679491817-2498-7-git-send-email-quic_mojha@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <1679491817-2498-7-git-send-email-quic_mojha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_034455_868191_04B3B08A X-CRM114-Status: GOOD ( 19.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/03/2023 13:30, Mukesh Ojha wrote: > qcom_minidump driver provides qcom_minidump_subsystem_desc() > exported API which other driver can use it query subsystem > descriptor. Refactor qcom_minidump() to use this symbol. > > Signed-off-by: Mukesh Ojha > --- > drivers/remoteproc/qcom_common.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c > index 88fc984..240e9f7 100644 > --- a/drivers/remoteproc/qcom_common.c > +++ b/drivers/remoteproc/qcom_common.c > @@ -94,19 +94,10 @@ void qcom_minidump(struct rproc *rproc, unsigned int minidump_id, > { > int ret; > struct minidump_subsystem *subsystem; > - struct minidump_global_toc *toc; > > - /* Get Global minidump ToC*/ > - toc = qcom_smem_get(QCOM_SMEM_HOST_ANY, SBL_MINIDUMP_SMEM_ID, NULL); > - > - /* check if global table pointer exists and init is set */ > - if (IS_ERR(toc) || !toc->status) { > - dev_err(&rproc->dev, "Minidump TOC not found in SMEM\n"); > + subsystem = qcom_minidump_subsystem_desc(minidump_id); > + if (IS_ERR(subsystem)) > return; Sorry If I am missing something but I got lost looking at the below code snippet in drivers/remoteproc/qcom_common.c -------------------->cut<----------------------------- subsystem = qcom_minidump_subsystem_desc(minidump_id); if (IS_ERR(subsystem)) return; /** * Collect minidump if SS ToC is valid and segment table * is initialized in memory and encryption status is set. */ if (subsystem->regions_baseptr == 0 || le32_to_cpu(subsystem->status) != 1 || le32_to_cpu(subsystem->enabled) != MINIDUMP_SS_ENABLED || le32_to_cpu(subsystem->encryption_status) != MINIDUMP_SS_ENCR_DONE) { dev_err(&rproc->dev, "Minidump not ready, skipping\n"); return; } -------------------->cut<----------------------------- where does "subsystem->regions_baseptr" for this ADSP minidump descriptor get set? --srini > - } > - > - /* Get subsystem table of contents using the minidump id */ > - subsystem = &toc->subsystems[minidump_id]; > > /** > * Collect minidump if SS ToC is valid and segment table _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel