From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251ECC433EF for ; Fri, 10 Jun 2022 16:35:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242904AbiFJQfw (ORCPT ); Fri, 10 Jun 2022 12:35:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349626AbiFJQfX (ORCPT ); Fri, 10 Jun 2022 12:35:23 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42BAF5A097; Fri, 10 Jun 2022 09:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=ITFCmOiKiwpLnIkUYUaZ9ApXZjSQdaUdOkg4dD/FPoE=; b=XZqQoZt7QcwLeMSIihkqhnAt9G GiVWhkFdiE7GA2h30pWh3vgPBwMLASudYSHFvXPNPZu5zVFZwhrlsrBWFvDfWCxxMcomWTsJosjtk 9gkUreI59XCiOnj5yiTBI93J1XiJOIIrprKkYbwM/s5csJ7thxbHy0qd0PRwEoJZk8qvx7AB+2zNi TJwD5KbqbhGwwQlfdszLogNbMHxsuvppgtA6GKuziEvStSgVV46cFunt9K1alwlY+4D/1sSlyKkt7 9th/UPsNweljWDuF6rKL9hxWvjGDo8QijSUl44yscs6OfxXIuQ35rWsz5dIUQ7/ds9mrqBdrltNRh UJvCGztw==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzhb3-00EaOY-VD; Fri, 10 Jun 2022 16:34:54 +0000 Message-ID: <6c02f8ef-8aea-8f80-590d-343f67a96f8d@infradead.org> Date: Fri, 10 Jun 2022 09:34:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 19/23] ata: ahci: Add DWC AHCI SATA controller support Content-Language: en-US To: Serge Semin , Damien Le Moal , Hans de Goede , Jens Axboe , Hannes Reinecke , Serge Semin Cc: Alexey Malahov , Pavel Parkhomenko , Rob Herring , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220610081801.11854-1-Sergey.Semin@baikalelectronics.ru> <20220610081801.11854-20-Sergey.Semin@baikalelectronics.ru> From: Randy Dunlap In-Reply-To: <20220610081801.11854-20-Sergey.Semin@baikalelectronics.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hi-- On 6/10/22 01:17, Serge Semin wrote: > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index bb45a9c00514..95e0e022b5bb 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -176,6 +176,16 @@ config AHCI_DM816 > > If unsure, say N. > > +config AHCI_DWC > + tristate "Synopsys DWC AHCI SATA support" > + select SATA_HOST > + default SATA_AHCI_PLATFORM I don't think this needs to default to SATA_AHCI_PLATFORM. It might build a driver that isn't needed. And it's incompatible with "If unsure, say N." > + help > + This option enables support for the Synopsys DWC AHCI SATA > + controller implementation. > + > + If unsure, say N. -- ~Randy