From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752121AbdBIIyc (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Feb 2017 03:54:32 -0500
Received: from mail-wr0-f194.google.com ([209.85.128.194]:34210 "EHLO
        mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751895AbdBIIxl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Feb 2017 03:53:41 -0500
Subject: Re: [PATCH -next] mtd: aspeed: remove redundant dev_err call in
 aspeed_smc_probe()
To: Wei Yongjun <weiyj.lk@gmail.com>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Richard Weinberger <richard@nod.at>
References: <20170208162310.6048-1-weiyj.lk@gmail.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
From: Marek Vasut <marek.vasut@gmail.com>
Message-ID: <6c10cdf0-5b91-000c-a8c3-78f41d47bac3@gmail.com>
Date: Thu, 9 Feb 2017 09:50:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170208162310.6048-1-weiyj.lk@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/08/2017 05:23 PM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Reviewed-by: Marek Vasut <marek.vasut@gmail.com>

> ---
>  drivers/mtd/spi-nor/aspeed-smc.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
> index 7c86099..56051d3 100644
> --- a/drivers/mtd/spi-nor/aspeed-smc.c
> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
> @@ -723,17 +723,13 @@ static int aspeed_smc_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	controller->regs = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(controller->regs)) {
> -		dev_err(dev, "Cannot remap controller address.\n");
> +	if (IS_ERR(controller->regs))
>  		return PTR_ERR(controller->regs);
> -	}
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>  	controller->ahb_base = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(controller->ahb_base)) {
> -		dev_err(dev, "Cannot remap controller address.\n");
> +	if (IS_ERR(controller->ahb_base))
>  		return PTR_ERR(controller->ahb_base);
> -	}
>  
>  	ret = aspeed_smc_setup_flash(controller, np, res);
>  	if (ret)
> 
> 
> 


-- 
Best regards,
Marek Vasut