From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D52EC10F11 for ; Wed, 24 Apr 2019 14:52:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BC0B218FC for ; Wed, 24 Apr 2019 14:52:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="jwhQig4b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733001AbfDXOwp (ORCPT ); Wed, 24 Apr 2019 10:52:45 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:54886 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732972AbfDXOwc (ORCPT ); Wed, 24 Apr 2019 10:52:32 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3OEpfHp014817; Wed, 24 Apr 2019 16:52:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=bgQxOGyNh/KQn11Y3ySkJgKTQZZg3JBZGVmCcVIASZk=; b=jwhQig4bD+sHIea4YALQAROAOm8Ohu/gKfaUjBzxrieTy4ucqDYODHgSfxIHsUi1nKsY bntViK1oRIz/7bpw3Sy7cV3lwH1u7e7SkFbR/87zlTEDAZSp4GgBAH9QfYaMRfBM+Uou 9OnucmFQOgaDDpx1vvBVV2yvZO6FoZDoydizBqulj/W3H5c5mgEHl4Z1kp30rs94jdJr nI5kLbJq/UactpbAaCDodvGmUh5Qz1Jtb+vtXAqKG2lzWIjhPRWA3tIS0myf1pjEptns VP2woRq++rqZjA595kWOInFbPSH34WsIJNh949l9rSsHmST8QGNEjOlXakrd0FwTzcpP 5w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2rytad7878-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Apr 2019 16:52:16 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1C18F31; Wed, 24 Apr 2019 14:52:16 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node1.st.com [10.75.127.13]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id EFDFD2881; Wed, 24 Apr 2019 14:52:15 +0000 (GMT) Received: from SFHDAG3NODE2.st.com (10.75.127.8) by SFHDAG5NODE1.st.com (10.75.127.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 24 Apr 2019 16:52:15 +0200 Received: from SFHDAG3NODE2.st.com ([fe80::b82f:1ce:8854:5b96]) by SFHDAG3NODE2.st.com ([fe80::b82f:1ce:8854:5b96%20]) with mapi id 15.00.1347.000; Wed, 24 Apr 2019 16:52:16 +0200 From: Amelie DELAUNAY To: Fabien DESSENNE , Mark Brown , Maxime Coquelin , Alexandre TORGUE , "linux-spi@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] spi: stm32: return the get_irq error Thread-Topic: [PATCH] spi: stm32: return the get_irq error Thread-Index: AQHU+pqvA0yJgg8S5EmBKq89hP7HV6ZLQ+CA Date: Wed, 24 Apr 2019 14:52:16 +0000 Message-ID: <6c11793b-bcfc-e069-56db-7e963d22dc6e@st.com> References: <1556109524-21874-1-git-send-email-fabien.dessenne@st.com> In-Reply-To: <1556109524-21874-1-git-send-email-fabien.dessenne@st.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.46] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-24_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gNC8yNC8xOSAyOjM4IFBNLCBGYWJpZW4gRGVzc2VubmUgd3JvdGU6DQo+IER1cmluZyBwcm9i ZSwgcmV0dXJuIHRoZSAiZ2V0X2lycSIgZXJyb3IgdmFsdWUgaW5zdGVhZCBvZiAtRU5PRU5ULiBU aGlzDQo+IGFsbG93cyB0aGUgZHJpdmVyIHRvIGJlIGRlZmVyIHByb2JlZCBpZiBuZWVkZWQuDQo+ IA0KPiBTaWduZWQtb2ZmLWJ5OiBGYWJpZW4gRGVzc2VubmUgPGZhYmllbi5kZXNzZW5uZUBzdC5j b20+DQoNCkFja2VkLWJ5OiBBbWVsaWUgRGVsYXVuYXkgPGFtZWxpZS5kZWxhdW5heUBzdC5jb20+ DQoNCj4gLS0tDQo+ICAgZHJpdmVycy9zcGkvc3BpLXN0bTMyLmMgfCA1ICsrKy0tDQo+ICAgMSBm aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3NwaS9zcGktc3RtMzIuYyBiL2RyaXZlcnMvc3BpL3NwaS1zdG0zMi5j DQo+IGluZGV4IDQxODZlZDIuLmIyMjJjZTggMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvc3BpL3Nw aS1zdG0zMi5jDQo+ICsrKyBiL2RyaXZlcnMvc3BpL3NwaS1zdG0zMi5jDQo+IEBAIC0xODM5LDgg KzE4MzksOSBAQCBzdGF0aWMgaW50IHN0bTMyX3NwaV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQ0KPiAgIA0KPiAgIAlzcGktPmlycSA9IHBsYXRmb3JtX2dldF9pcnEocGRldiwg MCk7DQo+ICAgCWlmIChzcGktPmlycSA8PSAwKSB7DQo+IC0JCWRldl9lcnIoJnBkZXYtPmRldiwg Im5vIGlycTogJWRcbiIsIHNwaS0+aXJxKTsNCj4gLQkJcmV0ID0gLUVOT0VOVDsNCj4gKwkJcmV0 ID0gc3BpLT5pcnE7DQo+ICsJCWlmIChyZXQgIT0gLUVQUk9CRV9ERUZFUikNCj4gKwkJCWRldl9l cnIoJnBkZXYtPmRldiwgImZhaWxlZCB0byBnZXQgaXJxOiAlZFxuIiwgcmV0KTsNCj4gICAJCWdv dG8gZXJyX21hc3Rlcl9wdXQ7DQo+ICAgCX0NCj4gICAJcmV0ID0gZGV2bV9yZXF1ZXN0X3RocmVh ZGVkX2lycSgmcGRldi0+ZGV2LCBzcGktPmlycSwNCj4g From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amelie DELAUNAY Subject: Re: [PATCH] spi: stm32: return the get_irq error Date: Wed, 24 Apr 2019 14:52:16 +0000 Message-ID: <6c11793b-bcfc-e069-56db-7e963d22dc6e@st.com> References: <1556109524-21874-1-git-send-email-fabien.dessenne@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Fabien DESSENNE , Mark Brown , Maxime Coquelin , Alexandre TORGUE , "linux-spi@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Return-path: In-Reply-To: <1556109524-21874-1-git-send-email-fabien.dessenne@st.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On 4/24/19 2:38 PM, Fabien Dessenne wrote: > During probe, return the "get_irq" error value instead of -ENOENT. This > allows the driver to be defer probed if needed. > > Signed-off-by: Fabien Dessenne Acked-by: Amelie Delaunay > --- > drivers/spi/spi-stm32.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c > index 4186ed2..b222ce8 100644 > --- a/drivers/spi/spi-stm32.c > +++ b/drivers/spi/spi-stm32.c > @@ -1839,8 +1839,9 @@ static int stm32_spi_probe(struct platform_device *pdev) > > spi->irq = platform_get_irq(pdev, 0); > if (spi->irq <= 0) { > - dev_err(&pdev->dev, "no irq: %d\n", spi->irq); > - ret = -ENOENT; > + ret = spi->irq; > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "failed to get irq: %d\n", ret); > goto err_master_put; > } > ret = devm_request_threaded_irq(&pdev->dev, spi->irq, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C09C282CE for ; Wed, 24 Apr 2019 14:52:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4B4C218FC for ; Wed, 24 Apr 2019 14:52:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GEmAxzMq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="jwhQig4b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4B4C218FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Zl7MkuCZsJzXDmkax3ZN3dd8VBImQrhLPAC0c47v1M=; b=GEmAxzMq7L0evK RezrqqKhWllBkqK61VjJOq+IdZFaZTT3UtDJvwBEsEC7oP73qIhLNT6Hm9oIbPWf3KbH8ijD0CFNo 9F7HdhJJXV6WLQxx0L8E/AoNnD1slfEx0gtTBtKEIkuM+HVi6iCbvSaRwltdXX5IIroLAOoE50/tD NXz6Fihb2BEzd5zjY/HSxE+GfEadyQDH4k1u9/oDv3YJdIkapvOVYEuNtRejCiW04sioCc7/eFyB7 crfHwG3SlkUdExHT21lB5rKkzRfAq+g7ARhtpt2p0JnpBCfsKgBZ8OVVHKOcWzdEag/5vbTPk7zyq VfCvvqzpt8zcU893NZpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJJGA-0001qD-Tp; Wed, 24 Apr 2019 14:52:30 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJJG1-0001dM-LR for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2019 14:52:29 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3OEpfHp014817; Wed, 24 Apr 2019 16:52:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=bgQxOGyNh/KQn11Y3ySkJgKTQZZg3JBZGVmCcVIASZk=; b=jwhQig4bD+sHIea4YALQAROAOm8Ohu/gKfaUjBzxrieTy4ucqDYODHgSfxIHsUi1nKsY bntViK1oRIz/7bpw3Sy7cV3lwH1u7e7SkFbR/87zlTEDAZSp4GgBAH9QfYaMRfBM+Uou 9OnucmFQOgaDDpx1vvBVV2yvZO6FoZDoydizBqulj/W3H5c5mgEHl4Z1kp30rs94jdJr nI5kLbJq/UactpbAaCDodvGmUh5Qz1Jtb+vtXAqKG2lzWIjhPRWA3tIS0myf1pjEptns VP2woRq++rqZjA595kWOInFbPSH34WsIJNh949l9rSsHmST8QGNEjOlXakrd0FwTzcpP 5w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2rytad7878-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Apr 2019 16:52:16 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1C18F31; Wed, 24 Apr 2019 14:52:16 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node1.st.com [10.75.127.13]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id EFDFD2881; Wed, 24 Apr 2019 14:52:15 +0000 (GMT) Received: from SFHDAG3NODE2.st.com (10.75.127.8) by SFHDAG5NODE1.st.com (10.75.127.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 24 Apr 2019 16:52:15 +0200 Received: from SFHDAG3NODE2.st.com ([fe80::b82f:1ce:8854:5b96]) by SFHDAG3NODE2.st.com ([fe80::b82f:1ce:8854:5b96%20]) with mapi id 15.00.1347.000; Wed, 24 Apr 2019 16:52:16 +0200 From: Amelie DELAUNAY To: Fabien DESSENNE , Mark Brown , Maxime Coquelin , Alexandre TORGUE , "linux-spi@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] spi: stm32: return the get_irq error Thread-Topic: [PATCH] spi: stm32: return the get_irq error Thread-Index: AQHU+pqvA0yJgg8S5EmBKq89hP7HV6ZLQ+CA Date: Wed, 24 Apr 2019 14:52:16 +0000 Message-ID: <6c11793b-bcfc-e069-56db-7e963d22dc6e@st.com> References: <1556109524-21874-1-git-send-email-fabien.dessenne@st.com> In-Reply-To: <1556109524-21874-1-git-send-email-fabien.dessenne@st.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.46] Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-24_09:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190424_075222_744766_B76B1B8B X-CRM114-Status: GOOD ( 18.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/24/19 2:38 PM, Fabien Dessenne wrote: > During probe, return the "get_irq" error value instead of -ENOENT. This > allows the driver to be defer probed if needed. > > Signed-off-by: Fabien Dessenne Acked-by: Amelie Delaunay > --- > drivers/spi/spi-stm32.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c > index 4186ed2..b222ce8 100644 > --- a/drivers/spi/spi-stm32.c > +++ b/drivers/spi/spi-stm32.c > @@ -1839,8 +1839,9 @@ static int stm32_spi_probe(struct platform_device *pdev) > > spi->irq = platform_get_irq(pdev, 0); > if (spi->irq <= 0) { > - dev_err(&pdev->dev, "no irq: %d\n", spi->irq); > - ret = -ENOENT; > + ret = spi->irq; > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "failed to get irq: %d\n", ret); > goto err_master_put; > } > ret = devm_request_threaded_irq(&pdev->dev, spi->irq, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel