From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2622C433F5 for ; Fri, 6 May 2022 16:42:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443858AbiEFQpr (ORCPT ); Fri, 6 May 2022 12:45:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443847AbiEFQpp (ORCPT ); Fri, 6 May 2022 12:45:45 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 53E3560DE for ; Fri, 6 May 2022 09:42:02 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 16FB3113E; Fri, 6 May 2022 09:42:02 -0700 (PDT) Received: from [10.57.80.111] (unknown [10.57.80.111]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7028A3F85F; Fri, 6 May 2022 09:42:00 -0700 (PDT) Message-ID: <6c148e83-3244-d47a-37e3-1a1f01fe35bc@arm.com> Date: Fri, 6 May 2022 17:41:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] clocksource/drivers/sp804: avoid error on multiple instances Content-Language: en-GB To: Andre Przywara , Daniel Lezcano , Thomas Gleixner Cc: Russell King , Kefeng Wang , Zhen Lei , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220506162522.3675399-1-andre.przywara@arm.com> From: Robin Murphy In-Reply-To: <20220506162522.3675399-1-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-05-06 17:25, Andre Przywara wrote: > When a machine sports more than one SP804 timer instance, we only bring > up the first one, since multiple timers of the same kind are not useful > to Linux. As this is intentional behaviour, we should not return an > error message, as we do today: > =============== > [ 0.000800] Failed to initialize '/bus@8000000/motherboard-bus@8000000/iofpga-bus@300000000/timer@120000': -22 > =============== > > Replace the -EINVAL return with a debug message and return 0 instead. > > Also we do not reach the init function anymore if the DT node is > disabled (as this is now handled by OF_DECLARE), so remove the explicit > check for that case. > > This fixes a long standing bogus error when booting ARM's fastmodels. Reviewed-by: Robin Murphy > Signed-off-by: Andre Przywara > --- > Changelog v1 .. v2: > - demote pr_info() to pr_debug(), to avoid output at all > - use %pOF and reword message > > drivers/clocksource/timer-sp804.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c > index 401d592e85f5a..e6a87f4af2b50 100644 > --- a/drivers/clocksource/timer-sp804.c > +++ b/drivers/clocksource/timer-sp804.c > @@ -259,6 +259,11 @@ static int __init sp804_of_init(struct device_node *np, struct sp804_timer *time > struct clk *clk1, *clk2; > const char *name = of_get_property(np, "compatible", NULL); > > + if (initialized) { > + pr_debug("%pOF: skipping further SP804 timer device\n", np); > + return 0; > + } > + > base = of_iomap(np, 0); > if (!base) > return -ENXIO; > @@ -270,11 +275,6 @@ static int __init sp804_of_init(struct device_node *np, struct sp804_timer *time > writel(0, timer1_base + timer->ctrl); > writel(0, timer2_base + timer->ctrl); > > - if (initialized || !of_device_is_available(np)) { > - ret = -EINVAL; > - goto err; > - } > - > clk1 = of_clk_get(np, 0); > if (IS_ERR(clk1)) > clk1 = NULL; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47B52C433EF for ; Fri, 6 May 2022 16:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BOtSoogCrjbc3PlGYSf7bf2uR4tKAyJ5VRekZqL+v3Q=; b=DnYFblWFC4dtBN WsfXvJu3NUg0ykg4vKJhowzAHocgCxJpb/Cij0rscahmt12hRYUfDsGABeiPFqUGGJcSzTpWzfFJx MKP9F4ViZEMOFDM2y0YE76c69HDcRrCLP8d6Y/fOo76VuwJlNkiKaUqkeJyRSTOUMH9WmqeF0yQHO 7kaqPon0m0WXDUYMP5xVsWtv8nwvYdGsZe8BjDiMjLgaF+ByKIeL64tfQ7RyA7f9OmjixZHw4kt4R +DLQH/5yQdYF38cc93x+o7NTj0Qu8XVS8cJ2WbJRmN1V2PydT8vKThVRhf7rIe/L275PXi2b5q/jz hbXDqbYbEBpDLJfStMUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nn11s-004QiT-Fa; Fri, 06 May 2022 16:42:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nn11p-004Qhp-BT for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 16:42:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 16FB3113E; Fri, 6 May 2022 09:42:02 -0700 (PDT) Received: from [10.57.80.111] (unknown [10.57.80.111]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7028A3F85F; Fri, 6 May 2022 09:42:00 -0700 (PDT) Message-ID: <6c148e83-3244-d47a-37e3-1a1f01fe35bc@arm.com> Date: Fri, 6 May 2022 17:41:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] clocksource/drivers/sp804: avoid error on multiple instances Content-Language: en-GB To: Andre Przywara , Daniel Lezcano , Thomas Gleixner Cc: Russell King , Kefeng Wang , Zhen Lei , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220506162522.3675399-1-andre.przywara@arm.com> From: Robin Murphy In-Reply-To: <20220506162522.3675399-1-andre.przywara@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_094205_490335_9C0FB85A X-CRM114-Status: GOOD ( 25.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-05-06 17:25, Andre Przywara wrote: > When a machine sports more than one SP804 timer instance, we only bring > up the first one, since multiple timers of the same kind are not useful > to Linux. As this is intentional behaviour, we should not return an > error message, as we do today: > =============== > [ 0.000800] Failed to initialize '/bus@8000000/motherboard-bus@8000000/iofpga-bus@300000000/timer@120000': -22 > =============== > > Replace the -EINVAL return with a debug message and return 0 instead. > > Also we do not reach the init function anymore if the DT node is > disabled (as this is now handled by OF_DECLARE), so remove the explicit > check for that case. > > This fixes a long standing bogus error when booting ARM's fastmodels. Reviewed-by: Robin Murphy > Signed-off-by: Andre Przywara > --- > Changelog v1 .. v2: > - demote pr_info() to pr_debug(), to avoid output at all > - use %pOF and reword message > > drivers/clocksource/timer-sp804.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c > index 401d592e85f5a..e6a87f4af2b50 100644 > --- a/drivers/clocksource/timer-sp804.c > +++ b/drivers/clocksource/timer-sp804.c > @@ -259,6 +259,11 @@ static int __init sp804_of_init(struct device_node *np, struct sp804_timer *time > struct clk *clk1, *clk2; > const char *name = of_get_property(np, "compatible", NULL); > > + if (initialized) { > + pr_debug("%pOF: skipping further SP804 timer device\n", np); > + return 0; > + } > + > base = of_iomap(np, 0); > if (!base) > return -ENXIO; > @@ -270,11 +275,6 @@ static int __init sp804_of_init(struct device_node *np, struct sp804_timer *time > writel(0, timer1_base + timer->ctrl); > writel(0, timer2_base + timer->ctrl); > > - if (initialized || !of_device_is_available(np)) { > - ret = -EINVAL; > - goto err; > - } > - > clk1 = of_clk_get(np, 0); > if (IS_ERR(clk1)) > clk1 = NULL; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel