Re: [PATCH] SUPPORT.md: Mark Renesas IPMMU-VMSA (Arm) as supported

[Julien Grall <julien@xen.org>]

Hi Oleksandr,

On 14/09/2020 20:37, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> And remove dependencies on CONFIG_EXPERT.

In order to help to make the decision, can you provide the following 
information:
    - Is it functionally complete?
    - Can it work on all known platforms with IPMMU VMSA?
    - Is there any plan to smoke (manually or automatically) test the 
driver?

> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>   SUPPORT.md                      | 2 +-
>   xen/arch/arm/platforms/Kconfig  | 2 +-
>   xen/drivers/passthrough/Kconfig | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 1479055..5a96a12 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -64,7 +64,7 @@ supported in this document.
>       Status, Intel VT-d: Supported
>       Status, ARM SMMUv1: Supported
>       Status, ARM SMMUv2: Supported
> -    Status, Renesas IPMMU-VMSA: Tech Preview
> +    Status, Renesas IPMMU-VMSA: Supported

Not entirely directed to the IPMMU-VMSA. Passthrough is not security 
supported on Arm today, so it is a bit odd to make the IOMMU drivers 
security supported.

I am thinking to downgrade the ARM SMMUv{1, 2} to "supported, not 
security supported" to avoid any confusion if a potential security issue 
arise.

Stefano, what do you think?

>   
>   ### ARM/GICv3 ITS
>   
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index 4bb7319..c93a6b2 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -25,7 +25,7 @@ config RCAR3
>   	bool "Renesas RCar3 support"
>   	depends on ARM_64
>   	select HAS_SCIF
> -	select IPMMU_VMSA if EXPERT
> +	select IPMMU_VMSA
>   	---help---
>   	Enable all the required drivers for Renesas RCar3
>   
> diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig
> index 73f4ad8..0036007 100644
> --- a/xen/drivers/passthrough/Kconfig
> +++ b/xen/drivers/passthrough/Kconfig
> @@ -14,7 +14,7 @@ config ARM_SMMU
>   	  ARM SMMU architecture.
>   
>   config IPMMU_VMSA
> -	bool "Renesas IPMMU-VMSA found in R-Car Gen3 SoCs" if EXPERT
> +	bool "Renesas IPMMU-VMSA found in R-Car Gen3 SoCs"
>   	depends on ARM_64
>   	---help---
>   	  Support for implementations of the Renesas IPMMU-VMSA found
> 

Cheers,

-- 
Julien Grall