From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH v5] checkpatch: extend attributes check to handle more patterns
Date: Sun, 25 Oct 2020 11:19:14 -0700 [thread overview]
Message-ID: <6c1c62cd8ac119a6d8a84f262f11eb509ba0e7cc.camel@perches.com> (raw)
In-Reply-To: <CABJPP5Cec7jKfaygRaxm-z5gzhg-7cBX1GP46NRQDM6rfhg3Ww@mail.gmail.com>
On Sun, 2020-10-25 at 23:40 +0530, Dwaipayan Ray wrote:
> On Sun, Oct 25, 2020 at 11:29 PM Joe Perches <joe@perches.com> wrote:
[]
> > Using $rawline would also change comments and that seems wrong.
> > Any reason to use $rawline instead of $line?
> Yes I used $line initially but changed it because quoted
> strings were being replaced.
>
> Like:
> __attribute__((__section__("_ftrace_events")))
Right thanks, that's a very sensible tradeoff to reduce code complexity.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] [PATCH v5] checkpatch: extend attributes check to handle more patterns
Date: Sun, 25 Oct 2020 11:19:14 -0700 [thread overview]
Message-ID: <6c1c62cd8ac119a6d8a84f262f11eb509ba0e7cc.camel@perches.com> (raw)
In-Reply-To: <CABJPP5Cec7jKfaygRaxm-z5gzhg-7cBX1GP46NRQDM6rfhg3Ww@mail.gmail.com>
On Sun, 2020-10-25 at 23:40 +0530, Dwaipayan Ray wrote:
> On Sun, Oct 25, 2020 at 11:29 PM Joe Perches <joe@perches.com> wrote:
[]
> > Using $rawline would also change comments and that seems wrong.
> > Any reason to use $rawline instead of $line?
> Yes I used $line initially but changed it because quoted
> strings were being replaced.
>
> Like:
> __attribute__((__section__("_ftrace_events")))
Right thanks, that's a very sensible tradeoff to reduce code complexity.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-25 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 10:15 [PATCH v5] checkpatch: extend attributes check to handle more patterns Dwaipayan Ray
2020-10-25 10:15 ` [Linux-kernel-mentees] " Dwaipayan Ray
2020-10-25 17:59 ` Joe Perches
2020-10-25 17:59 ` [Linux-kernel-mentees] " Joe Perches
2020-10-25 18:10 ` Dwaipayan Ray
2020-10-25 18:10 ` [Linux-kernel-mentees] " Dwaipayan Ray
2020-10-25 18:19 ` Joe Perches [this message]
2020-10-25 18:19 ` Joe Perches
2020-10-25 18:26 ` Dwaipayan Ray
2020-10-25 18:26 ` [Linux-kernel-mentees] " Dwaipayan Ray
2020-10-25 18:48 ` Dwaipayan Ray
2020-10-25 18:48 ` [Linux-kernel-mentees] " Dwaipayan Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c1c62cd8ac119a6d8a84f262f11eb509ba0e7cc.camel@perches.com \
--to=joe@perches.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.