From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Geliang Tang <geliang.tang@suse.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH RESEND mptcp-next v5 0/8] BPF packet scheduler
Date: Thu, 24 Mar 2022 16:15:38 -0700 (PDT) [thread overview]
Message-ID: <6c291a4-a0f7-88ab-9de2-b5c0d4ac3cae@linux.intel.com> (raw)
In-Reply-To: <cover.1648130637.git.geliang.tang@suse.com>
On Thu, 24 Mar 2022, Geliang Tang wrote:
> RESEND:
> - rebased to export/20220324T054815.
> - depends on: "add skc_to_mptcp_sock" v12.
>
> v5:
> - patch 1: define per-namespace sched_list (but only used init_net
> namespace. It is difficult to get 'net' in bpf_mptcp_sched_reg and
> bpf_mptcp_sched_unreg. I need some suggestions here.)
> - patch 2: skip mptcp_sched_default in mptcp_unregister_scheduler.
> - patch 8: add tests into mptcp.c, instead of bpf_tcp_ca.c.
>
I ran in to a build problem because CONFIG_BPF_SYSCALL was not set in my
.config and net/mptcp/Kconfig did not capture any BPF dependencies.
I think it would be best to allow MPTCP use without BPF enabled, so a new
CONFIG_MPTCP_BPF_SCHEDULER config option (with dependencies on MPTCP and
BPF_SYSCALL) would be good.
--
Mat Martineau
Intel
prev parent reply other threads:[~2022-03-24 23:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 14:09 [PATCH RESEND mptcp-next v5 0/8] BPF packet scheduler Geliang Tang
2022-03-24 14:09 ` [PATCH RESEND mptcp-next v5 1/8] mptcp: add struct mptcp_sched_ops Geliang Tang
2022-03-24 14:27 ` Florian Westphal
2022-03-24 14:41 ` Geliang Tang
2022-03-24 15:03 ` Florian Westphal
2022-03-24 16:06 ` Geliang Tang
2022-03-24 17:08 ` Florian Westphal
2022-03-24 22:14 ` Mat Martineau
2022-03-24 23:30 ` Mat Martineau
2022-03-24 23:36 ` Mat Martineau
2022-03-25 16:30 ` Geliang Tang
2022-03-24 14:09 ` [PATCH RESEND mptcp-next v5 2/8] mptcp: register default scheduler Geliang Tang
2022-03-24 14:09 ` [PATCH RESEND mptcp-next v5 3/8] mptcp: add a new sysctl scheduler Geliang Tang
2022-03-24 14:09 ` [PATCH RESEND mptcp-next v5 4/8] mptcp: add sched in mptcp_sock Geliang Tang
2022-03-24 14:09 ` [PATCH RESEND mptcp-next v5 5/8] mptcp: add get_subflow wrapper Geliang Tang
2022-03-24 23:23 ` Mat Martineau
2022-03-24 14:09 ` [PATCH RESEND mptcp-next v5 6/8] mptcp: add bpf_mptcp_sched_ops Geliang Tang
2022-03-24 14:09 ` [PATCH RESEND mptcp-next v5 7/8] selftests: bpf: add bpf_first scheduler Geliang Tang
2022-03-24 14:09 ` [PATCH RESEND mptcp-next v5 8/8] selftests: bpf: add bpf_first test Geliang Tang
2022-03-24 23:15 ` Mat Martineau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c291a4-a0f7-88ab-9de2-b5c0d4ac3cae@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.