From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 00/10] drm/i915: LVDS/eDP panel, EDID and fixed mode refactoring Date: Fri, 19 Oct 2012 18:58:56 +0100 Message-ID: <6c3329$6r5408@orsmga002.jf.intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 544059E957 for ; Fri, 19 Oct 2012 10:59:20 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org, daniel@ffwll.ch Cc: jani.nikula@intel.com List-Id: intel-gfx@lists.freedesktop.org On Fri, 19 Oct 2012 14:51:42 +0300, Jani Nikula wrote: > Hi all, this is some LVDS/eDP panel refactoring and cleanup based on > Chris Wilson's earlier work and ideas last year [1]. I left out eDP lid > notifier based on Jesse's comments [2]; more of Jesse's old review is at > [3]. > > The main high level difference to Chris' patches is that intel_panel and > the cached EDID are placed in intel_connector rather than anywhere > else. This is because Daniel hinted that we might want to do some more > generic EDID caching (indeed, why keep reading the EDID if the display > has not been unplugged?). With the EDID and intel_panel in > intel_connector, we can add functions to query EDID and modes with > transparent caching and fallback to fixed mode when EDID is not > available. Patches look really good, I haven't checked yet to see if there is anything missing, but I already like the improvement to the code.... So for the series, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre