From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932604AbdDZR74 (ORCPT ); Wed, 26 Apr 2017 13:59:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43128 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932570AbdDZR7p (ORCPT ); Wed, 26 Apr 2017 13:59:45 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 26 Apr 2017 10:59:43 -0700 From: Subhash Jadavani To: SF Markus Elfring Cc: linux-scsi@vger.kernel.org, "James E. J. Bottomley" , "Martin K. Petersen" , Vinayak Holikatti , LKML , kernel-janitors@vger.kernel.org, linux-scsi-owner@vger.kernel.org Subject: Re: [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler() In-Reply-To: <9fc152fd-0881-85f6-a4d0-3db27dc364f5@users.sourceforge.net> References: <75622f45-f46c-e52f-2b9e-6ff5ce32184a@users.sourceforge.net> <9fc152fd-0881-85f6-a4d0-3db27dc364f5@users.sourceforge.net> Message-ID: <6c360ac6f9b5a9a1591757a35b8d5036@codeaurora.org> User-Agent: Roundcube Webmail/1.2.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-04-25 13:30, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 25 Apr 2017 22:00:05 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: void function return statements are not generally useful > > Thus remove such a statement here. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/ufs/ufshcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 5216e33e61a3..9018f26a5667 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4966,7 +4966,6 @@ static void > ufshcd_exception_event_handler(struct work_struct *work) > > out: > pm_runtime_put_sync(hba->dev); > - return; > } > > /* Complete requests that have door-bell cleared */ Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subhash Jadavani Date: Wed, 26 Apr 2017 17:59:43 +0000 Subject: Re: [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler( Message-Id: <6c360ac6f9b5a9a1591757a35b8d5036@codeaurora.org> List-Id: References: <75622f45-f46c-e52f-2b9e-6ff5ce32184a@users.sourceforge.net> <9fc152fd-0881-85f6-a4d0-3db27dc364f5@users.sourceforge.net> In-Reply-To: <9fc152fd-0881-85f6-a4d0-3db27dc364f5@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-scsi@vger.kernel.org, "James E. J. Bottomley" , "Martin K. Petersen" , Vinayak Holikatti , LKML , kernel-janitors@vger.kernel.org, linux-scsi-owner@vger.kernel.org On 2017-04-25 13:30, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 25 Apr 2017 22:00:05 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: void function return statements are not generally useful > > Thus remove such a statement here. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/ufs/ufshcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 5216e33e61a3..9018f26a5667 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4966,7 +4966,6 @@ static void > ufshcd_exception_event_handler(struct work_struct *work) > > out: > pm_runtime_put_sync(hba->dev); > - return; > } > > /* Complete requests that have door-bell cleared */ Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project