All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@xenomai.org>
Subject: Re: [Xenomai] Flexcan driver build broken since 3.11 - also in upstream?
Date: Mon, 08 Sep 2014 15:55:14 +0200	[thread overview]
Message-ID: <6c3ae139b47ea3cfa021dff83f10cc52@grandegger.com> (raw)
In-Reply-To: <540DA12E.1030607@siemens.com>

On Mon, 08 Sep 2014 14:29:34 +0200, Jan Kiszka <jan.kiszka@siemens.com>
wrote:
> On 2014-09-08 12:39, Gilles Chanteperdrix wrote:
>> On 09/08/2014 11:33 AM, Jan Kiszka wrote:
>>> On 2014-09-08 11:25, Wolfgang Grandegger wrote:
>>>> On Mon, 08 Sep 2014 08:37:14 +0200, Jan Kiszka
<jan.kiszka@siemens.com>
>>>> wrote:
>>>>> Hi all,
>>>>>
>>>>> just noticed a build breakage in Xenomai 2:
ksrc/drivers/can/flexcan.c
>>>>> is looking for linux/can/platform/flexcan.h which was removed in
>>>>> baffd2e8d9. But both the Xenomai driver and upstream's flexcan.c
still
>>>>> use the flexcan_platform_data structure which I do not find anywhere
>>>>> in
>>>>> the kernel. Does anyone know what happened there?
>>>>
>>>> I just cloned Linus's kernel tree and do *not* see that any CAN
driver
>>>> is
>>>> still including "linux/can/platform/flexcan":
>>>>
>>>> $ grep -r '/platform/flexcan.h' linux/drivers/net/can/
>>>> $
>>>>
>>>> Will have a closer look later today.
>>>
>>> Also try "git grep flexcan_platform_data" - confuses me...
>> 
>> Well, the driver never uses the contents of the pointer to this
>> structure, so, it does not really need the structure to be defined...
> 
> Indeed, dead code...
> 
>> Or am I missing something? Anyway, it would seem the driver has been
>> converted to device tree:
>> 
>> Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>> 
> 
> Then we need to convert the RT driver as well, right?

Yes... while still being compatible with old(er) kernel versions.
And there are various other improvements and most likely bug fixes.
Unfortunately I do currently not have Flexcan hardware at hand.

Wolfgang.



      reply	other threads:[~2014-09-08 13:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08  6:37 [Xenomai] Flexcan driver build broken since 3.11 - also in upstream? Jan Kiszka
2014-09-08  9:25 ` Wolfgang Grandegger
2014-09-08  9:33   ` Jan Kiszka
2014-09-08 10:39     ` Gilles Chanteperdrix
2014-09-08 12:29       ` Jan Kiszka
2014-09-08 13:55         ` Wolfgang Grandegger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c3ae139b47ea3cfa021dff83f10cc52@grandegger.com \
    --to=wg@grandegger.com \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.