Re: [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()

From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()
Date: Tue, 29 Sep 2020 11:08:27 -0500	[thread overview]
Message-ID: <6c46c520-a506-654d-ac5a-8a5189d85114@redhat.com> (raw)
In-Reply-To: <20200928162333.14998-1-berto@igalia.com>


[-- Attachment #1.1: Type: text/plain, Size: 1334 bytes --]

On 9/28/20 11:23 AM, Alberto Garcia wrote:
> We overlooked these in 02b1ecfa100e7ecc2306560cd27a4a2622bfeb04
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  block/qcow2-cluster.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index 9acc6ce4ae..aa87d3e99b 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -240,14 +240,14 @@ int qcow2_write_l1_entry(BlockDriverState *bs, int l1_index)
>      }
>  
>      ret = qcow2_pre_write_overlap_check(bs, QCOW2_OL_ACTIVE_L1,
> -            s->l1_table_offset + 8 * l1_start_index, bufsize, false);
> +            s->l1_table_offset + L1E_SIZE * l1_start_index, bufsize, false);
>      if (ret < 0) {
>          return ret;
>      }
>  
>      BLKDBG_EVENT(bs->file, BLKDBG_L1_UPDATE);
>      ret = bdrv_pwrite_sync(bs->file,
> -                           s->l1_table_offset + 8 * l1_start_index,
> +                           s->l1_table_offset + L1E_SIZE * l1_start_index,
>                             buf, bufsize);
>      if (ret < 0) {
>          return ret;
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]