* [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()
@ 2021-03-05 9:10 Piyush Mehta
2021-04-06 14:11 ` Michal Simek
2021-04-06 15:25 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Piyush Mehta @ 2021-03-05 9:10 UTC (permalink / raw)
To: axboe; +Cc: linux-ide, linux-kernel, git, sgoud, michal.simek, Piyush Mehta
Updated code with already prepared dev_err_probe(). It reduces code size
and simplifies EPROBE_DEFER handling.
Also, unify message format for similar error cases.
Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
---
This patch is based on ahci-ceva patches:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=5542fabd9e07d6c49c07862e73070c325f93d390
Tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/tree/?h=for-next
Changes for V2:
- Address review comment- remove curly brackets {}.
---
drivers/ata/ahci_ceva.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/ata/ahci_ceva.c b/drivers/ata/ahci_ceva.c
index b980218..50b56cd 100644
--- a/drivers/ata/ahci_ceva.c
+++ b/drivers/ata/ahci_ceva.c
@@ -206,11 +206,9 @@ static int ceva_ahci_probe(struct platform_device *pdev)
cevapriv->rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
NULL);
- if (IS_ERR(cevapriv->rst)) {
- if (PTR_ERR(cevapriv->rst) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "failed to get reset: %ld\n",
- PTR_ERR(cevapriv->rst));
- }
+ if (IS_ERR(cevapriv->rst))
+ dev_err_probe(&pdev->dev, PTR_ERR(cevapriv->rst),
+ "failed to get reset\n");
hpriv = ahci_platform_get_resources(pdev, 0);
if (IS_ERR(hpriv))
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()
2021-03-05 9:10 [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe() Piyush Mehta
@ 2021-04-06 14:11 ` Michal Simek
2021-04-06 15:25 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2021-04-06 14:11 UTC (permalink / raw)
To: Piyush Mehta, axboe; +Cc: linux-ide, linux-kernel, git, sgoud, michal.simek
Hi Jens,
On 3/5/21 10:10 AM, Piyush Mehta wrote:
> Updated code with already prepared dev_err_probe(). It reduces code size
> and simplifies EPROBE_DEFER handling.
>
> Also, unify message format for similar error cases.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> ---
> This patch is based on ahci-ceva patches:
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=5542fabd9e07d6c49c07862e73070c325f93d390
>
> Tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/tree/?h=for-next
>
> Changes for V2:
> - Address review comment- remove curly brackets {}.
> ---
> drivers/ata/ahci_ceva.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/ata/ahci_ceva.c b/drivers/ata/ahci_ceva.c
> index b980218..50b56cd 100644
> --- a/drivers/ata/ahci_ceva.c
> +++ b/drivers/ata/ahci_ceva.c
> @@ -206,11 +206,9 @@ static int ceva_ahci_probe(struct platform_device *pdev)
>
> cevapriv->rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
> NULL);
> - if (IS_ERR(cevapriv->rst)) {
> - if (PTR_ERR(cevapriv->rst) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "failed to get reset: %ld\n",
> - PTR_ERR(cevapriv->rst));
> - }
> + if (IS_ERR(cevapriv->rst))
> + dev_err_probe(&pdev->dev, PTR_ERR(cevapriv->rst),
> + "failed to get reset\n");
>
> hpriv = ahci_platform_get_resources(pdev, 0);
> if (IS_ERR(hpriv))
>
Can you please apply this to your tree?
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()
2021-03-05 9:10 [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe() Piyush Mehta
2021-04-06 14:11 ` Michal Simek
@ 2021-04-06 15:25 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-04-06 15:25 UTC (permalink / raw)
To: Piyush Mehta; +Cc: linux-ide, linux-kernel, git, sgoud, michal.simek
On 3/5/21 2:10 AM, Piyush Mehta wrote:
> Updated code with already prepared dev_err_probe(). It reduces code size
> and simplifies EPROBE_DEFER handling.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-06 15:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 9:10 [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe() Piyush Mehta
2021-04-06 14:11 ` Michal Simek
2021-04-06 15:25 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.