From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B5BC43381 for ; Tue, 26 Mar 2019 14:53:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3C162075C for ; Tue, 26 Mar 2019 14:53:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f3zXjJGO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3C162075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iTqXE7ciyhS0faUuFvH04IDIzAPIO5Ovw4uOl9no6RE=; b=f3zXjJGOiHJXc9H1AOh5bFwPC 8t2wqh2ddF8tbrvx24IfIIk236AV9znGwpfMen0ph17Ks9+kzFgVpFo1hOh75QCpHRrYRUkWeJgis WIWFosZjWY1u4iMA6SxRpuNBcPDI0pqifz5m9cAHbMcnMUc18tm4Y7yyJvVvQGPKpZFPvkXp8sEMx bbg4bKQcZeHxrRBt8oQrteVE1c3kyWqLdx7Ta/SboR8E2chjuPAkjsAVLPNrbRsyjiOlt+Ysllppy JUOOT4zAyFFmqdoW0OVx0KfOgPs/cIUUFmRHoJpYQ2/FpdZsFAEOAI6PrN65lmEFeq1IFVTu+zvIm ei6y6A7SQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8nST-0004It-QD; Tue, 26 Mar 2019 14:53:45 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8nSQ-0004IN-CC for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 14:53:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D8FD80D; Tue, 26 Mar 2019 07:53:39 -0700 (PDT) Received: from [10.37.12.89] (unknown [10.37.12.89]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D02D43F575; Tue, 26 Mar 2019 07:53:37 -0700 (PDT) Subject: Re: [PATCH v2 04/16] coresight: Adding return code to sink::disable() operation To: mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org References: <20190325215632.17013-1-mathieu.poirier@linaro.org> <20190325215632.17013-5-mathieu.poirier@linaro.org> From: Suzuki K Poulose Message-ID: <6c49fb4c-3bf8-ec39-ba3a-c8431b361c87@arm.com> Date: Tue, 26 Mar 2019 14:55:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20190325215632.17013-5-mathieu.poirier@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_075342_417237_A98ACF80 X-CRM114-Status: GOOD ( 14.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexander.shishkin@linux.intel.com, peterz@infradead.org, coresight@lists.linaro.org, Mike.Leach@arm.com, leo.yan@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/25/2019 09:56 PM, Mathieu Poirier wrote: > In preparation to handle device reference counting inside of the sink > drivers, add a return code to the sink::disable() operation so that > proper action can be taken if a sink has not been disabled. > > Signed-off-by: Mathieu Poirier This one and the next patch in the series, together fixes an issue where we could leave the a sink still enabled, but with refcounts dropped. (i.e, if we collide with someone reading the sink, while trying to disable). As such the issue has been lying around since the beginning, we don't have to bother about fixing the issue in one single patch. Thus, Reviewed-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel