All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Watt <jpewhacker@gmail.com>
To: David Frey <dpfrey@gmail.com>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] bluez5: remove udev dependency
Date: Wed, 22 May 2019 17:00:47 -0500	[thread overview]
Message-ID: <6c51d154-6f03-b53b-4f0c-e72d05a0b33b@gmail.com> (raw)
In-Reply-To: <20190522215541.9689-1-dpfrey@gmail.com>


On 5/22/19 4:55 PM, David Frey wrote:
> udev is an optional dependency of bluez5, so use PACKAGECONFIG to allow
> users to decide if they want udev support.
>
> Signed-off-by: David Frey <dpfrey@gmail.com>
> ---
>   meta/recipes-connectivity/bluez5/bluez5.inc | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index aaf2af975d..568de86d6d 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -6,7 +6,7 @@ LICENSE = "GPLv2+ & LGPLv2.1+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>                       file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
>                       file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e"
> -DEPENDS = "udev dbus-glib glib-2.0"
> +DEPENDS = "dbus-glib glib-2.0"
>   PROVIDES += "bluez-hcidump"
>   RPROVIDES_${PN} += "bluez-hcidump"

Should it be enabled by default?

>   
> @@ -43,6 +43,7 @@ PACKAGECONFIG[threads] = "--enable-threads,--disable-threads"
>   PACKAGECONFIG[deprecated] = "--enable-deprecated,--disable-deprecated"
>   PACKAGECONFIG[mesh] = "--enable-mesh,--disable-mesh, json-c ell"
>   PACKAGECONFIG[btpclient] = "--enable-btpclient,--disable-btpclient, ell"
> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
>   
>   SRC_URI = "\
>       ${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \


  reply	other threads:[~2019-05-22 22:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 21:55 [PATCH] bluez5: remove udev dependency David Frey
2019-05-22 22:00 ` Joshua Watt [this message]
2019-05-22 22:03 ` Adrian Bunk
2019-05-23 16:12   ` David Frey
2019-05-23 16:30     ` Joshua Watt
2019-05-23 16:45       ` David Frey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c51d154-6f03-b53b-4f0c-e72d05a0b33b@gmail.com \
    --to=jpewhacker@gmail.com \
    --cc=dpfrey@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.