From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC57CC433DF for ; Fri, 21 Aug 2020 12:20:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7905420724 for ; Fri, 21 Aug 2020 12:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727797AbgHUMUj (ORCPT ); Fri, 21 Aug 2020 08:20:39 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:29032 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727837AbgHUMSf (ORCPT ); Fri, 21 Aug 2020 08:18:35 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-48-5tsXRHYdNKyZh1jxPg801Q-1; Fri, 21 Aug 2020 13:18:29 +0100 X-MC-Unique: 5tsXRHYdNKyZh1jxPg801Q-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 21 Aug 2020 13:18:28 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Fri, 21 Aug 2020 13:18:28 +0100 From: David Laight To: 'Nicolas Boichat' CC: Steven Rostedt , Mauro Carvalho Chehab , Greg Kroah-Hartman , "Andy Shevchenko" , Sakari Ailus , "devel@driverdev.osuosl.org" , lkml , "Linux Media Mailing List" , Peter Zijlstra , Thomas Gleixner , Josh Poimboeuf Subject: RE: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed Thread-Topic: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed Thread-Index: AQHWd1MRQFeXK2GIIEihfK8khxWsrqlCP3rwgAAMdQCAACDnQP//+vQAgAARUeA= Date: Fri, 21 Aug 2020 12:18:28 +0000 Message-ID: <6c5249afad274ce49e643d9b05706e3a@AcuMS.aculab.com> References: <20200820170951.v4.1.Ia54fe801f246a0b0aee36fb1f3bfb0922a8842b0@changeid> <20200820170951.v4.3.I066d89f39023956c47fb0a42edf196b3950ffbf7@changeid> <20200820102347.15d2f610@oasis.local.home> <20200820203601.4f70bf98@oasis.local.home> <21fae92da07c4566ba4eed3b5e1bce2d@AcuMS.aculab.com> <898c56e4b7ef4c3da1d634fdef5a8898@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: aculab.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RnJvbTogTmljb2xhcyBCb2ljaGF0DQo+IFNlbnQ6IDIxIEF1Z3VzdCAyMDIwIDEzOjA3DQouLi4N Cj4gPiBZb3UgbWlnaHQgYWxzbyB3YW50IGEgI2RlZmluZSB0aGF0IGNhbiBzZXQgdGVtcG9yYXJp bHkNCj4gPiB0byBlbmFibGUgdHJhY2VzIGluIGEgc3BlY2lmaWMgZmlsZS9tb2R1bGUgZXZlbiB0 aG91Z2gNCj4gPiBDT05GSUdfVFJBQ0U9bi4NCj4gDQo+IEkgZG9uJ3QgdW5kZXJzdGFuZCBob3cg dHJhY2VzIGFyZSBzdXBwb3NlZCB0byB3b3JrIHdpdGggQ09ORklHX1RSQUNFPW4/DQoNClByb2Jh Ymx5IGJlY2F1c2UgSSBtZWFudCBzb21ldGhpbmcgZGlmZmVyZW50IDotKQ0KDQpZb3Ugd2FudCB0 aGUga2VybmVsIGJ1aWx0IHNvIHRoYXQgdGhlcmUgYXJlIG5vIChleHBhbmRlZCkNCmNhbGxzIHRv IHRyYWNlX3ByaW50ZigpIGJ1dCB3aXRoIHN1cHBvcnQgZm9yIG1vZHVsZXMgdGhhdA0KY29udGFp biB0aGVtLg0KDQpUaGVuIEkgY2FuIGxvYWQgYSBtb2R1bGUgaW50byBhIGRpc3RybyBrZXJuZWwg dGhhdA0KY29udGFpbnMgdHJhY2VfcHJpbnRmKCkgY2FsbHMgZm9yIGRlYnVnIHRlc3RpbmcuDQoN CldoaWNoIGlzIHdoeSBJIHdhcyBzdWdnZXN0aW5nIGEgY29uZmlnIG9wdGlvbiB0aGF0DQpvbmx5 IHJhbmQtY29uZmlnIGJ1aWxkcyB3b3VsZCBldmVyIHNldCB0aGF0IHdvdWxkDQpjYXVzZSB0aGUg Y2FsbHMgdG8gZ2VuZXJhdGUgY29tcGlsZS10aW1lIGVycm9ycy4NCg0KCURhdmlkDQoNCi0NClJl Z2lzdGVyZWQgQWRkcmVzcyBMYWtlc2lkZSwgQnJhbWxleSBSb2FkLCBNb3VudCBGYXJtLCBNaWx0 b24gS2V5bmVzLCBNSzEgMVBULCBVSw0KUmVnaXN0cmF0aW9uIE5vOiAxMzk3Mzg2IChXYWxlcykN Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F2EC433DF for ; Fri, 21 Aug 2020 12:18:37 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82E8020724 for ; Fri, 21 Aug 2020 12:18:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82E8020724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 53C90868A9; Fri, 21 Aug 2020 12:18:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZahAWpMCIaIb; Fri, 21 Aug 2020 12:18:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 649FF86268; Fri, 21 Aug 2020 12:18:36 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id D37FD1BF2BC for ; Fri, 21 Aug 2020 12:18:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id CD8848832B for ; Fri, 21 Aug 2020 12:18:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9e26qbDiFFOC for ; Fri, 21 Aug 2020 12:18:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [207.82.80.151]) by whitealder.osuosl.org (Postfix) with ESMTPS id 80408882EA for ; Fri, 21 Aug 2020 12:18:33 +0000 (UTC) Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-48-5tsXRHYdNKyZh1jxPg801Q-1; Fri, 21 Aug 2020 13:18:29 +0100 X-MC-Unique: 5tsXRHYdNKyZh1jxPg801Q-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 21 Aug 2020 13:18:28 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Fri, 21 Aug 2020 13:18:28 +0100 From: David Laight To: 'Nicolas Boichat' Subject: RE: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed Thread-Topic: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed Thread-Index: AQHWd1MRQFeXK2GIIEihfK8khxWsrqlCP3rwgAAMdQCAACDnQP//+vQAgAARUeA= Date: Fri, 21 Aug 2020 12:18:28 +0000 Message-ID: <6c5249afad274ce49e643d9b05706e3a@AcuMS.aculab.com> References: <20200820170951.v4.1.Ia54fe801f246a0b0aee36fb1f3bfb0922a8842b0@changeid> <20200820170951.v4.3.I066d89f39023956c47fb0a42edf196b3950ffbf7@changeid> <20200820102347.15d2f610@oasis.local.home> <20200820203601.4f70bf98@oasis.local.home> <21fae92da07c4566ba4eed3b5e1bce2d@AcuMS.aculab.com> <898c56e4b7ef4c3da1d634fdef5a8898@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: aculab.com X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devel@driverdev.osuosl.org" , Andy Shevchenko , Peter Zijlstra , Greg Kroah-Hartman , lkml , Steven Rostedt , Sakari Ailus , Josh Poimboeuf , Thomas Gleixner , Mauro Carvalho Chehab , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" From: Nicolas Boichat > Sent: 21 August 2020 13:07 ... > > You might also want a #define that can set temporarily > > to enable traces in a specific file/module even though > > CONFIG_TRACE=n. > > I don't understand how traces are supposed to work with CONFIG_TRACE=n? Probably because I meant something different :-) You want the kernel built so that there are no (expanded) calls to trace_printf() but with support for modules that contain them. Then I can load a module into a distro kernel that contains trace_printf() calls for debug testing. Which is why I was suggesting a config option that only rand-config builds would ever set that would cause the calls to generate compile-time errors. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel