On 03/07/19 9:00 AM, Oliver O'Halloran wrote: > On Wed, 2019-06-26 at 02:15 +0530, Hari Bathini wrote: >> Refactoring fadump code means internal fadump code is referenced from >> different places. For ease, move internal code to a new file. > Can you elaborate a bit? I don't really get what the difference between > fadump and fadump-internal code is supposed to be. Why can't all this > just live in fadump.c? I am trying to keep the code referenced by both platforms (platform/pseries & platform/powernv) in an internal file while using include/asm/fadump.h for the interface with other kernel components..