* [PATCH] hpsa: correct call to hpsa_do_reset
@ 2016-09-20 20:42 Don Brace
2016-09-21 16:55 ` Tomas Henzl
2016-09-21 21:01 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Don Brace @ 2016-09-20 20:42 UTC (permalink / raw)
To: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara, hch,
scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott
Cc: linux-scsi
calling fill_cmd() using a MACRO definition not handled in
switch statement causes BUG() to be called.
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 2 +-
drivers/scsi/hpsa.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 030d002..94be51c 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5935,7 +5935,7 @@ static int hpsa_send_reset_as_abort_ioaccel2(struct ctlr_info *h,
"Reset as abort: Resetting physical device at scsi3addr 0x%02x%02x%02x%02x%02x%02x%02x%02x\n",
psa[0], psa[1], psa[2], psa[3],
psa[4], psa[5], psa[6], psa[7]);
- rc = hpsa_do_reset(h, dev, psa, HPSA_RESET_TYPE_TARGET, reply_queue);
+ rc = hpsa_do_reset(h, dev, psa, HPSA_PHYS_TARGET_RESET, reply_queue);
if (rc != 0) {
dev_warn(&h->pdev->dev,
"Reset as abort: Failed on physical device at scsi3addr 0x%02x%02x%02x%02x%02x%02x%02x%02x\n",
diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index a1487e6..82cdfad 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -312,7 +312,6 @@ struct offline_device_entry {
#define HPSA_DEVICE_RESET_MSG 1
#define HPSA_RESET_TYPE_CONTROLLER 0x00
#define HPSA_RESET_TYPE_BUS 0x01
-#define HPSA_RESET_TYPE_TARGET 0x03
#define HPSA_RESET_TYPE_LUN 0x04
#define HPSA_PHYS_TARGET_RESET 0x99 /* not defined by cciss spec */
#define HPSA_MSG_SEND_RETRY_LIMIT 10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hpsa: correct call to hpsa_do_reset
2016-09-20 20:42 [PATCH] hpsa: correct call to hpsa_do_reset Don Brace
@ 2016-09-21 16:55 ` Tomas Henzl
2016-09-21 21:01 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Tomas Henzl @ 2016-09-21 16:55 UTC (permalink / raw)
To: Don Brace, jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara,
hch, scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott
Cc: linux-scsi
On 20.9.2016 22:42, Don Brace wrote:
> calling fill_cmd() using a MACRO definition not handled in
> switch statement causes BUG() to be called.
>
> Reviewed-by: Scott Teel <scott.teel@microsemi.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
> Signed-off-by: Don Brace <don.brace@microsemi.com>
Looks good,
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hpsa: correct call to hpsa_do_reset
2016-09-20 20:42 [PATCH] hpsa: correct call to hpsa_do_reset Don Brace
2016-09-21 16:55 ` Tomas Henzl
@ 2016-09-21 21:01 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-09-21 21:01 UTC (permalink / raw)
To: Don Brace
Cc: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara, hch,
scott.teel, Viswas.G, Justin.Lindley, scott.benesh, elliott,
linux-scsi, Tomas Henzl
>>>>> "Don" == Don Brace <don.brace@microsemi.com> writes:
Don> calling fill_cmd() using a MACRO definition not handled in switch
Don> statement causes BUG() to be called.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-21 21:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-20 20:42 [PATCH] hpsa: correct call to hpsa_do_reset Don Brace
2016-09-21 16:55 ` Tomas Henzl
2016-09-21 21:01 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.