From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932615AbdA0KjB (ORCPT ); Fri, 27 Jan 2017 05:39:01 -0500 Received: from mailcl1.heig-vd.ch ([193.134.216.182]:39982 "EHLO heig-vd.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932522AbdA0KiU (ORCPT ); Fri, 27 Jan 2017 05:38:20 -0500 Subject: Re: [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max frequency To: Maxime Ripard References: CC: Chen-Yu Tsai , Ulf Hansson , , Andre Przywara , , , Rob Herring , From: Florian Vaussard Message-ID: <6c6bf169-4b2e-6b55-54db-d21da73a8f6e@heig-vd.ch> Date: Fri, 27 Jan 2017 11:29:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.192.127.70] X-ClientProxiedBy: EINTFEA.einet.ad.eivd.ch (10.192.41.59) To EINTMBXC.einet.ad.eivd.ch (10.192.41.65) X-MailCleaner-RDNS: invalid reverse DNS for 10.192.41.61 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On 01/26/2017 10:06 AM, Maxime Ripard wrote: > The eMMC controller seem to have a maximum frequency of 200MHz, while the > regular MMC controllers are capped at 150MHz. > > Since older SoCs cannot go that high, we cannot change the default maximum > frequency, but fortunately for us we have a property for that in the DT. > > This also has the side effect of allowing to use the MMC HS200 and SD > SDR104 modes for the boards that support it (with either 1.2v or 1.8v IOs). > > Signed-off-by: Maxime Ripard > > arm64: allwinner: a64: Limit MMC0 and MMC1 rates to 150MHz > > Trying to set the bus to 200MHz on MMC1 when doing SDIO is failing. > Allwinner sets the maximum for this bus to 150MHz, so enforce that limit. > > This hasn't been tested with MMC0, but the documented limit is the same, > and I expect the behaviour to be the same. > > Signed-off-by: Maxime Ripard I suspect that you are trying to increase your number of Signed-off-by tags by using unfair means :) Otherwise the squashed commit message is probably worth some cleaning. Best, Florian > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 3 +++ > 1 file changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7b79c319ad3c..cb3e0cf2191a 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -130,6 +130,7 @@ > resets = <&ccu RST_BUS_MMC0>; > reset-names = "ahb"; > interrupts = ; > + max-frequency = <150000000>; > status = "disabled"; > #address-cells = <1>; > #size-cells = <0>; > @@ -143,6 +144,7 @@ > resets = <&ccu RST_BUS_MMC1>; > reset-names = "ahb"; > interrupts = ; > + max-frequency = <150000000>; > status = "disabled"; > #address-cells = <1>; > #size-cells = <0>; > @@ -156,6 +158,7 @@ > resets = <&ccu RST_BUS_MMC2>; > reset-names = "ahb"; > interrupts = ; > + max-frequency = <200000000>; > status = "disabled"; > #address-cells = <1>; > #size-cells = <0>; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Vaussard Subject: Re: [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max frequency Date: Fri, 27 Jan 2017 11:29:53 +0100 Message-ID: <6c6bf169-4b2e-6b55-54db-d21da73a8f6e@heig-vd.ch> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Maxime Ripard Cc: devicetree@vger.kernel.org, Ulf Hansson , Andre Przywara , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Maxime, On 01/26/2017 10:06 AM, Maxime Ripard wrote: > The eMMC controller seem to have a maximum frequency of 200MHz, while the > regular MMC controllers are capped at 150MHz. > > Since older SoCs cannot go that high, we cannot change the default maximum > frequency, but fortunately for us we have a property for that in the DT. > > This also has the side effect of allowing to use the MMC HS200 and SD > SDR104 modes for the boards that support it (with either 1.2v or 1.8v IOs). > > Signed-off-by: Maxime Ripard > > arm64: allwinner: a64: Limit MMC0 and MMC1 rates to 150MHz > > Trying to set the bus to 200MHz on MMC1 when doing SDIO is failing. > Allwinner sets the maximum for this bus to 150MHz, so enforce that limit. > > This hasn't been tested with MMC0, but the documented limit is the same, > and I expect the behaviour to be the same. > > Signed-off-by: Maxime Ripard I suspect that you are trying to increase your number of Signed-off-by tags by using unfair means :) Otherwise the squashed commit message is probably worth some cleaning. Best, Florian > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 3 +++ > 1 file changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7b79c319ad3c..cb3e0cf2191a 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -130,6 +130,7 @@ > resets = <&ccu RST_BUS_MMC0>; > reset-names = "ahb"; > interrupts = ; > + max-frequency = <150000000>; > status = "disabled"; > #address-cells = <1>; > #size-cells = <0>; > @@ -143,6 +144,7 @@ > resets = <&ccu RST_BUS_MMC1>; > reset-names = "ahb"; > interrupts = ; > + max-frequency = <150000000>; > status = "disabled"; > #address-cells = <1>; > #size-cells = <0>; > @@ -156,6 +158,7 @@ > resets = <&ccu RST_BUS_MMC2>; > reset-names = "ahb"; > interrupts = ; > + max-frequency = <200000000>; > status = "disabled"; > #address-cells = <1>; > #size-cells = <0>; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: florian.vaussard@heig-vd.ch (Florian Vaussard) Date: Fri, 27 Jan 2017 11:29:53 +0100 Subject: [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max frequency In-Reply-To: References: Message-ID: <6c6bf169-4b2e-6b55-54db-d21da73a8f6e@heig-vd.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Maxime, On 01/26/2017 10:06 AM, Maxime Ripard wrote: > The eMMC controller seem to have a maximum frequency of 200MHz, while the > regular MMC controllers are capped at 150MHz. > > Since older SoCs cannot go that high, we cannot change the default maximum > frequency, but fortunately for us we have a property for that in the DT. > > This also has the side effect of allowing to use the MMC HS200 and SD > SDR104 modes for the boards that support it (with either 1.2v or 1.8v IOs). > > Signed-off-by: Maxime Ripard > > arm64: allwinner: a64: Limit MMC0 and MMC1 rates to 150MHz > > Trying to set the bus to 200MHz on MMC1 when doing SDIO is failing. > Allwinner sets the maximum for this bus to 150MHz, so enforce that limit. > > This hasn't been tested with MMC0, but the documented limit is the same, > and I expect the behaviour to be the same. > > Signed-off-by: Maxime Ripard I suspect that you are trying to increase your number of Signed-off-by tags by using unfair means :) Otherwise the squashed commit message is probably worth some cleaning. Best, Florian > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 3 +++ > 1 file changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7b79c319ad3c..cb3e0cf2191a 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -130,6 +130,7 @@ > resets = <&ccu RST_BUS_MMC0>; > reset-names = "ahb"; > interrupts = ; > + max-frequency = <150000000>; > status = "disabled"; > #address-cells = <1>; > #size-cells = <0>; > @@ -143,6 +144,7 @@ > resets = <&ccu RST_BUS_MMC1>; > reset-names = "ahb"; > interrupts = ; > + max-frequency = <150000000>; > status = "disabled"; > #address-cells = <1>; > #size-cells = <0>; > @@ -156,6 +158,7 @@ > resets = <&ccu RST_BUS_MMC2>; > reset-names = "ahb"; > interrupts = ; > + max-frequency = <200000000>; > status = "disabled"; > #address-cells = <1>; > #size-cells = <0>; >