From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B247AC3A59D for ; Fri, 16 Aug 2019 12:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93A9221655 for ; Fri, 16 Aug 2019 12:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727332AbfHPMnk (ORCPT ); Fri, 16 Aug 2019 08:43:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47714 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbfHPMnk (ORCPT ); Fri, 16 Aug 2019 08:43:40 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C907308302F; Fri, 16 Aug 2019 12:43:40 +0000 (UTC) Received: from [10.10.123.64] (ovpn-123-64.rdu2.redhat.com [10.10.123.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 751431719E; Fri, 16 Aug 2019 12:43:39 +0000 (UTC) Subject: Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules To: Miroslav Benes , Masahiro Yamada Cc: Linux Kernel Mailing List , live-patching@vger.kernel.org, Linux Kbuild mailing list References: <20190509143859.9050-1-joe.lawrence@redhat.com> <20190509143859.9050-7-joe.lawrence@redhat.com> <20190812155626.GA19845@redhat.com> From: Joe Lawrence Message-ID: <6c7e4d19-b993-1c14-d6cf-6aa1ee891361@redhat.com> Date: Fri, 16 Aug 2019 08:43:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 16 Aug 2019 12:43:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/16/19 4:19 AM, Miroslav Benes wrote: > Hi, > >> I cleaned up the build system, and pushed it based on my >> kbuild tree. >> >> Please see: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git >> klp-cleanup > > This indeed looks much simpler and cleaner (as far as I can judge with my > limited kbuild knowledge). We just need to remove MODULE_INFO(livepatch, > "Y") from lib/livepatch/test_klp_convert_mod_a.c to make it compile and > work (test_klp_convert_mod_a is not a livepatch module, it is just a dummy > module which is then livepatched by lib/livepatch/test_klp_convert1.c). > Yeah, Masahiro this is great, thanks for reworking this! I did tweak one module like Miroslav mentioned and I think a few of the newly generated files need to be cleaned up as part of "make clean", but all said, this is a nice improvement. Are you targeting the next merge window for your kbuild branch? (This appears to be what the klp-cleanup branch was based on.) Thanks, -- Joe