From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B37C433EF for ; Thu, 19 May 2022 19:51:37 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6A5440223; Thu, 19 May 2022 21:51:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 95D8240156 for ; Thu, 19 May 2022 21:51:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652989895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9KtfOhFFvee1eesMPm9hQavx4a8Q+z+7oJbUv+bY1R0=; b=JEvHccyqJLI4oErN9MXvMH0QNJfSea+9Oeya8FyEeAtTEpCulpII5wqvYJQECnFKfnnRvy FE6N60/YidAvWE6GdO9GIkHAUOtPkx6KKkcxqpmd4uxHSPDdLdcNJMcX+rttaRwqIlJc/Q lmVkk8oAUWazRHlYuVZFckvqtYZ3yY8= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-596-Mk8oGEE5NiKu2jzgfkq3SA-1; Thu, 19 May 2022 15:51:32 -0400 X-MC-Unique: Mk8oGEE5NiKu2jzgfkq3SA-1 Received: by mail-qv1-f70.google.com with SMTP id n5-20020a0cbe85000000b0045aff56564bso5133266qvi.4 for ; Thu, 19 May 2022 12:51:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9KtfOhFFvee1eesMPm9hQavx4a8Q+z+7oJbUv+bY1R0=; b=liJZvlQs/5SwiKHJrK0rCrite8V8VCBaZkmCB6uMmUwRUrvk17QPPEeGlAbO0T+oaP tZe2NefStWCM760hYAZjCYrl00bT4Wegsz3JES35UCb3qrXdCqavVhDXERV1G43yz7dC uG9DSGBI8q6/Ne0nrqGm/RM7qh5+TzL2yLt9tM/BlcymDEisLf01zbGBG1TE7ecQ5lz2 V8PJeyamCsHvQ8a3mhUlnnaKn93cl8GqP2+o2zMc8okOtYuj7tX2VicLz/1ZYyV+054N DOABmbeY0dOmtnXqN2Td1sw7E+e149tfWd9A5LxIfYqw+KNEVFA6n4iE5xzs6r6Tjmwz TFJA== X-Gm-Message-State: AOAM531XP44nAo6r5nfgaV4s77EsQdpFnwfcOURxc4Pxdj6clG7jeFSD aVrRTOm7LHvNONHxMjHEia9fgdy2ltGd+clF2ziyI5gSqzvE4M9QHbbR5LT2MelFDKO104tRXtG JobA= X-Received: by 2002:a05:620a:573:b0:69f:cf74:720 with SMTP id p19-20020a05620a057300b0069fcf740720mr4176111qkp.683.1652989891556; Thu, 19 May 2022 12:51:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+p1A4ep7ZTm1TPlMGbRaTp7xitWJzGF6/GHM2W52FCck8jeaAf8q3sGCodkWH84URhy25ew== X-Received: by 2002:a05:620a:573:b0:69f:cf74:720 with SMTP id p19-20020a05620a057300b0069fcf740720mr4176095qkp.683.1652989891349; Thu, 19 May 2022 12:51:31 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id x65-20020a379544000000b0069fc13ce235sm1661766qkd.102.2022.05.19.12.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 12:51:30 -0700 (PDT) Subject: Re: [PATCH v3 0/4] drivers/baseband: PMD to support ACC101 device To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: thomas@monjalon.net, ray.kinsella@intel.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, hernan.vargas@intel.com, david.marchand@redhat.com References: <1651083423-33202-1-git-send-email-nicolas.chautru@intel.com> <1652734113-124047-1-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: <6c7f05e1-cd78-3072-a85c-9f877996cac1@redhat.com> Date: Thu, 19 May 2022 12:51:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1652734113-124047-1-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/16/22 1:48 PM, Nicolas Chautru wrote: > v3: Feedback from Tom Rix: missing copyright, refactor bbdev-test section calling > the configure companion function for ACC100/101, taking the Pmon commit out > which is not directly required. These address some of my comments. The others, mostly around the treating accXXX as a family of devices and refactoring the common parts out have not been. Tom > > v2: Based on good feedback from Thomas and David, > now implementing the ACC101 PMD as a close derivative from > existing ACC100 PMD with hooks to have different behaviour based on variant. > This prevents code duplication and only rely on different functions and behaviour > when hardware requires or support differences. > Note that these are pending changes for ACC100 which would be specific to > that device and not ACC101 but these can be managed based on the new > implementation, ie. is_acc100() etc... (such incremental changes for ACC100 > trending 22.11 but confirming this is future proof). > The serie also includes commits which were meant for ACC101 but are also > valuable for ACC100. > > v1: This serie introduces the PMD for the new bbdev device ACC101 (aka Mount Cirrus). > This is a derivative from previous Mount Bryce ACC100 which includes silicon > improvement, bug fixes, capacity improvement for 5GNR and feature improvement. > > Nicolas Chautru (4): > baseband/acc100: introduce PMD for ACC101 > baseband/acc100: modify validation code for ACC101 > baseband/acc100: configuration of ACC101 from PF > baseband/acc100: add protection for some negative scenario > > app/test-bbdev/test_bbdev_perf.c | 22 +- > doc/guides/bbdevs/acc101.rst | 237 ++++++++++++++ > doc/guides/bbdevs/features/acc101.ini | 13 + > doc/guides/bbdevs/index.rst | 1 + > doc/guides/rel_notes/release_22_07.rst | 4 + > drivers/baseband/acc100/rte_acc100_cfg.h | 17 + > drivers/baseband/acc100/rte_acc100_pmd.c | 542 ++++++++++++++++++++++++++++++- > drivers/baseband/acc100/rte_acc100_pmd.h | 6 + > drivers/baseband/acc100/rte_acc101_pmd.h | 65 ++++ > drivers/baseband/acc100/version.map | 2 +- > 10 files changed, 885 insertions(+), 24 deletions(-) > create mode 100644 doc/guides/bbdevs/acc101.rst > create mode 100644 doc/guides/bbdevs/features/acc101.ini > create mode 100644 drivers/baseband/acc100/rte_acc101_pmd.h >