From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]:36442 "EHLO lb3-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbdHQGqq (ORCPT ); Thu, 17 Aug 2017 02:46:46 -0400 Subject: Re: [PATCH 4/5] stih-cec: use CEC_CAP_DEFAULTS From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Benjamin Gaignard , Sylwester Nawrocki , Hans Verkuil References: <20170804104155.37386-1-hverkuil@xs4all.nl> <20170804104155.37386-5-hverkuil@xs4all.nl> Message-ID: <6c826abc-ea0a-3728-2946-52b72b3aad34@xs4all.nl> Date: Thu, 17 Aug 2017 08:46:41 +0200 MIME-Version: 1.0 In-Reply-To: <20170804104155.37386-5-hverkuil@xs4all.nl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Benjamin, Can you please review this patch and the stm32-cec patch? Thanks! Hans On 08/04/2017 12:41 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Use the new CEC_CAP_DEFAULTS define in this driver. > This also adds the CEC_CAP_RC capability which was missing here > (and this is also the reason for this new define, to avoid missing > such capabilities). > > Signed-off-by: Hans Verkuil > --- > drivers/media/platform/sti/cec/stih-cec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/sti/cec/stih-cec.c b/drivers/media/platform/sti/cec/stih-cec.c > index ce7964c71b50..dc221527fd05 100644 > --- a/drivers/media/platform/sti/cec/stih-cec.c > +++ b/drivers/media/platform/sti/cec/stih-cec.c > @@ -351,9 +351,7 @@ static int stih_cec_probe(struct platform_device *pdev) > } > > cec->adap = cec_allocate_adapter(&sti_cec_adap_ops, cec, > - CEC_NAME, > - CEC_CAP_LOG_ADDRS | CEC_CAP_PASSTHROUGH | > - CEC_CAP_TRANSMIT, CEC_MAX_LOG_ADDRS); > + CEC_NAME, CEC_CAP_DEFAULTS, CEC_MAX_LOG_ADDRS); > if (IS_ERR(cec->adap)) > return PTR_ERR(cec->adap); > >