From: Hans de Goede <hdegoede@redhat.com>
To: W_Armin@gmx.de
Cc: linux-hwmon@vger.kernel.org, linux@roeck-us.net, jdelvare@suse.com
Subject: Re: [PATCH v2 0/4] hwmon: (sch56xx) Use devres for watchdog and platform_device_register_simple()
Date: Sat, 8 May 2021 15:38:03 +0200 [thread overview]
Message-ID: <6c82d444-b0c4-f4e6-93b7-ef40dee1a1b5@redhat.com> (raw)
In-Reply-To: <20210508131457.12780-1-W_Armin@gmx.de>
Hi,
On 5/8/21 3:14 PM, W_Armin@gmx.de wrote:
> From: Armin Wolf <W_Armin@gmx.de>
>
> Since it was requested to use devres for the watchdog device,
> use devm_watchdog_register() for watchdog registration and do
> some small cleanups.
>
> Also use platform_device_register_simple() in sch56xx_device_add().
>
> Tested on a Fujitsu Esprimo P720.
>
> v2:
> - drop sch5627_remove()
> - make sch56xx_watchdog_register() return void
Thanks, series (still) looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
For the series.
Regards,
Hans
p.s.
For your next series when I give my Reviewed-by for v1 and
there are some small changes which require a v2, feel free to
add the Reviewed-by to the v2 series.
>
> Armin Wolf (4):
> hwmon: (sch56xx) Use devres functions for watchdog
> hwmon: (sch56xx-common) Use strscpy
> hwmon: (sch56xx-common) Use helper function
> hwmon: (sch56xx-common) Simplify sch56xx_device_add
>
> drivers/hwmon/sch5627.c | 18 ++--------
> drivers/hwmon/sch5636.c | 9 ++---
> drivers/hwmon/sch56xx-common.c | 65 ++++++++++------------------------
> drivers/hwmon/sch56xx-common.h | 4 +--
> 4 files changed, 25 insertions(+), 71 deletions(-)
>
> --
> 2.20.1
>
prev parent reply other threads:[~2021-05-08 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 13:14 [PATCH v2 0/4] hwmon: (sch56xx) Use devres for watchdog and platform_device_register_simple() W_Armin
2021-05-08 13:14 ` [PATCH v2 1/4] hwmon: (sch56xx) Use devres functions for watchdog W_Armin
2021-05-10 15:34 ` Guenter Roeck
2021-05-08 13:14 ` [PATCH v2 2/4] hwmon: (sch56xx-common) Use strscpy W_Armin
2021-05-10 15:35 ` Guenter Roeck
2021-05-08 13:14 ` [PATCH v2 3/4] hwmon: (sch56xx-common) Use helper function W_Armin
2021-05-10 15:36 ` Guenter Roeck
2021-05-08 13:14 ` [PATCH v2 4/4] hwmon: (sch56xx-common) Simplify sch56xx_device_add W_Armin
2021-05-10 15:36 ` Guenter Roeck
2021-05-08 13:38 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c82d444-b0c4-f4e6-93b7-ef40dee1a1b5@redhat.com \
--to=hdegoede@redhat.com \
--cc=W_Armin@gmx.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.