All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Lucas Stach <dev@lynxeye.de>
Subject: Re: [PATCH v5 2/3] ARM: dts: tegra: Fix unit_address_vs_reg and avoid_unnecessary_addr_size DTC warnings
Date: Thu, 17 May 2018 13:30:48 +0200	[thread overview]
Message-ID: <6c8e0e10662c29b49b45e37d031a712b@agner.ch> (raw)
In-Reply-To: <1526543103-21668-2-git-send-email-krzk@kernel.org>

On 17.05.2018 09:45, Krzysztof Kozlowski wrote:
> Remove unneeded address/size cells properties and unit addresses to fix
> DTC warnings like:
> 
>     arch/arm/boot/dts/tegra30-apalis-eval.dtb: Warning (unit_address_vs_reg):
>         /i2c@7000d000/stmpe811@41/stmpe_touchscreen@0: node has a unit
> name, but no reg property
>     arch/arm/boot/dts/tegra30-apalis-eval.dtb: Warning
> (avoid_unnecessary_addr_size):
>         /i2c@7000d000/stmpe811@41: unnecessary
> #address-cells/#size-cells without "ranges" or child "reg" property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Looks good!

Reviewed-by: Stefan Agner <stefan@agner.ch>

> 
> ---
> 
> Changes since v4:
> 1. None
> ---
>  arch/arm/boot/dts/tegra30-apalis.dtsi  | 4 +---
>  arch/arm/boot/dts/tegra30-beaver.dts   | 3 ---
>  arch/arm/boot/dts/tegra30-colibri.dtsi | 2 --
>  3 files changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi
> b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index 184f60c720fa..5038ca7b68af 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -590,8 +590,6 @@
>  		/* STMPE811 touch screen controller */
>  		stmpe811@41 {
>  			compatible = "st,stmpe811";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>  			reg = <0x41>;
>  			interrupts = <TEGRA_GPIO(V, 0) IRQ_TYPE_LEVEL_LOW>;
>  			interrupt-parent = <&gpio>;
> @@ -600,7 +598,7 @@
>  			blocks = <0x5>;
>  			irq-trigger = <0x1>;
>  
> -			stmpe_touchscreen@0 {
> +			stmpe_touchscreen {
>  				compatible = "st,stmpe-ts";
>  				/* 3.25 MHz ADC clock speed */
>  				st,adc-freq = <1>;
> diff --git a/arch/arm/boot/dts/tegra30-beaver.dts
> b/arch/arm/boot/dts/tegra30-beaver.dts
> index 72369877d284..961934f70639 100644
> --- a/arch/arm/boot/dts/tegra30-beaver.dts
> +++ b/arch/arm/boot/dts/tegra30-beaver.dts
> @@ -1791,9 +1791,6 @@
>  			vccio-supply = <&vdd_5v_in_reg>;
>  
>  			regulators {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -
>  				vdd1_reg: vdd1 {
>  					regulator-name = "vddio_ddr_1v2";
>  					regulator-min-microvolt = <1200000>;
> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi
> b/arch/arm/boot/dts/tegra30-colibri.dtsi
> index cc46cedf80b9..a593dc8be47f 100644
> --- a/arch/arm/boot/dts/tegra30-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
> @@ -352,8 +352,6 @@
>  		/* STMPE811 touch screen controller */
>  		stmpe811@41 {
>  			compatible = "st,stmpe811";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>  			reg = <0x41>;
>  			interrupts = <TEGRA_GPIO(V, 0) IRQ_TYPE_LEVEL_LOW>;
>  			interrupt-parent = <&gpio>;

  reply	other threads:[~2018-05-17 11:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17  7:45 [PATCH v5 1/3] ARM: dts: tegra: Remove skeleton.dtsi and fix DTC warnings for /memory Krzysztof Kozlowski
2018-05-17  7:45 ` [PATCH v5 2/3] ARM: dts: tegra: Fix unit_address_vs_reg and avoid_unnecessary_addr_size DTC warnings Krzysztof Kozlowski
2018-05-17 11:30   ` Stefan Agner [this message]
2018-05-17  7:45 ` [PATCH v5 3/3] ARM: dts: tegra: Work safely with 256 MB Colibri-T20 modules Krzysztof Kozlowski
2018-05-17 11:42   ` Stefan Agner
2018-05-17 11:39 ` [PATCH v5 1/3] ARM: dts: tegra: Remove skeleton.dtsi and fix DTC warnings for /memory Stefan Agner
2018-05-23  7:05   ` Krzysztof Kozlowski
2018-05-23  8:22     ` Stefan Agner
2018-05-23  8:34       ` Krzysztof Kozlowski
2018-05-23  8:57         ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c8e0e10662c29b49b45e37d031a712b@agner.ch \
    --to=stefan@agner.ch \
    --cc=dev@lynxeye.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.