All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	"Peer, Ilan" <ilan.peer@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Coelho, Luciano" <luciano.coelho@intel.com>
Subject: Re: pull-request: mac80211 2021-01-18.2
Date: Mon, 25 Jan 2021 12:18:41 +0100	[thread overview]
Message-ID: <6c949dbe-5593-2274-7099-c2768b770aad@redhat.com> (raw)
In-Reply-To: <666b3449fe33d34123255cc69da3aa46fc276dcb.camel@sipsolutions.net>

Hi,

On 1/25/21 10:47 AM, Johannes Berg wrote:
> Hi,
> 
> Sorry, apparently we have two threads.
> 
>> Great, thank you for looking into this. Let me know if you have a patch
>> which you want me to test on a RTL8723BS adapter.
> 
> Could you test this instead?
> 
> https://p.sipsolutions.net/235c352b8ae5db88.txt
> 
> 
> I don't have that much sympathy for a staging driver that's clearly
> doing things differently than it was intended (the documentation states
> that the function should be called only before wiphy_register(), not
> during ndo_open). :-)

I completely understand and I already was worried that this might be
a staging-driver issue, which is why I mentioned this was with a
staging driver in the more detailed bug-report email.

> But OTOH, that fix to the driver is simple and looks correct to me since
> it only ever has a static regdomain, and the notifier does the work of
> applying it to the channels as well.

So I've given your fix a quick try and it leads to a NULL pointer deref.

But now that you've given me a lead on how to fix this (network/wifi
drivers are not really me expertise) I can take a shot at seeing if I
can fix the NULL pointer deref. I Hope to get back to you on that later
today.

Regards,

Hans


  reply	other threads:[~2021-01-26 19:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 20:47 pull-request: mac80211 2021-01-18.2 Johannes Berg
2021-01-18 22:50 ` patchwork-bot+netdevbpf
2021-01-20 17:59   ` Johannes Berg
2021-01-20 20:37     ` Jakub Kicinski
2021-01-20 20:39       ` Johannes Berg
2021-01-23 21:31 ` Hans de Goede
2021-01-23 22:15   ` Johannes Berg
2021-01-24  9:12     ` Peer, Ilan
2021-01-24 10:54       ` Hans de Goede
2021-01-24 13:03         ` Peer, Ilan
2021-01-25  9:47         ` Johannes Berg
2021-01-25 11:18           ` Hans de Goede [this message]
2021-01-25 12:40             ` Johannes Berg
2021-01-25 12:59               ` Hans de Goede
2021-01-25 13:03                 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c949dbe-5593-2274-7099-c2768b770aad@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=ilan.peer@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.