From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B1AC433E9 for ; Fri, 26 Mar 2021 14:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C1F661A38 for ; Fri, 26 Mar 2021 14:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230186AbhCZOfR (ORCPT ); Fri, 26 Mar 2021 10:35:17 -0400 Received: from mx3.molgen.mpg.de ([141.14.17.11]:53575 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229779AbhCZOew (ORCPT ); Fri, 26 Mar 2021 10:34:52 -0400 Received: from [192.168.0.2] (ip5f5ae918.dynamic.kabel-deutschland.de [95.90.233.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 6C805206479D4; Fri, 26 Mar 2021 15:34:43 +0100 (CET) Subject: Re: Marvell: hw perfevents: unable to count PMU IRQs To: Robin Murphy , Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, LKML , Vadym Kochan , Oleksandr Mazur , Robert Marko References: From: Paul Menzel Message-ID: <6ca582cc-56ab-f481-d9e0-4e2b0b0d833e@molgen.mpg.de> Date: Fri, 26 Mar 2021 15:34:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Robin, Thank you for the quick reply. Am 26.03.21 um 13:29 schrieb Robin Murphy: > On 2021-03-25 21:39, Paul Menzel wrote: >> On the Marvell Prestera switch, Linux 5.10.4 prints the error (with an >> additional info level message) below. >> >>      [    0.000000] Linux version 5.10.4 (robimarko@onlbuilder9) (aarch64-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516, GNU ld (GNU Binutils for Debian) 2.28) #1 SMP PREEMPT Thu Mar 11 10:22:09 UTC 2021 >>      […] >>      [    1.996658] hw perfevents: unable to count PMU IRQs >>      [    2.001825] hw perfevents: /ap806/config-space@f0000000/pmu: failed to register PMU devices! […] >> Please find the output of `dmesg` attached. >> >> How can the IRQs be counted? > > Well, that message simply means we got an error back from > platform_irq_count(), which in turn implies that > platform_get_irq_optional() failed. Most likely we got -EPROBE_DEFER > back from of_irq_get() because the relevant interrupt controller wasn't > ready by that point - especially since that's the o9nly error code that > platform_irq_cont() will actually pass. It looks like that should end up > getting propagated all the way out appropriately, so the PMU driver > should defer and be able to probe OK once the mvebu-pic driver has > turned up to provide its IRQ. We could of course do a better job of not > shouting error messages for a non-fatal condition.... Yes, that would be great. > As for why the PMU doesn't eventually show up, my best guess would be > either an issue with the mvebu-pic driver itself probing, and/or perhaps > something in fw_devlink going awry - inspecting sysfs should shed a bit > more light on those. I just noticed, I missed [ 3.298670] hw perfevents: enabled with armv8_cortex_a72 PMU driver, 7 counters available a good second. So the interrupt controller indeed seems to take longer to be ready. I guess, I’d need to boot with `initcall_debug` to find out the callers of the PMU functions. Kind regards, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8394C433E0 for ; Fri, 26 Mar 2021 14:37:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4242961A24 for ; Fri, 26 Mar 2021 14:37:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4242961A24 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IwUroKkAR9bBYZIH+FF/6bxvdKHlGUy/IR5PvFzMIFE=; b=LLtCxUGYjUGQD9CSiiTCtJ55T kTm7WTpux44kcyE7NAz2lLqufbFW7EUGOPc38AesEN9FRocKoonOGXXQK5P2nGfLuqz3tOSUlvk9I sugf8xoK9+DSbJzEqjEs/keS3MBRld3BX+EJwbKtqsYa3GgxwiWWiB2I7wGkDbzeKXe0ovOPuWzJM xbyiGSwWE3LXnz4zW/6Cso8tmXBgTjLplzIl+cYk3/0BS0zdbfeUeJ7Qle91qRFJgXsEyr2e4IpDY 9z4FxKXMYqit8BVpmgao4dgMi1/wh1kD8trkMcDM/TL8Gnxu0gORx4TgaNqBjnY0/E5ZpFAH52pwj GCo+Xw9/w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPnY0-003n7F-VO; Fri, 26 Mar 2021 14:34:49 +0000 Received: from mx3.molgen.mpg.de ([141.14.17.11] helo=mx1.molgen.mpg.de) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPnXw-003n69-J2 for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 14:34:46 +0000 Received: from [192.168.0.2] (ip5f5ae918.dynamic.kabel-deutschland.de [95.90.233.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 6C805206479D4; Fri, 26 Mar 2021 15:34:43 +0100 (CET) Subject: Re: Marvell: hw perfevents: unable to count PMU IRQs To: Robin Murphy , Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, LKML , Vadym Kochan , Oleksandr Mazur , Robert Marko References: From: Paul Menzel Message-ID: <6ca582cc-56ab-f481-d9e0-4e2b0b0d833e@molgen.mpg.de> Date: Fri, 26 Mar 2021 15:34:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_143444_717436_38239D7B X-CRM114-Status: GOOD ( 23.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RGVhciBSb2JpbiwKCgpUaGFuayB5b3UgZm9yIHRoZSBxdWljayByZXBseS4KCkFtIDI2LjAzLjIx IHVtIDEzOjI5IHNjaHJpZWIgUm9iaW4gTXVycGh5Ogo+IE9uIDIwMjEtMDMtMjUgMjE6MzksIFBh dWwgTWVuemVsIHdyb3RlOgoKPj4gT24gdGhlIE1hcnZlbGwgUHJlc3RlcmEgc3dpdGNoLCBMaW51 eCA1LjEwLjQgcHJpbnRzIHRoZSBlcnJvciAod2l0aCBhbiAKPj4gYWRkaXRpb25hbCBpbmZvIGxl dmVsIG1lc3NhZ2UpIGJlbG93Lgo+Pgo+PiDCoMKgwqDCoCBbwqDCoMKgIDAuMDAwMDAwXSBMaW51 eCB2ZXJzaW9uIDUuMTAuNCAocm9iaW1hcmtvQG9ubGJ1aWxkZXI5KSAoYWFyY2g2NC1saW51eC1n bnUtZ2NjIChEZWJpYW4gNi4zLjAtMTgpIDYuMy4wIDIwMTcwNTE2LCBHTlUgbGQgKEdOVSBCaW51 dGlscyBmb3IgRGViaWFuKSAyLjI4KSAjMSBTTVAgUFJFRU1QVCBUaHUgTWFyIDExIDEwOjIyOjA5 IFVUQyAyMDIxCj4+IMKgwqDCoMKgIFvigKZdCj4+IMKgwqDCoMKgIFvCoMKgwqAgMS45OTY2NThd IGh3IHBlcmZldmVudHM6IHVuYWJsZSB0byBjb3VudCBQTVUgSVJRcwo+PiDCoMKgwqDCoCBbwqDC oMKgIDIuMDAxODI1XSBodyBwZXJmZXZlbnRzOiAvYXA4MDYvY29uZmlnLXNwYWNlQGYwMDAwMDAw L3BtdTogZmFpbGVkIHRvIHJlZ2lzdGVyIFBNVSBkZXZpY2VzIQoKW+KApl0KCj4+IFBsZWFzZSBm aW5kIHRoZSBvdXRwdXQgb2YgYGRtZXNnYCBhdHRhY2hlZC4KPj4KPj4gSG93IGNhbiB0aGUgSVJR cyBiZSBjb3VudGVkPwo+IAo+IFdlbGwsIHRoYXQgbWVzc2FnZSBzaW1wbHkgbWVhbnMgd2UgZ290 IGFuIGVycm9yIGJhY2sgZnJvbSAKPiBwbGF0Zm9ybV9pcnFfY291bnQoKSwgd2hpY2ggaW4gdHVy biBpbXBsaWVzIHRoYXQgCj4gcGxhdGZvcm1fZ2V0X2lycV9vcHRpb25hbCgpIGZhaWxlZC4gTW9z dCBsaWtlbHkgd2UgZ290IC1FUFJPQkVfREVGRVIgCj4gYmFjayBmcm9tIG9mX2lycV9nZXQoKSBi ZWNhdXNlIHRoZSByZWxldmFudCBpbnRlcnJ1cHQgY29udHJvbGxlciB3YXNuJ3QgCj4gcmVhZHkg YnkgdGhhdCBwb2ludCAtIGVzcGVjaWFsbHkgc2luY2UgdGhhdCdzIHRoZSBvOW5seSBlcnJvciBj b2RlIHRoYXQgCj4gcGxhdGZvcm1faXJxX2NvbnQoKSB3aWxsIGFjdHVhbGx5IHBhc3MuIEl0IGxv b2tzIGxpa2UgdGhhdCBzaG91bGQgZW5kIHVwIAo+IGdldHRpbmcgcHJvcGFnYXRlZCBhbGwgdGhl IHdheSBvdXQgYXBwcm9wcmlhdGVseSwgc28gdGhlIFBNVSBkcml2ZXIgCj4gc2hvdWxkIGRlZmVy IGFuZCBiZSBhYmxlIHRvIHByb2JlIE9LIG9uY2UgdGhlIG12ZWJ1LXBpYyBkcml2ZXIgaGFzIAo+ IHR1cm5lZCB1cCB0byBwcm92aWRlIGl0cyBJUlEuIFdlIGNvdWxkIG9mIGNvdXJzZSBkbyBhIGJl dHRlciBqb2Igb2Ygbm90IAo+IHNob3V0aW5nIGVycm9yIG1lc3NhZ2VzIGZvciBhIG5vbi1mYXRh bCBjb25kaXRpb24uLi4uCgpZZXMsIHRoYXQgd291bGQgYmUgZ3JlYXQuCgo+IEFzIGZvciB3aHkg dGhlIFBNVSBkb2Vzbid0IGV2ZW50dWFsbHkgc2hvdyB1cCwgbXkgYmVzdCBndWVzcyB3b3VsZCBi ZSAKPiBlaXRoZXIgYW4gaXNzdWUgd2l0aCB0aGUgbXZlYnUtcGljIGRyaXZlciBpdHNlbGYgcHJv YmluZywgYW5kL29yIHBlcmhhcHMgCj4gc29tZXRoaW5nIGluIGZ3X2RldmxpbmsgZ29pbmcgYXdy eSAtIGluc3BlY3Rpbmcgc3lzZnMgc2hvdWxkIHNoZWQgYSBiaXQgCj4gbW9yZSBsaWdodCBvbiB0 aG9zZS4KCkkganVzdCBub3RpY2VkLCBJIG1pc3NlZAoKICAgICBbICAgIDMuMjk4NjcwXSBodyBw ZXJmZXZlbnRzOiBlbmFibGVkIHdpdGggYXJtdjhfY29ydGV4X2E3MiBQTVUgCmRyaXZlciwgNyBj b3VudGVycyBhdmFpbGFibGUKCmEgZ29vZCBzZWNvbmQuIFNvIHRoZSBpbnRlcnJ1cHQgY29udHJv bGxlciBpbmRlZWQgc2VlbXMgdG8gdGFrZSBsb25nZXIgCnRvIGJlIHJlYWR5LgoKSSBndWVzcywg SeKAmWQgbmVlZCB0byBib290IHdpdGggYGluaXRjYWxsX2RlYnVnYCB0byBmaW5kIG91dCB0aGUg Y2FsbGVycyAKb2YgdGhlIFBNVSBmdW5jdGlvbnMuCgoKS2luZCByZWdhcmRzLAoKUGF1bAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=