From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbdLAIOl (ORCPT ); Fri, 1 Dec 2017 03:14:41 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:54843 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750964AbdLAIOi (ORCPT ); Fri, 1 Dec 2017 03:14:38 -0500 Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string To: Sebastian Reichel , Tony Lindgren CC: "H. Nikolaus Schaller" , Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Russell King , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , , DTML , Linux Kernel Mailing List , linux-omap , Linux ARM , , Discussions about the Letux Kernel , References: <20171128160437.GD28152@atomide.com> <20171128161834.GE28152@atomide.com> <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> <20171130152430.GM28152@atomide.com> <20171130220633.imkfyeiqtftnw4j4@earth> From: Tomi Valkeinen Message-ID: <6ca5f2ea-e725-9a9e-ac02-e16beca4a1a0@ti.com> Date: Fri, 1 Dec 2017 10:13:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171130220633.imkfyeiqtftnw4j4@earth> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/17 00:06, Sebastian Reichel wrote: >>>> How about let's call it a "typo fix" then? :) >>> >>> Well, it is not really a typo. >> >> Well what if the stable people pick it into earlier stable series >> based on the word fix in the subject? That has happened before. >> >> I suggest you update the dts patches to use wording like >> "update compatible to use new naming" or something similar. > > Patch 4/4 is a Fix and should be applied to stable trees. "omapdss," > prefix was never supposed to be in the DTS files, is not supposed to > be in there now and will break some time in the future. > > Explanation: The early init of omapdss adds the prefix at runtime, > so that the binding can use generic properties and the kernel can > use omapdss specific drivers until the generic ones can be used This is true, but the extra "omapdss" does not cause any issues at the moment, and the time when it causes issues is still many kernel versions in the future. But, yes, thinking about this, I agree, it's better to pick this one separately as a fix (after rebasing it on top of current maineline so that it doesn't depend on the toppoly name change), and leaving the toppoly->tpo change as a cleanup. -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string Date: Fri, 1 Dec 2017 10:13:24 +0200 Message-ID: <6ca5f2ea-e725-9a9e-ac02-e16beca4a1a0@ti.com> References: <20171128160437.GD28152@atomide.com> <20171128161834.GE28152@atomide.com> <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> <20171130152430.GM28152@atomide.com> <20171130220633.imkfyeiqtftnw4j4@earth> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171130220633.imkfyeiqtftnw4j4@earth> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sebastian Reichel , Tony Lindgren Cc: Mark Rutland , DTML , linux-fbdev@vger.kernel.org, Discussions about the Letux Kernel , Bartlomiej Zolnierkiewicz , David Airlie , "H. Nikolaus Schaller" , dri-devel@lists.freedesktop.org, Russell King , Rob Herring , Linux Kernel Mailing List , Julia Lawall , Thierry Reding , Laurent Pinchart , =?UTF-8?Q?Beno=c3=aet_Cousson?= , kernel@pyra-handheld.com, linux-omap , Linux ARM List-Id: devicetree@vger.kernel.org T24gMDEvMTIvMTcgMDA6MDYsIFNlYmFzdGlhbiBSZWljaGVsIHdyb3RlOgoKPj4+PiBIb3cgYWJv dXQgbGV0J3MgY2FsbCBpdCBhICJ0eXBvIGZpeCIgdGhlbj8gOikKPj4+Cj4+PiBXZWxsLCBpdCBp cyBub3QgcmVhbGx5IGEgdHlwby4KPj4KPj4gV2VsbCB3aGF0IGlmIHRoZSBzdGFibGUgcGVvcGxl IHBpY2sgaXQgaW50byBlYXJsaWVyIHN0YWJsZSBzZXJpZXMKPj4gYmFzZWQgb24gdGhlIHdvcmQg Zml4IGluIHRoZSBzdWJqZWN0PyBUaGF0IGhhcyBoYXBwZW5lZCBiZWZvcmUuCj4+Cj4+IEkgc3Vn Z2VzdCB5b3UgdXBkYXRlIHRoZSBkdHMgcGF0Y2hlcyB0byB1c2Ugd29yZGluZyBsaWtlCj4+ICJ1 cGRhdGUgY29tcGF0aWJsZSB0byB1c2UgbmV3IG5hbWluZyIgb3Igc29tZXRoaW5nIHNpbWlsYXIu Cj4gCj4gUGF0Y2ggNC80IGlzIGEgRml4IGFuZCBzaG91bGQgYmUgYXBwbGllZCB0byBzdGFibGUg dHJlZXMuICJvbWFwZHNzLCIKPiBwcmVmaXggd2FzIG5ldmVyIHN1cHBvc2VkIHRvIGJlIGluIHRo ZSBEVFMgZmlsZXMsIGlzIG5vdCBzdXBwb3NlZCB0bwo+IGJlIGluIHRoZXJlIG5vdyBhbmQgd2ls bCBicmVhayBzb21lIHRpbWUgaW4gdGhlIGZ1dHVyZS4KPiAKPiBFeHBsYW5hdGlvbjogVGhlIGVh cmx5IGluaXQgb2Ygb21hcGRzcyBhZGRzIHRoZSBwcmVmaXggYXQgcnVudGltZSwKPiBzbyB0aGF0 IHRoZSBiaW5kaW5nIGNhbiB1c2UgZ2VuZXJpYyBwcm9wZXJ0aWVzIGFuZCB0aGUga2VybmVsIGNh bgo+IHVzZSBvbWFwZHNzIHNwZWNpZmljIGRyaXZlcnMgdW50aWwgdGhlIGdlbmVyaWMgb25lcyBj YW4gYmUgdXNlZAoKVGhpcyBpcyB0cnVlLCBidXQgdGhlIGV4dHJhICJvbWFwZHNzIiBkb2VzIG5v dCBjYXVzZSBhbnkgaXNzdWVzIGF0IHRoZQptb21lbnQsIGFuZCB0aGUgdGltZSB3aGVuIGl0IGNh dXNlcyBpc3N1ZXMgaXMgc3RpbGwgbWFueSBrZXJuZWwgdmVyc2lvbnMKaW4gdGhlIGZ1dHVyZS4K CkJ1dCwgeWVzLCB0aGlua2luZyBhYm91dCB0aGlzLCBJIGFncmVlLCBpdCdzIGJldHRlciB0byBw aWNrIHRoaXMgb25lCnNlcGFyYXRlbHkgYXMgYSBmaXggKGFmdGVyIHJlYmFzaW5nIGl0IG9uIHRv cCBvZiBjdXJyZW50IG1haW5lbGluZSBzbwp0aGF0IGl0IGRvZXNuJ3QgZGVwZW5kIG9uIHRoZSB0 b3Bwb2x5IG5hbWUgY2hhbmdlKSwgYW5kIGxlYXZpbmcgdGhlCnRvcHBvbHktPnRwbyBjaGFuZ2Ug YXMgYSBjbGVhbnVwLgoKLS0gClRleGFzIEluc3RydW1lbnRzIEZpbmxhbmQgT3ksIFBvcmtrYWxh bmthdHUgMjIsIDAwMTgwIEhlbHNpbmtpLgpZLXR1bm51cy9CdXNpbmVzcyBJRDogMDYxNTUyMS00 LiBLb3RpcGFpa2thL0RvbWljaWxlOiBIZWxzaW5raQpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Fri, 01 Dec 2017 08:13:24 +0000 Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string Message-Id: <6ca5f2ea-e725-9a9e-ac02-e16beca4a1a0@ti.com> List-Id: References: <20171128160437.GD28152@atomide.com> <20171128161834.GE28152@atomide.com> <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> <20171130152430.GM28152@atomide.com> <20171130220633.imkfyeiqtftnw4j4@earth> In-Reply-To: <20171130220633.imkfyeiqtftnw4j4@earth> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sebastian Reichel , Tony Lindgren Cc: Mark Rutland , DTML , linux-fbdev@vger.kernel.org, Discussions about the Letux Kernel , Bartlomiej Zolnierkiewicz , David Airlie , "H. Nikolaus Schaller" , dri-devel@lists.freedesktop.org, Russell King , Rob Herring , Linux Kernel Mailing List , Julia Lawall , Thierry Reding , Laurent Pinchart , =?UTF-8?Q?Beno=c3=aet_Cousson?= , kernel@pyra-handheld.com, linux-omap , Linux ARM On 01/12/17 00:06, Sebastian Reichel wrote: >>>> How about let's call it a "typo fix" then? :) >>> >>> Well, it is not really a typo. >> >> Well what if the stable people pick it into earlier stable series >> based on the word fix in the subject? That has happened before. >> >> I suggest you update the dts patches to use wording like >> "update compatible to use new naming" or something similar. > > Patch 4/4 is a Fix and should be applied to stable trees. "omapdss," > prefix was never supposed to be in the DTS files, is not supposed to > be in there now and will break some time in the future. > > Explanation: The early init of omapdss adds the prefix at runtime, > so that the binding can use generic properties and the kernel can > use omapdss specific drivers until the generic ones can be used This is true, but the extra "omapdss" does not cause any issues at the moment, and the time when it causes issues is still many kernel versions in the future. But, yes, thinking about this, I agree, it's better to pick this one separately as a fix (after rebasing it on top of current maineline so that it doesn't depend on the toppoly name change), and leaving the toppoly->tpo change as a cleanup. -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomi.valkeinen@ti.com (Tomi Valkeinen) Date: Fri, 1 Dec 2017 10:13:24 +0200 Subject: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string In-Reply-To: <20171130220633.imkfyeiqtftnw4j4@earth> References: <20171128160437.GD28152@atomide.com> <20171128161834.GE28152@atomide.com> <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> <20171130152430.GM28152@atomide.com> <20171130220633.imkfyeiqtftnw4j4@earth> Message-ID: <6ca5f2ea-e725-9a9e-ac02-e16beca4a1a0@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/12/17 00:06, Sebastian Reichel wrote: >>>> How about let's call it a "typo fix" then? :) >>> >>> Well, it is not really a typo. >> >> Well what if the stable people pick it into earlier stable series >> based on the word fix in the subject? That has happened before. >> >> I suggest you update the dts patches to use wording like >> "update compatible to use new naming" or something similar. > > Patch 4/4 is a Fix and should be applied to stable trees. "omapdss," > prefix was never supposed to be in the DTS files, is not supposed to > be in there now and will break some time in the future. > > Explanation: The early init of omapdss adds the prefix at runtime, > so that the binding can use generic properties and the kernel can > use omapdss specific drivers until the generic ones can be used This is true, but the extra "omapdss" does not cause any issues at the moment, and the time when it causes issues is still many kernel versions in the future. But, yes, thinking about this, I agree, it's better to pick this one separately as a fix (after rebasing it on top of current maineline so that it doesn't depend on the toppoly name change), and leaving the toppoly->tpo change as a cleanup. -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki