From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] util-linux: Use PCRE for hardlink
Date: Wed, 04 Dec 2019 20:18:15 +0000 [thread overview]
Message-ID: <6cada1f180fe4bad594d71033573ff9fba3a30e9.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAMKF1sp29T-e0=5BBoX_=ZtUEs7fh3qAU9P__dXQH6NxCL+6hw@mail.gmail.com>
On Wed, 2019-12-04 at 12:12 -0800, Khem Raj wrote:
> On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:
> > > Use PCRE, this enables using posix extended Regexps on cmdline
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > > meta/recipes-core/util-linux/util-linux.inc | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-core/util-linux/util-linux.inc
> > > b/meta/recipes-core/util-linux/util-linux.inc
> > > index 1fa82363b1..8f867aa9b4 100644
> > > --- a/meta/recipes-core/util-linux/util-linux.inc
> > > +++ b/meta/recipes-core/util-linux/util-linux.inc
> > > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "
> > > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099
> > >
> > > #gtk-doc is not enabled as it requires xmlto which requires
> > > util-
> > > linux
> > > inherit autotools gettext manpages pkgconfig systemd update-
> > > alternatives python3-dir bash-completion ptest
> > > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"
> > > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"
> > >
> > > MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
> > > SRC_URI =
> > > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.t
> > > ar.x
> > > z \
> >
> > Given it works today without that, shouldn't it be a PACKAGECONFIG?
>
> its default with other main linux distros. I thought since what we
> were doing was not
> default, I did not see a need for packageconfig. I can certain do a
> v2 with packageconfig and enabling it by default, is that better ?
We're embedded so we're supposed to expose this kind of config and tend
to the more minimal ;-)
Cheers,
Richard
next prev parent reply other threads:[~2019-12-04 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 19:32 [PATCH] util-linux: Use PCRE for hardlink Khem Raj
2019-12-04 20:00 ` Richard Purdie
2019-12-04 20:12 ` Khem Raj
2019-12-04 20:18 ` Richard Purdie [this message]
2019-12-04 20:21 ` Khem Raj
2019-12-04 20:22 ` Richard Purdie
2019-12-04 20:25 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cada1f180fe4bad594d71033573ff9fba3a30e9.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.