From: Richard Henderson <rth@twiddle.net>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32
Date: Mon, 11 Sep 2017 21:17:39 -0700 [thread overview]
Message-ID: <6caf4eee-33e6-1022-a05a-23257ecf596f@twiddle.net> (raw)
In-Reply-To: <20170911204936.5020-1-f4bug@amsat.org>
On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote:
> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c):
>
> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target':
> qemu/include/qemu/compiler.h:86:30: error: static assertion failed: "not expecting: sizeof(*(uint64_t *)jmp_addr) > ATOMIC_REG_SIZE"
> QEMU_BUILD_BUG_ON(sizeof(*ptr) > ATOMIC_REG_SIZE); \
> ^
> qemu/tcg/ppc/tcg-target.inc.c:1377:9: note: in expansion of macro 'atomic_set'
> atomic_set((uint64_t *)jmp_addr, pair);
> ^
>
> Suggested-by: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> This fixes Shippable builds, see:
> https://app.shippable.com/github/qemu/qemu/runs/434/10/console
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2017-09-12 4:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 20:49 [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32 Philippe Mathieu-Daudé
2017-09-11 21:37 ` Peter Maydell
2017-09-12 4:23 ` Richard Henderson
2017-09-12 9:08 ` Peter Maydell
2017-09-12 21:04 ` Paolo Bonzini
2017-09-13 16:45 ` Richard Henderson
2017-09-12 4:17 ` Richard Henderson [this message]
2017-09-12 17:01 ` Richard Henderson
2017-09-12 21:00 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6caf4eee-33e6-1022-a05a-23257ecf596f@twiddle.net \
--to=rth@twiddle.net \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.