All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hongxu Jia <hongxu.jia@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH 1/1] python: fix importing readline with probably escape sequence output
Date: Thu, 18 Jul 2013 18:55:00 +0800	[thread overview]
Message-ID: <6cb2efa600f580748a228b8e8577479c76140368.1374140808.git.hongxu.jia@windriver.com> (raw)
In-Reply-To: <cover.1374140808.git.hongxu.jia@windriver.com>

While imports readline in python, if the term in terminfo is available and
it contains the variable 'km' and 'smm', the readline initialization will
output the value of 'smm' which is the escape sequence '\E[?1034h'.

'km' means the terminal has a meta key which is a special key on MIT keyboards,
'smm' means turn on the meta key if this terminal has one. They don't exist in
term 'dumb'.

Explicitly use dumb as default terminal to avoid probably escape sequence
output. The dumb is used to label tty lines when you don't know what kind
of terminal is on it. The characteristics of an unknown terminal are the
lowest common denominator.

[YOCTO #4835]
[YOCTO #4732]

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-devtools/python/python.inc            |  4 ++-
 ...e-explicitly-use-dumb-as-default-terminal.patch | 35 ++++++++++++++++++++++
 2 files changed, 38 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/python/python/readline-explicitly-use-dumb-as-default-terminal.patch

diff --git a/meta/recipes-devtools/python/python.inc b/meta/recipes-devtools/python/python.inc
index 80609a8..2fc894d 100644
--- a/meta/recipes-devtools/python/python.inc
+++ b/meta/recipes-devtools/python/python.inc
@@ -7,7 +7,9 @@ INC_PR = "r0"
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=ed3abfd1059e2d3a36a8cff3986f9bb6"
 
-SRC_URI = "http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.bz2"
+SRC_URI = "http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.bz2 \
+           file://readline-explicitly-use-dumb-as-default-terminal.patch \
+"
  
 SRC_URI[md5sum] = "c57477edd6d18bd9eeca2f21add73919"
 SRC_URI[sha256sum] = "726457e11cb153adc3f428aaf1901fc561a374c30e5e7da6742c0742a338663c"
diff --git a/meta/recipes-devtools/python/python/readline-explicitly-use-dumb-as-default-terminal.patch b/meta/recipes-devtools/python/python/readline-explicitly-use-dumb-as-default-terminal.patch
new file mode 100644
index 0000000..11928d1
--- /dev/null
+++ b/meta/recipes-devtools/python/python/readline-explicitly-use-dumb-as-default-terminal.patch
@@ -0,0 +1,35 @@
+readline: explicitly use dumb as default terminal
+
+Explicitly use dumb as default terminal to avoid probably
+escape sequence output. The dumb is used to label tty lines
+when you don't know what kind of terminal is on it. The
+characteristics of an unknown terminal are the lowest common
+denominator.
+
+Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
+Upstream-Status: inappropriate [oe specific] 
+---
+ Modules/readline.c | 8 ++++++++
+ 1 file changed, 8 insertions(+)
+
+diff --git a/Modules/readline.c b/Modules/readline.c
+--- a/Modules/readline.c
++++ b/Modules/readline.c
+@@ -882,6 +882,14 @@ setup_readline(void)
+ #endif
+     /* Force rebind of TAB to insert-tab */
+     rl_bind_key('\t', rl_insert);
++
++    /* Explicitly use dumb as default terminal to avoid probably
++     * escape sequence output. The dumb is used to label tty lines
++     * when you don't know what kind of terminal is on it. The
++     * characteristics of an unknown terminal are the lowest common
++     * denominator.
++     */
++    rl_terminal_name = "dumb";
+     /* Bind both ESC-TAB and ESC-ESC to the completion function */
+     rl_bind_key_in_map ('\t', rl_complete, emacs_meta_keymap);
+     rl_bind_key_in_map ('\033', rl_complete, emacs_meta_keymap);
+-- 
+1.8.1.2
+
-- 
1.8.1.2



  reply	other threads:[~2013-07-18 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 10:54 [PATCH 0/1] python: fix importing readline with probably escape sequence output Hongxu Jia
2013-07-18 10:55 ` Hongxu Jia [this message]
2013-07-18 16:36   ` [PATCH 1/1] " Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cb2efa600f580748a228b8e8577479c76140368.1374140808.git.hongxu.jia@windriver.com \
    --to=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.