From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0F73C48BE6 for ; Wed, 16 Jun 2021 09:28:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B50B61359 for ; Wed, 16 Jun 2021 09:28:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231707AbhFPJaW (ORCPT ); Wed, 16 Jun 2021 05:30:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42041 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231686AbhFPJaV (ORCPT ); Wed, 16 Jun 2021 05:30:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623835695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2zVitNKk74Er4xjOzMcHQzU2fhoa7EV3XbSfyR7Byfw=; b=G0qunneyXER2yr+bU90+6ycD5nEOMQEO50zFWGE2ktuC0Y5ikY0AZhqLqJ7rGWfkUkSkeU wXgP74KHQ56KlMvQNRQOMke6ru10m6QRxSXM5GguI5vA9mfMSR5RXKxHD1h0rJ2Qa0h2se OsSpvNzbhdLKxhk+L9KF7PMTDjDuCEE= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-168-SUECgynSOGq_1pprq60dJA-1; Wed, 16 Jun 2021 05:28:13 -0400 X-MC-Unique: SUECgynSOGq_1pprq60dJA-1 Received: by mail-pj1-f70.google.com with SMTP id on11-20020a17090b1d0bb029016bba777f5fso1457673pjb.7 for ; Wed, 16 Jun 2021 02:28:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2zVitNKk74Er4xjOzMcHQzU2fhoa7EV3XbSfyR7Byfw=; b=FzcYWNvgAuICt9TLblMKCvx9J0tceZ0OkciJdOixBRKMwVW6s8fbKoshMYzoRcdYHI GvFW1iEAydX09vRBUPPXAtW5/Zgs7S5FOH4FfSmt3S3gZHIPQcyY7rZl5LCSf6IfNW7y Leopz+VfhdJrgEFWJ9Q726YN6U3KUeB6q6MW4615j7ED14SM8w+JeEfto222KMFQXH1C W5AtImkI4h/k1FLddUbdFmuGFCvQKs0ugUrfKQ6acNUxZJgnwMsLE4ImvRdGpBbmw8O/ 3ssV8lU+IVOQ08Q3fYWk4dvAp7hkMm/nnvQK6HQ/BG8leag4tWJJCpzV875CJwEpBuqa 5JKA== X-Gm-Message-State: AOAM530zYxhotskt+TtxT4dkyCWaOVWoE0ZxYDAw6Dv0F3is7dGJJN2U cl4v9V1ABvlLix210KfWXZGtIBq22WuyIcoo+WNnXysh0yjHyaidZNgq3a4Y4OrA+EdpGnyrYXi 5t7T4vPhQIVZu X-Received: by 2002:a63:6644:: with SMTP id a65mr3966408pgc.431.1623835692229; Wed, 16 Jun 2021 02:28:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxP1r2/tnSACBUqAVJSZsvh4f2v25ZAQ1BpTYQ8qzqXogVVtOU0xvIAm37d5R4P1bneZXCn0Q== X-Received: by 2002:a63:6644:: with SMTP id a65mr3966377pgc.431.1623835692066; Wed, 16 Jun 2021 02:28:12 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id d22sm1679372pgb.15.2021.06.16.02.28.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 02:28:11 -0700 (PDT) Subject: Re: [PATCH net-next v5 03/15] virtio-net: add priv_flags IFF_NOT_USE_DMA_ADDR To: Xuan Zhuo , netdev@vger.kernel.org Cc: "David S. Miller" , Jakub Kicinski , "Michael S. Tsirkin" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , virtualization@lists.linux-foundation.org, bpf@vger.kernel.org, "dust . li" References: <20210610082209.91487-1-xuanzhuo@linux.alibaba.com> <20210610082209.91487-4-xuanzhuo@linux.alibaba.com> From: Jason Wang Message-ID: <6cbab579-93a7-27db-9b8f-0f94f1b20b13@redhat.com> Date: Wed, 16 Jun 2021 17:27:59 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210610082209.91487-4-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org ÔÚ 2021/6/10 ÏÂÎç4:21, Xuan Zhuo дµÀ: > virtio-net not use dma addr directly. So add this priv_flags > IFF_NOT_USE_DMA_ADDR. > > Signed-off-by: Xuan Zhuo > --- > drivers/net/virtio_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 0416a7e00914..6c1233f0ab3e 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -3064,7 +3064,7 @@ static int virtnet_probe(struct virtio_device *vdev) > > /* Set up network device as normal. */ > dev->priv_flags |= IFF_UNICAST_FLT | IFF_LIVE_ADDR_CHANGE | > - IFF_TX_SKB_NO_LINEAR; > + IFF_TX_SKB_NO_LINEAR | IFF_NOT_USE_DMA_ADDR; I wonder instead of doing trick like this, how about teach the virtio core to accept DMA address via sg? Thanks > dev->netdev_ops = &virtnet_netdev; > dev->features = NETIF_F_HIGHDMA; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6BCDC48BE8 for ; Wed, 16 Jun 2021 09:28:21 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86E0761351 for ; Wed, 16 Jun 2021 09:28:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86E0761351 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4FC8A838E6; Wed, 16 Jun 2021 09:28:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h6U4lnyQsJfe; Wed, 16 Jun 2021 09:28:20 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id E85A183268; Wed, 16 Jun 2021 09:28:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9DA68C000D; Wed, 16 Jun 2021 09:28:19 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id C5B43C000B for ; Wed, 16 Jun 2021 09:28:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BFF254067A for ; Wed, 16 Jun 2021 09:28:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id USHL_dwKGEYo for ; Wed, 16 Jun 2021 09:28:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id D70674065B for ; Wed, 16 Jun 2021 09:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623835695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2zVitNKk74Er4xjOzMcHQzU2fhoa7EV3XbSfyR7Byfw=; b=G0qunneyXER2yr+bU90+6ycD5nEOMQEO50zFWGE2ktuC0Y5ikY0AZhqLqJ7rGWfkUkSkeU wXgP74KHQ56KlMvQNRQOMke6ru10m6QRxSXM5GguI5vA9mfMSR5RXKxHD1h0rJ2Qa0h2se OsSpvNzbhdLKxhk+L9KF7PMTDjDuCEE= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-484-dU1TJVkCNxS3keHcv3xA3w-1; Wed, 16 Jun 2021 05:28:13 -0400 X-MC-Unique: dU1TJVkCNxS3keHcv3xA3w-1 Received: by mail-pf1-f200.google.com with SMTP id g22-20020a056a000796b02902f0483fd9e4so1250077pfu.10 for ; Wed, 16 Jun 2021 02:28:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2zVitNKk74Er4xjOzMcHQzU2fhoa7EV3XbSfyR7Byfw=; b=BUU9vGNJdIj/OlftovhzQGoRu7Jn+CEQP/Nnvr5ghkTuLuq2ZobIVkIOtX8QKIm3Du w7DvdDOfEe1qPwdZqG89yg/PVGQ+hJ+yxjVSLQU+wT59/7T95xl1Dz7ZOLumIBmDD1M4 kPQwwAHxMUKUu4MSh1AyR6wGu/JgKyuTz689O4IHwn5PbRJBXwuJSKVFhfiFstzAVJTw X3AEUULMfxTQG7h5cePKJof5syrsiLx4eaKypIvyCNDvCwVRbRuM05SgYZdHo2gDFlTk 4GqG5H5z7hV99g2/AsP+NiiovP7jaSkpaPK+n81VFhaTlTxdCwHkCr1ev9cFMxes6xjN gyHA== X-Gm-Message-State: AOAM530s2HADexebo/WCDmmgJ4h0XtkT3m1KlSiGQh0JMOsMh7k8cnZC lbL8uNkeLUIn5MFZrIZhkD1PhPYIbwRT+Kdc7olWu5qJvxWtjEHwfp62G1AtTmfnGqvra6mcvyU u+iaUtNojaH13FTQEbqvLfkbziYfeVqibAPCVi/cUSg== X-Received: by 2002:a63:6644:: with SMTP id a65mr3966395pgc.431.1623835692228; Wed, 16 Jun 2021 02:28:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxP1r2/tnSACBUqAVJSZsvh4f2v25ZAQ1BpTYQ8qzqXogVVtOU0xvIAm37d5R4P1bneZXCn0Q== X-Received: by 2002:a63:6644:: with SMTP id a65mr3966377pgc.431.1623835692066; Wed, 16 Jun 2021 02:28:12 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id d22sm1679372pgb.15.2021.06.16.02.28.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 02:28:11 -0700 (PDT) Subject: Re: [PATCH net-next v5 03/15] virtio-net: add priv_flags IFF_NOT_USE_DMA_ADDR To: Xuan Zhuo , netdev@vger.kernel.org References: <20210610082209.91487-1-xuanzhuo@linux.alibaba.com> <20210610082209.91487-4-xuanzhuo@linux.alibaba.com> From: Jason Wang Message-ID: <6cbab579-93a7-27db-9b8f-0f94f1b20b13@redhat.com> Date: Wed, 16 Jun 2021 17:27:59 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210610082209.91487-4-xuanzhuo@linux.alibaba.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Song Liu , Martin KaFai Lau , Jesper Dangaard Brouer , Daniel Borkmann , "Michael S. Tsirkin" , Yonghong Song , John Fastabend , Alexei Starovoitov , Andrii Nakryiko , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , "dust . li" , Jonathan Lemon , KP Singh , Jakub Kicinski , bpf@vger.kernel.org, virtualization@lists.linux-foundation.org, "David S. Miller" , Magnus Karlsson X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CtTaIDIwMjEvNi8xMCDPws7nNDoyMSwgWHVhbiBaaHVvINC0tcA6Cj4gdmlydGlvLW5ldCBub3Qg dXNlIGRtYSBhZGRyIGRpcmVjdGx5LiBTbyBhZGQgdGhpcyBwcml2X2ZsYWdzCj4gSUZGX05PVF9V U0VfRE1BX0FERFIuCj4KPiBTaWduZWQtb2ZmLWJ5OiBYdWFuIFpodW8gPHh1YW56aHVvQGxpbnV4 LmFsaWJhYmEuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9uZXQvdmlydGlvX25ldC5jIHwgMiArLQo+ ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jIGIvZHJpdmVycy9uZXQvdmlydGlvX25l dC5jCj4gaW5kZXggMDQxNmE3ZTAwOTE0Li42YzEyMzNmMGFiM2UgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9uZXQvdmlydGlvX25ldC5jCj4gKysrIGIvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4g QEAgLTMwNjQsNyArMzA2NCw3IEBAIHN0YXRpYyBpbnQgdmlydG5ldF9wcm9iZShzdHJ1Y3Qgdmly dGlvX2RldmljZSAqdmRldikKPiAgIAo+ICAgCS8qIFNldCB1cCBuZXR3b3JrIGRldmljZSBhcyBu b3JtYWwuICovCj4gICAJZGV2LT5wcml2X2ZsYWdzIHw9IElGRl9VTklDQVNUX0ZMVCB8IElGRl9M SVZFX0FERFJfQ0hBTkdFIHwKPiAtCQkJICAgSUZGX1RYX1NLQl9OT19MSU5FQVI7Cj4gKwkJCSAg IElGRl9UWF9TS0JfTk9fTElORUFSIHwgSUZGX05PVF9VU0VfRE1BX0FERFI7CgoKSSB3b25kZXIg aW5zdGVhZCBvZiBkb2luZyB0cmljayBsaWtlIHRoaXMsIGhvdyBhYm91dCB0ZWFjaCB0aGUgdmly dGlvIApjb3JlIHRvIGFjY2VwdCBETUEgYWRkcmVzcyB2aWEgc2c/CgpUaGFua3MKCgo+ICAgCWRl di0+bmV0ZGV2X29wcyA9ICZ2aXJ0bmV0X25ldGRldjsKPiAgIAlkZXYtPmZlYXR1cmVzID0gTkVU SUZfRl9ISUdIRE1BOwo+ICAgCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3Jn L21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=