From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB36C4361B for ; Mon, 14 Dec 2020 21:51:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40E4622262 for ; Mon, 14 Dec 2020 21:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731622AbgLNVuk (ORCPT ); Mon, 14 Dec 2020 16:50:40 -0500 Received: from 18.mo3.mail-out.ovh.net ([87.98.172.162]:45494 "EHLO 18.mo3.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436923AbgLNVtZ (ORCPT ); Mon, 14 Dec 2020 16:49:25 -0500 X-Greylist: delayed 11999 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Dec 2020 16:49:23 EST Received: from player770.ha.ovh.net (unknown [10.108.54.13]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id F2DC926F8FE for ; Mon, 14 Dec 2020 18:34:20 +0100 (CET) Received: from milecki.pl (ip-194-187-74-233.konfederacka.maverick.com.pl [194.187.74.233]) (Authenticated sender: rafal@milecki.pl) by player770.ha.ovh.net (Postfix) with ESMTPSA id 56FF51940B729; Mon, 14 Dec 2020 17:34:09 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-101G00459e50d39-8802-42d9-a094-f936f683c867, 9D4513A06938E8562C9FC8D5040FBB067C1A90C8) smtp.auth=rafal@milecki.pl X-OVh-ClientIp: 194.187.74.233 Subject: Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB To: Florian Fainelli , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring Cc: Philipp Zabel , "Rafael J . Wysocki" , Kevin Hilman , Ulf Hansson , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org References: <20201211215942.5726-1-zajec5@gmail.com> <20201211215942.5726-3-zajec5@gmail.com> <3bc097fa-3bef-396f-a4fd-fa8acbc1b71d@gmail.com> <18ebb7ab-2a45-f9fb-a094-0e63d44eadad@milecki.pl> <55a37742-1f4e-3697-e0e2-e42d67d75e07@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: <6cbca0e0-314f-3571-90bb-c701cfef56d9@milecki.pl> Date: Mon, 14 Dec 2020 18:34:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <55a37742-1f4e-3697-e0e2-e42d67d75e07@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 11681211537170337329 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrudekkedguddtfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtkeertddtfeejnecuhfhrohhmpeftrghfrghlucfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeekudehjeehffdufefhgffhgeejjeelteekveeuleevgeekhffhffeiheellefgveenucfkpheptddrtddrtddrtddpudelgedrudekjedrjeegrddvfeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeejtddrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehrrghfrghlsehmihhlvggtkhhirdhplhdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.12.2020 18:32, Florian Fainelli wrote: > On 12/14/20 4:24 AM, Rafał Miłecki wrote: >> On 11.12.2020 23:08, Florian Fainelli wrote: >>> On 12/11/20 1:59 PM, Rafał Miłecki wrote: >>>> From: Rafał Miłecki >>>> >>>> PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). >>>> It's needed to power on and off SoC blocks like PCIe, SATA, USB. >>>> >>>> Signed-off-by: Rafał Miłecki >>> >>> I will do a more thorough review tonight, however do you mind moving the >>> driver under drives/soc/bcm/bcm63xx? The first SoC that had PMB was >>> 63138 and that one is DSL. >> >> I now realized that bcm63xx's: >> * Kconfig is wrapper in: if SOC_BCM63XX >> * Makefile is conditional: obj-$(CONFIG_SOC_BCM63XX) >> >> So it means I've to either: >> 1. Refactor bcm63xx structure >> 2. Make SOC_BCM63XX selectable on ARCH_BCM4908 and select it >> >> I'm not sure if any of above is a really good idea. Any further thought, >> ideas? > > Well, I was thinking about thing along those lines below, it's really > about putting drivers that belong to the same SoC family in the same > basket for easier maintenance while submitting patches/pull requests > from my side. > > diff --git a/drivers/soc/bcm/Makefile b/drivers/soc/bcm/Makefile > index 7bc90e0bd773..0f0efa28d92b 100644 > --- a/drivers/soc/bcm/Makefile > +++ b/drivers/soc/bcm/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0-only > obj-$(CONFIG_BCM2835_POWER) += bcm2835-power.o > obj-$(CONFIG_RASPBERRYPI_POWER) += raspberrypi-power.o > -obj-$(CONFIG_SOC_BCM63XX) += bcm63xx/ > +obj-y += bcm63xx/ > obj-$(CONFIG_SOC_BRCMSTB) += brcmstb/ > diff --git a/drivers/soc/bcm/bcm63xx/Kconfig > b/drivers/soc/bcm/bcm63xx/Kconfig > index 16f648a6c70a..76fb61e7377e 100644 > --- a/drivers/soc/bcm/bcm63xx/Kconfig > +++ b/drivers/soc/bcm/bcm63xx/Kconfig > @@ -10,3 +10,8 @@ config BCM63XX_POWER > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs. > > endif # SOC_BCM63XX > + > +config BCM_PMB_POWER > + tristate "Broadcom PMB bus power domain driver" > + depends on BMIPS_GENERIC || ARCH_BCM4908 || COMPILE_TEST > + default ARCH_BCM4908 Sounds OK to me, thanks for clarifying what approach you're OK with!