* [PATCH 1/1] wget.py: use BPN when parsing upstream directory paths
[not found] <cover.1441294533.git.alexander.kanavin@linux.intel.com>
@ 2015-09-03 15:37 ` Alexander Kanavin
2015-09-03 15:48 ` Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Kanavin @ 2015-09-03 15:37 UTC (permalink / raw)
To: bitbake-devel
PN in this context may contain bogus suffixes like -native etc.
Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
---
bitbake/lib/bb/fetch2/wget.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bitbake/lib/bb/fetch2/wget.py b/bitbake/lib/bb/fetch2/wget.py
index bd2a897..d32f5d0 100644
--- a/bitbake/lib/bb/fetch2/wget.py
+++ b/bitbake/lib/bb/fetch2/wget.py
@@ -521,11 +521,11 @@ class Wget(FetchMethod):
path = ud.path.split(package)[0]
# search for version matches on folders inside the path, like:
- # "5.7" in http://download.gnome.org/sources/${PN}/5.7/${PN}-${PV}.tar.gz
+ # "5.7" in http://download.gnome.org/sources/${BPN}/5.7/${BPN}-${PV}.tar.gz
dirver_regex = re.compile("(?P<dirver>[^/]*(\d+\.)*\d+([-_]r\d+)*)/")
m = dirver_regex.search(path)
if m:
- pn = d.getVar('PN', True)
+ pn = d.getVar('BPN', True)
dirver = m.group('dirver')
dirver_pn_regex = re.compile("%s\d?" % (re.escape(pn)))
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] wget.py: use BPN when parsing upstream directory paths
2015-09-03 15:37 ` [PATCH 1/1] wget.py: use BPN when parsing upstream directory paths Alexander Kanavin
@ 2015-09-03 15:48 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2015-09-03 15:48 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: bitbake-devel
On Thu, 2015-09-03 at 18:37 +0300, Alexander Kanavin wrote:
> PN in this context may contain bogus suffixes like -native etc.
This is not that simple sadly. Bitbake has no knowledge of BPN, not
should it have really :/. This suggests we have a bit of an API
problem...
At the very least we should fallback to PN here is BPN isn't set.
Cheers,
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-03 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1441294533.git.alexander.kanavin@linux.intel.com>
2015-09-03 15:37 ` [PATCH 1/1] wget.py: use BPN when parsing upstream directory paths Alexander Kanavin
2015-09-03 15:48 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.