All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Aman Kumar <aman.kumar@intel.com>
Subject: Re: [PATCH v2 2/2] serial: 8250_lpss: Enable PSE UART Auto Flow Control
Date: Wed, 6 Oct 2021 06:46:12 +0200	[thread overview]
Message-ID: <6cc7b75f-1606-2150-ab51-af2922108abf@kernel.org> (raw)
In-Reply-To: <20211005133026.21488-2-andriy.shevchenko@linux.intel.com>

On 05. 10. 21, 15:30, Andy Shevchenko wrote:
> From: Aman Kumar <aman.kumar@intel.com>
> 
> Add a call to the custom ->set_termios() which has implementation about
> changing the state of RTS and CTS.

Worth noting that:
   config SERIAL_8250_LPSS
already does:
         select SERIAL_8250_DWLIB

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> Signed-off-by: Aman Kumar <aman.kumar@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: no changes
>   drivers/tty/serial/8250/8250_lpss.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
> index 398d2c4a40e3..d3bafec7619d 100644
> --- a/drivers/tty/serial/8250/8250_lpss.c
> +++ b/drivers/tty/serial/8250/8250_lpss.c
> @@ -164,6 +164,9 @@ static int ehl_serial_setup(struct lpss8250 *lpss, struct uart_port *port)
>   	 * matching with the registered General Purpose DMA controllers.
>   	 */
>   	up->dma = dma;
> +
> +	port->set_termios = dw8250_do_set_termios;
> +
>   	return 0;
>   }
>   
> 


-- 
js
suse labs

      reply	other threads:[~2021-10-06  4:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 13:30 [PATCH v2 1/2] serial: 8250_lpss: Extract dw8250_do_set_termios() for common use Andy Shevchenko
2021-10-05 13:30 ` [PATCH v2 2/2] serial: 8250_lpss: Enable PSE UART Auto Flow Control Andy Shevchenko
2021-10-06  4:46   ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cc7b75f-1606-2150-ab51-af2922108abf@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=aman.kumar@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.