From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Date: Thu, 16 Apr 2020 19:19:07 +0200 Subject: [PATCH 5/5] dlmalloc: remove unit test support in SPL In-Reply-To: <20200416170002.GS12111@bill-the-cat> References: <20200415164623.142908-1-xypron.glpk@gmx.de> <20200415164623.142908-6-xypron.glpk@gmx.de> <20200416023236.GN12111@bill-the-cat> <69d1e689-fe48-1f85-ff15-568109215f3b@gmx.de> <20200416170002.GS12111@bill-the-cat> Message-ID: <6cceb765-7493-f738-d276-bb9d7b878d1d@gmx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16.04.20 19:00, Tom Rini wrote: > On Thu, Apr 16, 2020 at 05:37:56PM +0200, Heinrich Schuchardt > wrote: >> On 4/16/20 4:32 AM, Tom Rini wrote: >>> On Wed, Apr 15, 2020 at 06:46:23PM +0200, Heinrich Schuchardt >>> wrote: >>> >>>> We cannot run unit tests in SPL. So remove the unit test >>>> support. >>>> >>>> Signed-off-by: Heinrich Schuchardt --- >>>> common/dlmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 >>>> deletion(-) >>> >>> Does this show up as a problem somewhere? I don't see this >>> resulting in size savings anywhere, thanks. >>> >> >> pine64-lts_defconfig + CONFIG_UNIT_TEST=y: >> >> without patch: 1487904 spl/u-boot-spl >> >> with patch: 1485712 spl/u-boot-spl >> >> The difference seems to be in the size of debug sections. > > Interesting, what toolchain are you using? That doesn't show up > here. Thanks! > I am on Debian Bullseye gcc-9.2. As you already remarked replying to another patch the linker is stripping the differences. My idea is that we should only compile the necessary. Best regards Heinrich