From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42BCFC433E0 for ; Wed, 12 Aug 2020 13:11:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DB7C207DA for ; Wed, 12 Aug 2020 13:11:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="uaKlMmQD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbgHLNLr (ORCPT ); Wed, 12 Aug 2020 09:11:47 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:52772 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbgHLNLq (ORCPT ); Wed, 12 Aug 2020 09:11:46 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200812131144euoutp02bc649a5a262eb257ed184a2c47b11790~qh2lcaFyv2357723577euoutp02M for ; Wed, 12 Aug 2020 13:11:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200812131144euoutp02bc649a5a262eb257ed184a2c47b11790~qh2lcaFyv2357723577euoutp02M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597237904; bh=PokaBIPWOJxSuIMEJIZ7IgGf7rjk5z6WYaxEcxqcK5g=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=uaKlMmQD2379CNOcbtOOBNTu2QKqekqZJnemjUCMeAh0M9Sf0pTmK2gs5DZErYwYB 7NfatUSciFc0UXRfbhDLXmXt3DqbzNq4rXlEJFWgrlTaZsTy9XVnODDlmYzs9I7g9W uI8g0hfRXPN/Igkn6Fb1Aisksdxdt0/W5zbNJCSo= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200812131143eucas1p23655073adcfe3970743ac2ab1d604e7c~qh2k517Ts1886018860eucas1p2Y; Wed, 12 Aug 2020 13:11:43 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 75.73.06318.F8AE33F5; Wed, 12 Aug 2020 14:11:43 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200812131143eucas1p2927d17920837183f222c2c5b3b8aac03~qh2khSdFj2499724997eucas1p2O; Wed, 12 Aug 2020 13:11:43 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200812131143eusmtrp18796d8a168e57b8d730b77f4d7f17aa9~qh2kgT6pC2515425154eusmtrp1J; Wed, 12 Aug 2020 13:11:43 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-d3-5f33ea8febbc Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 19.12.06017.F8AE33F5; Wed, 12 Aug 2020 14:11:43 +0100 (BST) Received: from [106.210.123.115] (unknown [106.210.123.115]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200812131141eusmtip15b8444b27aee49db1a159e0263ea9a70~qh2jEGBB90994809948eusmtip1d; Wed, 12 Aug 2020 13:11:41 +0000 (GMT) Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration To: Arnd Bergmann Cc: Stephen Boyd , Alexandre Torgue , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Tomasz Figa , Will Deacon , Wim Van Sebroeck , Linux ARM , linux-clk , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , linux-stm32@st-md-mailman.stormreply.com, LINUXWATCHDOG , patches@opensource.cirrus.com, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao From: Sylwester Nawrocki Message-ID: <6ccf14a9-802f-25b8-494d-e957cafd073d@samsung.com> Date: Wed, 12 Aug 2020 15:11:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUxTVxjGPb339l4ai9erC2/ATG00ZosiDJecRCU6R3LiHwZj/MOZwbp5 g0RatKU6TBZBpyiWj4FYLAT5cH40fBUQBbMiFe22gg0xYlW6ZWvHAOkqKwYEBWnvzPjvd97n efK+T3I4SrDLo7l0bZao06ozVHIF3f7gtWtD0WhCatyYPQ5bfU6E35Y8YHHgqhHhJxN/M7jI +4LCLlczi/tOjrG4xTvA4HHjbwwud9lkOH/Ax2B3o43F9rKfEPbV9MrwTHsujRt6PCyuetvA 4P5fk3Aw0MXg2QErjSdL+mncOlghx3l/jVDY0vkG4e8HP8XekVkK/2GskG+LIfVV9Yg8Guin yMx0CSIB92mW1DmfIFLUGGRIh9nDkhbLOTm5UV/PkNYrJ4ipcg6R1hfDFOmYzGFJYZsFEddY GU26bfHJwheKLQfEjPSjom5j4leKg4Vd2w4PRX4btMfkoIrF+SiCA34TDJaZmHyk4AT+OoI/ S3uYkCDwEwgCjk2SEETw86Ny5n2iLmeUloRrCGz3J+TSYxzBZG4BFXIt49Mhz9+EQrycXw1l w0NUyETxzzgYrnCGBTkfDwX3C8Os5BPh3yG3LMQ0vxb6yufC/AGfAjcdj2WSZyn8cslHhziC 3w295f5wluKj4JnvskzilXDLXxleBnxeBFhrxpF09+dwr7aKlngZjDraWIlXgLPUSEuBUwiM d56z0qMYwe+O6v/Sm2Hw4fR8UW5+xUfQ1LlRGm8Hh6OYCY2BjwS3f6l0RCSUtJsoaayEs2cE yb0GZiwmmcTRcN43RxcjlXlBNfOCOuYFdcz/761GtAVFiQa9Jk3UJ2jFY7F6tUZv0KbFfpOp aUHzP9s563h1G9nefG1HPIdUi5XVP3ySKjDqo/psjR0BR6mWKz/rc6YIygPq7OOiLjNVZ8gQ 9XYUw9GqKGVC7ciXAp+mzhIPieJhUfdelXER0Tno5v7nzbpFi16tS07et7lbc2SL5954INj9 Xar8dceh3E7lutLYSR/TYFjbPD11aquVbjh+cVU2EXaVJrlNL6vXr0j32KMMP177Z1/biaeZ 3rHTe2/0dZm0e/xbWwumEhVBa+Ndv9azoy6zZUdvXWXahfU7a7xZRJ208sO7U3HHepbsV9H6 g+r4jymdXv0OSMDgb9UDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA03Sa0hTYRzHcZ6dc7ZZro5z5pO+sBYSFB07W+bjJZEiOkWQFfSiizrypJLb bGdaFpSZoS7vpNlmU7GiTC0vmEYqrjLKZJiwpJxhLst0jVSw8tbcCHz35eH3efHAX4iJBwg/ YZJKy2pUimQpfxXeu/jauq3whzx2e0P/OtRo6wVooaRHgBz38wD6MPONQIWjExgym58IUF/m pAA1jVoI9CtvmEDl5k4e0llsBBps6BQgU2kHQLbqdzw013oVR/UvrQJkXKgnUP/bvWja0UWg RUsjjmZL+nHUPGTgo+yv4xiqfTYPUNZQMBodX8TQSJ6BH+XP1BnrADNg6ceYub8lgHEMXhcw Nb0fAFPYME0w7XqrgGmqzeUzD+vqCKb57hXmVsUSYJonvmNM+2yGgCloqQWMebIUZ7o76Wjx cSpCo07VshsS1Zx2l/QEjWQUHYoo2Y5QipaHnAqTBUuDIiPi2eSkNFYTFBlHJRZ0RaWMrbkw bfLPAAZPHfAQQnIHrMn4gS+3mLwH4IsZSgeEznc/WJkldU+84bxFx9eBVc6JA8Ccm4OuvTeZ BLPtj8FyS8iNsPT7GLY8wsgvQjgwMgvcogODmc1FLsEnaZj/qsAlRGQknBob5C03TgbCvvIl V/uQMXA0fwlzb7zgm9s2l/UgD8N35XaXxcjNcN74HnO3L/xoq+S5OwA+tVdgRUCsX8H1K4h+ BdGvIFUArwUSNpVTJig5GcUplFyqKoE6rVY2AedBtfb8aWkDup9HTYAUAqmnqKpYFismFGlc utIEoBCTSkS7+3pjxKJ4RfpFVqOO1aQms5wJBDs/V4z5+ZxWO89TpY2lg+kQFEqHyEPkO5HU V5RDdp8UkwkKLXuWZVNYzX/HE3r4ZQD22x6RUm+2Pqz8+mWoJflBwLXuemoq8YD/c3ULF7j6 cumprPdnvLsM6702HZDjjyQDd8IOapM0dondut8YEBbtVVOhqoh/Vtamng1vqMqNS4s/wh85 Wnb/0KLHsaHxmbe8W7+LjeeHt37uSDN6VocbUi7FRN+wHNtXfe5To6zHsVaKc4kKegum4RT/ AL22A/hmAwAA X-CMS-MailID: 20200812131143eucas1p2927d17920837183f222c2c5b3b8aac03 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200812091510eucas1p15944eb26bb496e20b9fadd609063a490 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200812091510eucas1p15944eb26bb496e20b9fadd609063a490 References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 12.08.2020 13:28, Arnd Bergmann wrote: > On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki > wrote: >> On 12.08.2020 11:14, Arnd Bergmann wrote: >>> >>> It seems there have never been any callers and the entire file >>> can just be removed, with the rest of that platform_data header >>> file moved to drivers/media/platform/s3c-camif/. >> >> Yes, it seems that patch never made it to mainline: >> https://protect2.fireeye.com/v1/url?k=abe5f73a-f6293cfe-abe47c75-0cc47a314e9a-7fafe832d055d852&q=1&e=2596ffb6-c4cb-492a-8c6f-a0e261567842&u=https%3A%2F%2Fgit.linuxtv.org%2Fsnawrocki%2Fmedia.git%2Fcommit%2F%3Fh%3Dtesting%2Fs3c-camif%26id%3D355cbf835aff2aabf78390931cbbaa608af77967 > > I suppose it would still apply if anyone was interested, but I see your > point. > >> I doubt there are still users of camera on the s3c2440 boards >> with current mainline kernels, if any at all, there are much >> better HW alternatives right now. > > I see two board files (and no DT) instantiate the camif device: > NexVision Nexcoder 2440 and the FriendlyARM mini2440. > > Can you say whether the camif on those would actually work > at all without your patch? If not, we know that there are no > users of that driver and could either drop it completely or move > it to staging for a release or two. Without additional patches the camif will not work, the driver needs an instance of struct s3c_camif_plat_data which specifies what image sensor is attached. I think we can drop the driver, together with the s3c_camif_device platform device definitions. It can always be added again if anyone ever needs it or converts the platform to DT. IMO all non-DT code in arch/arm/mach-s3c24xx is a candidate for removal, it just adds to the maintenance effort and I seriously doubt there are now any users of it. -- Regards, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7C0C433E0 for ; Wed, 12 Aug 2020 13:13:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A963F206B5 for ; Wed, 12 Aug 2020 13:13:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gI4B5j2s"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="uaKlMmQD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A963F206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:MIME-Version:Date:Message-ID: From:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EaddmJtN78C+H+p82vimOAZL20HuU8s2jhM4Ez/FXZY=; b=gI4B5j2s02LrHkQnGUx/QLgyx 4IvN8yW0WwGjB8QohG2AbIu3v0OZIQkwJ3zMyIHhMfujzgbQTOMPlg25NYkKlARwHzVGq7Ye59lJZ gX0VZNzoGhG2pUW9DNkS2OLB2TT0Uq3ZNG0o9oUYN5LqG2lYhI/rDvOkNFcUrL+KXPMETkkYIo2Y5 m8OLuZGSc/Y9LCfa0l0Vx3pvy5FGJwoTYWNPMmmIHrw6Pr2iI2GZMvTBzcU+08F+e4QBE01IVzGWY v5PquUGX0uBGPy8+gZfI6Sw/GsMyJZPU2emcah+HBnOcQR4i1NCbke0sB4Zwpr0a+lmVyHA+Itbp8 pUiVNLpuw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5qXo-0000vg-Sk; Wed, 12 Aug 2020 13:11:52 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5qXl-0000uE-FR for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 13:11:50 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200812131144euoutp025072c8d4b72f327fd84bb2f530ec7545~qh2lW2or02338123381euoutp02g for ; Wed, 12 Aug 2020 13:11:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200812131144euoutp025072c8d4b72f327fd84bb2f530ec7545~qh2lW2or02338123381euoutp02g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597237904; bh=PokaBIPWOJxSuIMEJIZ7IgGf7rjk5z6WYaxEcxqcK5g=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=uaKlMmQD2379CNOcbtOOBNTu2QKqekqZJnemjUCMeAh0M9Sf0pTmK2gs5DZErYwYB 7NfatUSciFc0UXRfbhDLXmXt3DqbzNq4rXlEJFWgrlTaZsTy9XVnODDlmYzs9I7g9W uI8g0hfRXPN/Igkn6Fb1Aisksdxdt0/W5zbNJCSo= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200812131143eucas1p23655073adcfe3970743ac2ab1d604e7c~qh2k517Ts1886018860eucas1p2Y; Wed, 12 Aug 2020 13:11:43 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 75.73.06318.F8AE33F5; Wed, 12 Aug 2020 14:11:43 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200812131143eucas1p2927d17920837183f222c2c5b3b8aac03~qh2khSdFj2499724997eucas1p2O; Wed, 12 Aug 2020 13:11:43 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200812131143eusmtrp18796d8a168e57b8d730b77f4d7f17aa9~qh2kgT6pC2515425154eusmtrp1J; Wed, 12 Aug 2020 13:11:43 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-d3-5f33ea8febbc Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 19.12.06017.F8AE33F5; Wed, 12 Aug 2020 14:11:43 +0100 (BST) Received: from [106.210.123.115] (unknown [106.210.123.115]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200812131141eusmtip15b8444b27aee49db1a159e0263ea9a70~qh2jEGBB90994809948eusmtip1d; Wed, 12 Aug 2020 13:11:41 +0000 (GMT) Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration To: Arnd Bergmann From: Sylwester Nawrocki Message-ID: <6ccf14a9-802f-25b8-494d-e957cafd073d@samsung.com> Date: Wed, 12 Aug 2020 15:11:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUxTVxjGPb339l4ai9erC2/ATG00ZosiDJecRCU6R3LiHwZj/MOZwbp5 g0RatKU6TBZBpyiWj4FYLAT5cH40fBUQBbMiFe22gg0xYlW6ZWvHAOkqKwYEBWnvzPjvd97n efK+T3I4SrDLo7l0bZao06ozVHIF3f7gtWtD0WhCatyYPQ5bfU6E35Y8YHHgqhHhJxN/M7jI +4LCLlczi/tOjrG4xTvA4HHjbwwud9lkOH/Ax2B3o43F9rKfEPbV9MrwTHsujRt6PCyuetvA 4P5fk3Aw0MXg2QErjSdL+mncOlghx3l/jVDY0vkG4e8HP8XekVkK/2GskG+LIfVV9Yg8Guin yMx0CSIB92mW1DmfIFLUGGRIh9nDkhbLOTm5UV/PkNYrJ4ipcg6R1hfDFOmYzGFJYZsFEddY GU26bfHJwheKLQfEjPSjom5j4leKg4Vd2w4PRX4btMfkoIrF+SiCA34TDJaZmHyk4AT+OoI/ S3uYkCDwEwgCjk2SEETw86Ny5n2iLmeUloRrCGz3J+TSYxzBZG4BFXIt49Mhz9+EQrycXw1l w0NUyETxzzgYrnCGBTkfDwX3C8Os5BPh3yG3LMQ0vxb6yufC/AGfAjcdj2WSZyn8cslHhziC 3w295f5wluKj4JnvskzilXDLXxleBnxeBFhrxpF09+dwr7aKlngZjDraWIlXgLPUSEuBUwiM d56z0qMYwe+O6v/Sm2Hw4fR8UW5+xUfQ1LlRGm8Hh6OYCY2BjwS3f6l0RCSUtJsoaayEs2cE yb0GZiwmmcTRcN43RxcjlXlBNfOCOuYFdcz/761GtAVFiQa9Jk3UJ2jFY7F6tUZv0KbFfpOp aUHzP9s563h1G9nefG1HPIdUi5XVP3ySKjDqo/psjR0BR6mWKz/rc6YIygPq7OOiLjNVZ8gQ 9XYUw9GqKGVC7ciXAp+mzhIPieJhUfdelXER0Tno5v7nzbpFi16tS07et7lbc2SL5954INj9 Xar8dceh3E7lutLYSR/TYFjbPD11aquVbjh+cVU2EXaVJrlNL6vXr0j32KMMP177Z1/biaeZ 3rHTe2/0dZm0e/xbWwumEhVBa+Ndv9azoy6zZUdvXWXahfU7a7xZRJ208sO7U3HHepbsV9H6 g+r4jymdXv0OSMDgb9UDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA03Sa0hTYRzHcZ6dc7ZZro5z5pO+sBYSFB07W+bjJZEiOkWQFfSiizrypJLb bGdaFpSZoS7vpNlmU7GiTC0vmEYqrjLKZJiwpJxhLst0jVSw8tbcCHz35eH3efHAX4iJBwg/ YZJKy2pUimQpfxXeu/jauq3whzx2e0P/OtRo6wVooaRHgBz38wD6MPONQIWjExgym58IUF/m pAA1jVoI9CtvmEDl5k4e0llsBBps6BQgU2kHQLbqdzw013oVR/UvrQJkXKgnUP/bvWja0UWg RUsjjmZL+nHUPGTgo+yv4xiqfTYPUNZQMBodX8TQSJ6BH+XP1BnrADNg6ceYub8lgHEMXhcw Nb0fAFPYME0w7XqrgGmqzeUzD+vqCKb57hXmVsUSYJonvmNM+2yGgCloqQWMebIUZ7o76Wjx cSpCo07VshsS1Zx2l/QEjWQUHYoo2Y5QipaHnAqTBUuDIiPi2eSkNFYTFBlHJRZ0RaWMrbkw bfLPAAZPHfAQQnIHrMn4gS+3mLwH4IsZSgeEznc/WJkldU+84bxFx9eBVc6JA8Ccm4OuvTeZ BLPtj8FyS8iNsPT7GLY8wsgvQjgwMgvcogODmc1FLsEnaZj/qsAlRGQknBob5C03TgbCvvIl V/uQMXA0fwlzb7zgm9s2l/UgD8N35XaXxcjNcN74HnO3L/xoq+S5OwA+tVdgRUCsX8H1K4h+ BdGvIFUArwUSNpVTJig5GcUplFyqKoE6rVY2AedBtfb8aWkDup9HTYAUAqmnqKpYFismFGlc utIEoBCTSkS7+3pjxKJ4RfpFVqOO1aQms5wJBDs/V4z5+ZxWO89TpY2lg+kQFEqHyEPkO5HU V5RDdp8UkwkKLXuWZVNYzX/HE3r4ZQD22x6RUm+2Pqz8+mWoJflBwLXuemoq8YD/c3ULF7j6 cumprPdnvLsM6702HZDjjyQDd8IOapM0dondut8YEBbtVVOhqoh/Vtamng1vqMqNS4s/wh85 Wnb/0KLHsaHxmbe8W7+LjeeHt37uSDN6VocbUi7FRN+wHNtXfe5To6zHsVaKc4kKegum4RT/ AL22A/hmAwAA X-CMS-MailID: 20200812131143eucas1p2927d17920837183f222c2c5b3b8aac03 X-Msg-Generator: CA X-RootMTR: 20200812091510eucas1p15944eb26bb496e20b9fadd609063a490 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200812091510eucas1p15944eb26bb496e20b9fadd609063a490 References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_091149_696522_FCDFD175 X-CRM114-Status: GOOD ( 26.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Michael Turquette , Tomasz Figa , Will Deacon , linux-clk , LINUXWATCHDOG , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Sylwester Nawrocki , Cedric Roux , Russell King , Krzysztof Kozlowski , linux-stm32@st-md-mailman.stormreply.com, Lihua Yao , Chanwoo Choi , Kukjin Kim , Marek Szyprowski , Guenter Roeck , Sergio Prado , Alexandre Torgue , Wim Van Sebroeck , Simtec Linux Team , Linux ARM , Stephen Boyd , patches@opensource.cirrus.com, Kyungmin Park , Maxime Coquelin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12.08.2020 13:28, Arnd Bergmann wrote: > On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki > wrote: >> On 12.08.2020 11:14, Arnd Bergmann wrote: >>> >>> It seems there have never been any callers and the entire file >>> can just be removed, with the rest of that platform_data header >>> file moved to drivers/media/platform/s3c-camif/. >> >> Yes, it seems that patch never made it to mainline: >> https://protect2.fireeye.com/v1/url?k=abe5f73a-f6293cfe-abe47c75-0cc47a314e9a-7fafe832d055d852&q=1&e=2596ffb6-c4cb-492a-8c6f-a0e261567842&u=https%3A%2F%2Fgit.linuxtv.org%2Fsnawrocki%2Fmedia.git%2Fcommit%2F%3Fh%3Dtesting%2Fs3c-camif%26id%3D355cbf835aff2aabf78390931cbbaa608af77967 > > I suppose it would still apply if anyone was interested, but I see your > point. > >> I doubt there are still users of camera on the s3c2440 boards >> with current mainline kernels, if any at all, there are much >> better HW alternatives right now. > > I see two board files (and no DT) instantiate the camif device: > NexVision Nexcoder 2440 and the FriendlyARM mini2440. > > Can you say whether the camif on those would actually work > at all without your patch? If not, we know that there are no > users of that driver and could either drop it completely or move > it to staging for a release or two. Without additional patches the camif will not work, the driver needs an instance of struct s3c_camif_plat_data which specifies what image sensor is attached. I think we can drop the driver, together with the s3c_camif_device platform device definitions. It can always be added again if anyone ever needs it or converts the platform to DT. IMO all non-DT code in arch/arm/mach-s3c24xx is a candidate for removal, it just adds to the maintenance effort and I seriously doubt there are now any users of it. -- Regards, Sylwester _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel