From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbdFIK7b (ORCPT ); Fri, 9 Jun 2017 06:59:31 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34988 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbdFIK73 (ORCPT ); Fri, 9 Jun 2017 06:59:29 -0400 Subject: Re: [PATCH 3/3] arm: dts: mt2701: Add display subsystem related nodes for MT2701 To: Philipp Zabel Cc: Erin Lo , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, YT Shen References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-4-git-send-email-erin.lo@mediatek.com> <1496996562.2343.3.camel@pengutronix.de> From: Matthias Brugger Message-ID: <6cd7cde6-dfb4-5134-6580-e0589e731258@gmail.com> Date: Fri, 9 Jun 2017 12:59:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496996562.2343.3.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/17 10:22, Philipp Zabel wrote: > Hi Matthias, > > On Fri, 2017-06-09 at 10:14 +0200, Matthias Brugger wrote: >> >> On 01/06/17 08:08, Erin Lo wrote: >>> From: YT Shen >>> >>> This patch adds the device nodes for the DISP function blocks for MT2701 >>> >>> Signed-off-by: YT Shen >>> Signed-off-by: Erin Lo >>> --- >>> arch/arm/boot/dts/mt2701.dtsi | 84 +++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 84 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi >>> index 4f110d5..e20b65c 100644 >>> --- a/arch/arm/boot/dts/mt2701.dtsi >>> +++ b/arch/arm/boot/dts/mt2701.dtsi >>> @@ -17,6 +17,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include "skeleton64.dtsi" >>> #include "mt2701-pinfunc.h" >>> >>> @@ -24,6 +25,11 @@ >>> compatible = "mediatek,mt2701"; >>> interrupt-parent = <&sysirq>; >>> >>> + aliases { >>> + rdma0 = &rdma0; >>> + rdma1 = &rdma1; >>> + }; >>> + >> >> I know we have this alias in mt8173.dtsi, but I don't understand what >> they are for. Do you know? > > The mtk_disp_rdma platform driver uses mtk_ddp_comp_get_id() to identify > the specific RDMA instance, which calls of_alias_get_id(). The core code > needs to know which RDMA is which to correctly set up the display data > paths. > Ok, thanks for the clarification! Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthias.bgg@gmail.com (Matthias Brugger) Date: Fri, 9 Jun 2017 12:59:25 +0200 Subject: [PATCH 3/3] arm: dts: mt2701: Add display subsystem related nodes for MT2701 In-Reply-To: <1496996562.2343.3.camel@pengutronix.de> References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-4-git-send-email-erin.lo@mediatek.com> <1496996562.2343.3.camel@pengutronix.de> Message-ID: <6cd7cde6-dfb4-5134-6580-e0589e731258@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/06/17 10:22, Philipp Zabel wrote: > Hi Matthias, > > On Fri, 2017-06-09 at 10:14 +0200, Matthias Brugger wrote: >> >> On 01/06/17 08:08, Erin Lo wrote: >>> From: YT Shen >>> >>> This patch adds the device nodes for the DISP function blocks for MT2701 >>> >>> Signed-off-by: YT Shen >>> Signed-off-by: Erin Lo >>> --- >>> arch/arm/boot/dts/mt2701.dtsi | 84 +++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 84 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi >>> index 4f110d5..e20b65c 100644 >>> --- a/arch/arm/boot/dts/mt2701.dtsi >>> +++ b/arch/arm/boot/dts/mt2701.dtsi >>> @@ -17,6 +17,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include "skeleton64.dtsi" >>> #include "mt2701-pinfunc.h" >>> >>> @@ -24,6 +25,11 @@ >>> compatible = "mediatek,mt2701"; >>> interrupt-parent = <&sysirq>; >>> >>> + aliases { >>> + rdma0 = &rdma0; >>> + rdma1 = &rdma1; >>> + }; >>> + >> >> I know we have this alias in mt8173.dtsi, but I don't understand what >> they are for. Do you know? > > The mtk_disp_rdma platform driver uses mtk_ddp_comp_get_id() to identify > the specific RDMA instance, which calls of_alias_get_id(). The core code > needs to know which RDMA is which to correctly set up the display data > paths. > Ok, thanks for the clarification! Matthias