From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 1/4] net: macb: Fix regression breaking non-MDIO
 fixed-link PHYs
Date: Tue, 21 Aug 2018 16:59:34 +0200
Message-ID: <6cdfc7c0-f5df-6fb0-3119-178db580acfd@pengutronix.de>
References: <20180820121238.7779-1-a.fatoum@pengutronix.de>
 <20180820135536.GD6583@lunn.ch>
 <b5445ad9-70bd-12fe-a8e7-1dc3ec73585e@pengutronix.de>
 <20180820190630.GB12238@lunn.ch>
 <77901074-bb78-5860-d6bc-00a1826de8a6@pengutronix.de>
 <20180821133444.GB2985@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "David S. Miller" <davem@davemloft.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        kernel@pengutronix.de, netdev@vger.kernel.org, mdf@kernel.org,
        Brad Mouring <brad.mouring@ni.com>,
        Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from metis.ext.pengutronix.de ([85.220.165.71]:48057 "EHLO
        metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727511AbeHUSUM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 21 Aug 2018 14:20:12 -0400
In-Reply-To: <20180821133444.GB2985@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 08/21/2018 03:34 PM, Andrew Lunn wrote:
> I don't see where this is happening. It is looking for a gpio called
> 'link-gpios'.

First while registering the MDIO bus in __mdiobus_register:

	gpiod = devm_gpiod_get_optional(&bus->dev, "reset", GPIOD_OUT_LOW);

and then again when registering the fixed-link in mdiobus_register_gpiod:

	gpiod = fwnode_get_named_gpiod(&mdiodev->dev.of_node->fwnode,
				       "reset-gpios", 0, GPIOD_OUT_LOW,
				       "PHY reset");
 
>> But regardless, there shouldn't have been an of_mdiobus_register and a MDIO bus probe
>> before registering the fixed-link in the first place and my patch remedies that.
> 
> There are cases where you need both, e.g a switch controller over
> MDIO. So we cannot make it one or the other.

I see.

> However, there are currently no such boards. So far "net", lets go
> with your partial revert patch.

I will resend the first patch.

> But we also need patches for
> "net-next" which put it back again, allows both fixed-link and an
> mdiobus inside a subnode, and not break backwards compatibility.

I'll resend the remainder when net-next opens again.


Cheers
Ahmad