From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F67EC07E95 for ; Fri, 2 Jul 2021 19:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85AF96141C for ; Fri, 2 Jul 2021 19:07:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230266AbhGBTKB (ORCPT ); Fri, 2 Jul 2021 15:10:01 -0400 Received: from foss.arm.com ([217.140.110.172]:52972 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230172AbhGBTKA (ORCPT ); Fri, 2 Jul 2021 15:10:00 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 39E061FB; Fri, 2 Jul 2021 12:07:28 -0700 (PDT) Received: from [10.57.14.38] (unknown [10.57.14.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 270633F718; Fri, 2 Jul 2021 12:07:24 -0700 (PDT) Subject: Re: [PATCH 1/3] sched/fair: Prepare variables for increased precision of EAS estimated energy From: Lukasz Luba To: Peter Zijlstra Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Chris Redpath , Dietmar Eggemann , Morten Rasmussen , Quentin Perret , Linux PM , "Rafael J. Wysocki" , Viresh Kumar , Vincent Guittot , Ingo Molnar , Juri Lelli , Steven Rostedt , segall@google.com, Mel Gorman , Daniel Bristot de Oliveira , CCj.Yeh@mediatek.com References: <20210625152603.25960-1-lukasz.luba@arm.com> <20210625152603.25960-2-lukasz.luba@arm.com> Message-ID: <6ce4d4c8-889b-f2cf-f282-213b9a7651ab@arm.com> Date: Fri, 2 Jul 2021 20:07:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, Gentle ping. You might missed my previous email. On 6/30/21 6:28 PM, Lukasz Luba wrote: > > > On 6/30/21 6:01 PM, Rafael J. Wysocki wrote: >> On Fri, Jun 25, 2021 at 5:26 PM Lukasz Luba wrote: >>> >>> The Energy Aware Scheduler (EAS) tries to find best CPU for a waking up >>> task. It probes many possibilities and compares the estimated energy >>> values >>> for different scenarios. For calculating those energy values it >>> relies on >>> Energy Model (EM) data and em_cpu_energy(). The precision which is >>> used in >>> EM data is in milli-Watts (or abstract scale), which sometimes is not >>> sufficient. In some cases it might happen that two CPUs from different >>> Performance Domains (PDs) get the same calculated value for a given task >>> placement, but in more precised scale, they might differ. This rounding >>> error has to be addressed. This patch prepares EAS code for better >>> precision in the coming EM improvements. >>> >>> Signed-off-by: Lukasz Luba >> >> If you want me to pick up this series, this patch requires an ACK from >> the scheduler maintainers. >> > > It would be great, if you could take it after e.g. Peter ACK it. > > Peter could you have a look at it, please? > In this patch 1/3 we have only variables upgrade. > > Regards, > Lukasz Could you have a look and ACK the patch 1/3, please?