From: Luben Tuikov <luben.tuikov@amd.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: amd-gfx@lists.freedesktop.org, "Deucher,
Alexander" <Alexander.Deucher@amd.com>,
"Tuikov, Luben" <Luben.Tuikov@amd.com>
Subject: Re: [PATCH 0/5] Remove 0 MHz as a valid current frequency (v4)
Date: Tue, 19 Oct 2021 03:43:52 -0400 [thread overview]
Message-ID: <6ce5dbce-fe8e-3535-d9c3-1a45e0fcb7f0@amd.com> (raw)
In-Reply-To: <a653a699-69a9-9671-4bfd-e02f3d22fc2f@molgen.mpg.de>
On 2021-10-19 03:23, Paul Menzel wrote:
> Dear Luben,
>
>
> Sorry, two more style nits.
>
> 1. Could you please use 75 characters per line for the text width of
> the commit messages. Currently, especially 4/5, are hard to read being
> so short.
This is the default we use--I've not made any changes to the wrap. git-log(1) indents the text by 4/8 chars and it looks better if the text doesn't roll past 75 chars per line in git-log.
>
> 2. No idea, what is done in amd-gfx, but for me it is more common to
> put the iteration number (reroll count) in the PATCH tag in the
> beginning. No idea, how Patchwork deals with it.
This is what we do in amd-gfx and particularly in amdgpu, so that the version of the patch is recorded in the title of the patch and in history.
Regards,
Luben
>
>
> Kind regards,
>
> Paul
next prev parent reply other threads:[~2021-10-19 7:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 23:49 [PATCH 0/5] Remove 0 MHz as a valid current frequency (v4) Luben Tuikov
2021-10-18 23:49 ` [PATCH 1/5] drm/amd/pm: Rename a couple of functions (v3) Luben Tuikov
2021-10-18 23:49 ` [PATCH 2/5] drm/amd/pm: Rename cur_value to curr_value Luben Tuikov
2021-10-18 23:49 ` [PATCH 3/5] drm/amd/pm: Rename freq_values --> freq_value Luben Tuikov
2021-10-18 23:49 ` [PATCH 4/5] dpm/amd/pm: Sienna: Remove 0 MHz as a current clock frequency (v3) Luben Tuikov
2021-10-19 3:38 ` Lazar, Lijo
2021-10-19 4:15 ` Luben Tuikov
2021-10-19 4:38 ` Lazar, Lijo
2021-10-19 4:50 ` Luben Tuikov
2021-10-19 7:44 ` Use of conditionals with omitted operands in amdgpu (x? : y) (was: [PATCH 4/5] dpm/amd/pm: Sienna: Remove 0 MHz as a current clock frequency (v3)) Paul Menzel
2021-10-19 8:07 ` Luben Tuikov
2021-10-18 23:49 ` [PATCH 5/5] dpm/amd/pm: Navi10: Remove 0 MHz as a current clock frequency (v3) Luben Tuikov
2021-10-19 7:23 ` [PATCH 0/5] Remove 0 MHz as a valid current frequency (v4) Paul Menzel
2021-10-19 7:43 ` Luben Tuikov [this message]
2021-10-19 7:54 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ce5dbce-fe8e-3535-d9c3-1a45e0fcb7f0@amd.com \
--to=luben.tuikov@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.