From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbdASKLs (ORCPT ); Thu, 19 Jan 2017 05:11:48 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:13357 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbdASKLr (ORCPT ); Thu, 19 Jan 2017 05:11:47 -0500 Subject: Re: [PATCH perf/core 2/6] tools lib bpf: Fix grammar in map_idx warning To: Joe Stringer , References: <20170118235724.26103-1-joe@ovn.org> <20170118235724.26103-3-joe@ovn.org> CC: , , From: "Wangnan (F)" Message-ID: <6ce69a2c-e44f-c178-948c-258eb211b091@huawei.com> Date: Thu, 19 Jan 2017 18:10:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170118235724.26103-3-joe@ovn.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.194.139] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.588090B1.0116,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d9c42cc321741af6dca034d60983b3a1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/1/19 7:57, Joe Stringer wrote: > "Larger" is the comparative adjective form of "large". > > Signed-off-by: Joe Stringer > --- > tools/lib/bpf/libbpf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 350ee4c59f85..653b1b368deb 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -834,7 +834,7 @@ bpf_program__collect_reloc(struct bpf_program *prog, > > map_idx = sym.st_value / prog->obj->map_len; > if (map_idx >= nr_maps) { > - pr_warning("bpf relocation: map_idx %d large than %d\n", > + pr_warning("bpf relocation: map_idx %d larger than %d\n", With my change to 1/6, this message become meaningless. We can change it to: bpf relocation: failed to relocate instruction %u Thank you. > (int)map_idx, (int)nr_maps - 1); > return -LIBBPF_ERRNO__RELOC; > }