From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hunt, David" Subject: Re: [PATCH] test/power: fix unit test to handle pstate mode Date: Wed, 6 Feb 2019 16:24:45 +0000 Message-ID: <6d0a240c-3e8f-09d3-1f80-952cfbbd30be@intel.com> References: <20190107144051.7097-1-david.hunt@intel.com> <50a2c41a-aa5f-0d88-e227-3286ea940e02@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: liang.j.ma@intel.com, "stable@dpdk.org" , Thomas Monjalon To: Kevin Traynor , dev@dpdk.org Return-path: In-Reply-To: <50a2c41a-aa5f-0d88-e227-3286ea940e02@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Kevin, On 6/2/2019 3:47 PM, Kevin Traynor wrote: > On 01/07/2019 02:40 PM, David Hunt wrote: >> The cpufreq test breakes when the system is using the intel_pstate >> driver for frequency management. The power library has recentyly been >> updated to allow use of the intel_pstate driver, this patch fixes the >> cpufreq test so that it can now use either acpi or pstate modes. >> The library will auto-detect, and set the environment appropriately. >> >> Fixes: ed7c51a6a680 ("app/test: vm power management") >> > I think this should have been: > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > > Presumably based on the Fixes tag, it got a stable tag added also, but > it does not look correct for 18.11 and breaks the build. If that's > incorrect, please let me know. > >> Signed-off-by: David Hunt You are correct. Your suggested Fixes: line is the correct one. It's only relevant after the pstate compatibility was added. Regards, Dave.