Hi Jarkko,

On 1/3/22 10:42, Jarkko Nikula wrote:
> Hi
> 
> We have a Braswell based preproduction HW. I noticed linux-next tag next-20211224 doesn't boot on it due to following error:
> 
> [   34.674271] cherryview-pinctrl INT33FF:00: interrupt on unused interrupt line 0
> [   34.682476] cherryview-pinctrl INT33FF:00: interrupt on unused interrupt line 0
> [   34.690681] cherryview-pinctrl INT33FF:00: interrupt on unused interrupt line 0
> ...
> 
> Linux v5.16-rc8 is ok. I found the following commit to be reason for the regression:
> 
> bdfbef2d29dc ("pinctrl: cherryview: Don't use selection 0 to mark an interrupt line as unused")

Thank you for the timely headsup about this.

I assume that you have tried a revert (if necessary including reverting some
of the follow ups) and that reverting the patch you point to fixes the
issue, right ?

Can you try the 2 attached patches *one at a time* ? :

1. Restores the old behavior of just triggering hwirq 0 of
the pincontroller-domain when we don't know the mapping

2. Restores the old behavior which allows chv_gpio_irq_startup()
to overwrite the interrupt-line to pin mapping if the current
mapping points to pin 0

Both of these restore old behavior caused by a mapping-table
entry containing 0 meaning both unset as well as HWIRQ0
before the patch in question.

If applying them one at a time does not help, please also try with
both applied.

These 2 patches should apply cleanly on top of linux-next.

If patch 2 fixes things it would be interesting if you can grab a
dmesg with "pinctrl-cherryview.dyndbg" added to the command line
(with the patched kernel).

Regards,

Hans